Page MenuHomePhabricator
Differential D17860

[avalanche] Add some logging when stake contenders are cached or promoted
ClosedPublic
Actions

Authored by roqqit on Mar 26 2025, 22:55.

Details

Reviewers
Fabien
Group Reviewers
Restricted Project
Commits
rABC6fb44405d40d: [avalanche] Add some logging when stake contenders are cached or promoted
Summary

These logs are only active with -avalanchestakingpreconsensus

I have been using this patch for over a week and it has been useful for debugging contender behavior.

Test Plan
./test/functional/test_runner.py --nocleanup abc_p2p_avalanche_contender_voting

Observe new lines in the node log

Diff Detail

Repository
rABC Bitcoin ABC
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

roqqit created this revision.Mar 26 2025, 22:55
Herald added a reviewer: Restricted Project. · View Herald TranscriptMar 26 2025, 22:55
roqqit requested review of this revision.Mar 26 2025, 22:55
Harbormaster completed remote builds in B32830: Diff 53273.Mar 26 2025, 23:10
roqqit added a child revision: D17861: [avalanche] Make sure to only promote contenders once for each proofid.Mar 26 2025, 23:12
roqqit edited the test plan for this revision. (Show Details)Mar 26 2025, 23:12
Fabien requested changes to this revision.Mar 27 2025, 08:40
Fabien added a subscriber: Fabien.

For this kind of log you should use LogPrintLevel(BCLog::AVALANCHE, BCLog::Level::Debug, "foo bar baz\n");

src/avalanche/peermanager.cpp
1405–1408 ↗(On Diff #53273)
src/avalanche/stakecontendercache.cpp
72 ↗(On Diff #53273)

dito

This revision now requires changes to proceed.Mar 27 2025, 08:40
roqqit updated this revision to Diff 53284.Mar 27 2025, 16:41

feedback

Harbormaster completed remote builds in B32837: Diff 53284.Mar 27 2025, 16:55
Fabien accepted this revision.Mar 27 2025, 17:41
This revision is now accepted and ready to land.Mar 27 2025, 17:41
Closed by commit rABC6fb44405d40d: [avalanche] Add some logging when stake contenders are cached or promoted (authored by roqqit). · Explain WhyMar 27 2025, 18:00
This revision was automatically updated to reflect the committed changes.
roqqit added a commit: rABC6fb44405d40d: [avalanche] Add some logging when stake contenders are cached or promoted.

Revision Contents
Changeset List

PathSize
src/
avalanche/
10 lines
10 lines

Diff 53287

View Options

src/avalanche/peermanager.cpp

Loading...
View Options

src/avalanche/stakecontendercache.cpp

Loading...