Page MenuHomePhabricator
Differential D17898

refuse to activate a UTXO snapshot if mempool not empty
ClosedPublic
Actions

Authored by PiRK on Fri, Apr 4, 14:04.

Details

Reviewers
Fabien
Group Reviewers
Restricted Project
Commits
rABC960dac9a7937: refuse to activate a UTXO snapshot if mempool not empty
Summary

This ensures that we avoid any unexpected conditions inherent in
transferring non-empty mempools across chainstates.

Note that this should never happen in practice given that snapshot
activation will not occur outside of IBD, based upon the height checks
in loadtxoutset.

This is a partial backport of core#27596
https://github.com/bitcoin/bitcoin/pull/27596/commits/bb0585779472962f40d9cdd9c6532132850d371c

Depends on D17897

Test Plan

ninja all check-all on my dev branch and IBD with assumeutxo

The dev branch has the corresponding functional test from core#29394 (will be added after we backport the loadtxoutset RPC)

Diff Detail

Event Timeline

PiRK created this revision.Fri, Apr 4, 14:04
Herald added a reviewer: Restricted Project. · View Herald TranscriptFri, Apr 4, 14:04
PiRK requested review of this revision.Fri, Apr 4, 14:04
teamcity edited the summary of this revision. (Show Details)Fri, Apr 4, 14:04
PiRK edited the test plan for this revision. (Show Details)Fri, Apr 4, 14:05
PiRK updated this revision to Diff 53378.Fri, Apr 4, 14:09
PiRK edited the test plan for this revision. (Show Details)

actually we do have a test. Edit the test plan

Harbormaster completed remote builds in B32898: Diff 53377.Fri, Apr 4, 14:22
Harbormaster completed remote builds in B32899: Diff 53378.Fri, Apr 4, 14:27
PiRK added a child revision: D17899: validation: do not activate snapshot if behind active chain.Fri, Apr 4, 14:43
Fabien accepted this revision.Mon, Apr 7, 10:17
This revision is now accepted and ready to land.Mon, Apr 7, 10:17
Closed by commit rABC960dac9a7937: refuse to activate a UTXO snapshot if mempool not empty (authored by James O'Beirne <james.obeirne@pm.me>, committed by PiRK). · Explain WhyMon, Apr 7, 13:57
This revision was automatically updated to reflect the committed changes.
PiRK added a commit: rABC960dac9a7937: refuse to activate a UTXO snapshot if mempool not empty.

Revision Contents
Changeset List

PathSize
src/
9 lines

Diff 53377

View Options

src/validation.cpp

Loading...