Differential D17929

[avalanche] Test: Simplify checking for undesired hashes in polls
ClosedPublic
Actions

Authored by Fabien on Mon, Apr 14, 10:48.

Tags

None

Subscribers

None

Details

Reviewers

Group Reviewers

Restricted Project

Commits

rABC894ffc7982c4: [avalanche] Test: Simplify checking for undesired hashes in polls

Summary

So far we used a custom solution in abc_p2p_avalanche_transaction_finalization.py to against undesired polls. We can greatly simplify this is and make it more reusable by making this an option in the common avatools function.

Test Plan

./test/functional/test_runner.py abc_p2p_avalanche_transaction_finalization

Diff Detail

Repository

rABC Bitcoin ABC

Branch

avatools_unexpected_hashes

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 32956
Build 65396: Build Diff	build-debug · build-clang · build-clang-tidy · build-without-wallet · build-diff
Build 65395: arc lint + arc unit

Event Timeline

Fabien created this revision.Mon, Apr 14, 10:48

Herald added a reviewer: Restricted Project. · View Herald TranscriptMon, Apr 14, 10:48

Fabien requested review of this revision.Mon, Apr 14, 10:48

Fabien added a child revision: D17832: [avalanche] Poll for the transactions that didn't make it into the last block.Mon, Apr 14, 10:52

Harbormaster completed remote builds in B32956: Diff 53467.Mon, Apr 14, 11:01

PiRK accepted this revision.Mon, Apr 14, 13:33

This revision is now accepted and ready to land.Mon, Apr 14, 13:33

Closed by commit rABC894ffc7982c4: [avalanche] Test: Simplify checking for undesired hashes in polls (authored by Fabien). · Explain WhyMon, Apr 14, 16:12

This revision was automatically updated to reflect the committed changes.

Fabien added a commit: rABC894ffc7982c4: [avalanche] Test: Simplify checking for undesired hashes in polls.

Revision Contents
Changeset List

Path

Size

test/

functional/

abc_p2p_avalanche_transaction_finalization.py

56 lines

test_framework/

5 lines

Diff 53467

test/functional/abc_p2p_avalanche_transaction_finalization.py

Loading...

test/functional/test_framework/avatools.py

Loading...