[cashtab] CSS tweak for default desktop agora view
ClosedPublic
Actions

Authored by johnkuney on Thu, Apr 17, 02:04.

Details

Reviewers

emack
bytesofman

Group Reviewers

Restricted Project

Commits

Summary

It was looking a little odd that the default desktop view for agora has 4 cards but they dont
take the full width.

Adjusting it to a 4 column grid when all the offers are not loaded.

We could just leave it always 4 columns, but 5 is nice on large screens when there is a lot of content

Test Plan

npm start, go to agora check the columns, loadallzeoffers and check the columns

Repository

rABC Bitcoin ABC

Lint

Lint Not Applicable

Unit

Tests Not Applicable

johnkuney requested review of this revision.Thu, Apr 17, 02:04

emack accepted this revision.Thu, Apr 17, 04:44

This revision is now accepted and ready to land.Thu, Apr 17, 04:44

bytesofman requested changes to this revision.Thu, Apr 17, 13:48

bytesofman added a subscriber: bytesofman.

bytesofman added inline comments.

cashtab/src/components/Agora/index.tsx
634 ↗	(On Diff #53516)	instead of passing this prop, should instead pass the total number of offers in the table then the max should be 5 if we have 5 or more the total number of offers if we have less than 5 Kind of moot since we can reasonably expect to have "just one more" token on the agora landing page prob sometime soon. but if/when that happens, we need to undo this diff in the current form since then we'll have a weirder "4 across and 1 below" pattern.