Page MenuHomePhabricator
Differential D17952

refactor: remove ::vpwallets and related global variables
ClosedPublic
Actions

Authored by PiRK on Sat, Apr 19, 08:44.

Details

Reviewers
Fabien
Group Reviewers
Restricted Project
Commits
rABCb59ed33b3ac1: refactor: remove ::vpwallets and related global variables
Summary

Move global wallet variables to WalletContext struct

This is a backport of core#19101 and core#22992

Test Plan

ninja all check-all

Diff Detail

Event Timeline

PiRK created this revision.Sat, Apr 19, 08:44
Herald added a reviewer: Restricted Project. · View Herald TranscriptSat, Apr 19, 08:44
PiRK requested review of this revision.Sat, Apr 19, 08:44
teamcity edited the summary of this revision. (Show Details)Sat, Apr 19, 08:44
PiRK added a comment.Sat, Apr 19, 08:44

@bot build-asan

teamcity awarded a token.Sat, Apr 19, 08:45
Harbormaster completed remote builds in B33016: Diff 53557.Sat, Apr 19, 08:48
teamcity added a comment.Sat, Apr 19, 08:48
Build Bitcoin ABC Diffs / Diff Testing (build-clang-tidy) failed.

Tail of the build log:

[417/580] Building CXX object src/CMakeFiles/server.dir/rpc/avalanche.cpp.o
[418/580] Building CXX object src/wallet/CMakeFiles/wallet.dir/crypter.cpp.o
[419/580] Building CXX object src/wallet/CMakeFiles/wallet.dir/db.cpp.o
[420/580] Building CXX object src/CMakeFiles/server.dir/rpc/rawtransaction.cpp.o
[421/580] Building CXX object src/wallet/CMakeFiles/wallet.dir/load.cpp.o
FAILED: src/wallet/CMakeFiles/wallet.dir/load.cpp.o 
/usr/bin/cmake -E __run_co_compile --launcher=/usr/bin/ccache --tidy="/usr/bin/clang-tidy-16;-warnings-as-errors=*;--extra-arg-before=--driver-mode=g++" --source=/work/src/wallet/load.cpp -- /usr/bin/clang++ -DBOOST_ALL_NO_LIB -DBOOST_NO_CXX98_FUNCTION_BASE -DBUILD_BITCOIN_INTERNAL -DENABLE_AVX2 -DENABLE_SHANI -DENABLE_SSE41 -DHAVE_BUILD_INFO -DHAVE_CONFIG_H -DHAVE_CONSENSUS_LIB -DLEVELDB_ATOMIC_PRESENT -DLEVELDB_PLATFORM_POSIX -DOS_LINUX -I/work/src/. -I/work/abc-ci-builds/build-clang-tidy/src -I/work/src/univalue/include -I/work/abc-ci-builds/build-clang-tidy/src/crypto/.. -I/work/src/secp256k1/include -I/work/src/leveldb/include -isystem /usr/include/jemalloc -isystem /usr/include/miniupnpc -g -O2 -fPIC -fvisibility=hidden -fstack-protector-all -Wstack-protector -fcf-protection=full -fstack-clash-protection -U_FORTIFY_SOURCE -D_FORTIFY_SOURCE=2 -Wall -Wextra -Wformat -Wgnu -Wvla -Wcast-align -Wunused-parameter -Wmissing-braces -Wthread-safety -Wrange-loop-analysis -Wredundant-decls -Wunreachable-code-loop-increment -Wsign-compare -Wconditional-uninitialized -Wdocumentation -Wformat-security -Wredundant-move -Woverloaded-virtual -Wshadow -Wshadow-field -Wno-unused-parameter -Wno-implicit-fallthrough -Wno-psabi -std=gnu++17 -MD -MT src/wallet/CMakeFiles/wallet.dir/load.cpp.o -MF src/wallet/CMakeFiles/wallet.dir/load.cpp.o.d -o src/wallet/CMakeFiles/wallet.dir/load.cpp.o -c /work/src/wallet/load.cpp
/work/src/wallet/load.cpp:193:39: error: argument name 'load_on_startup' in comment does not match parameter name 'load_on_start' [bugprone-argument-comment,-warnings-as-errors]
        RemoveWallet(context, wallet, /* load_on_startup= */ std::nullopt,
                                      ^~~~~~~~~~~~~~~~~~~~~~
                                      /* load_on_start= */
/work/src/./wallet/wallet.h:64:39: note: 'load_on_start' declared here
                  std::optional<bool> load_on_start,
                                      ^
2291 warnings generated.
Suppressed 2290 warnings (2290 in non-user code).
Use -header-filter=.* to display errors from all non-system headers. Use -system-headers to display errors from system headers as well.
1 warning treated as error
[422/580] Building CXX object src/CMakeFiles/server.dir/rpc/blockchain.cpp.o
[423/580] Building CXX object src/test/CMakeFiles/testutil.dir/util/wallet.cpp.o
[424/580] Building CXX object src/wallet/CMakeFiles/wallet.dir/sqlite.cpp.o
[425/580] Building CXX object src/test/CMakeFiles/testutil.dir/util/setup_common.cpp.o
[426/580] Building CXX object src/wallet/CMakeFiles/wallet.dir/transaction.cpp.o
[427/580] Building CXX object src/wallet/CMakeFiles/wallet.dir/fees.cpp.o
[428/580] Building CXX object src/wallet/CMakeFiles/wallet.dir/rpc/signmessage.cpp.o
[429/580] Building CXX object src/wallet/CMakeFiles/wallet.dir/receive.cpp.o
[430/580] Building CXX object src/wallet/CMakeFiles/wallet.dir/rpc/util.cpp.o
[431/580] Building CXX object src/wallet/CMakeFiles/wallet.dir/walletutil.cpp.o
[432/580] Building CXX object src/seeder/CMakeFiles/seeder-base.dir/dns.cpp.o
[433/580] Building CXX object src/wallet/CMakeFiles/wallet.dir/rpc/encrypt.cpp.o
[434/580] Building CXX object src/CMakeFiles/server.dir/validation.cpp.o
[435/580] Building CXX object src/seeder/CMakeFiles/seeder-base.dir/db.cpp.o
[436/580] Building CXX object src/wallet/CMakeFiles/wallet.dir/salvage.cpp.o
[437/580] Building CXX object src/seeder/CMakeFiles/seeder-base.dir/options.cpp.o
[438/580] Building CXX object src/iguana/CMakeFiles/iguana.dir/iguana_formatter.cpp.o
[439/580] Building CXX object src/wallet/CMakeFiles/wallet.dir/wallet.cpp.o
FAILED: src/wallet/CMakeFiles/wallet.dir/wallet.cpp.o 
/usr/bin/cmake -E __run_co_compile --launcher=/usr/bin/ccache --tidy="/usr/bin/clang-tidy-16;-warnings-as-errors=*;--extra-arg-before=--driver-mode=g++" --source=/work/src/wallet/wallet.cpp -- /usr/bin/clang++ -DBOOST_ALL_NO_LIB -DBOOST_NO_CXX98_FUNCTION_BASE -DBUILD_BITCOIN_INTERNAL -DENABLE_AVX2 -DENABLE_SHANI -DENABLE_SSE41 -DHAVE_BUILD_INFO -DHAVE_CONFIG_H -DHAVE_CONSENSUS_LIB -DLEVELDB_ATOMIC_PRESENT -DLEVELDB_PLATFORM_POSIX -DOS_LINUX -I/work/src/. -I/work/abc-ci-builds/build-clang-tidy/src -I/work/src/univalue/include -I/work/abc-ci-builds/build-clang-tidy/src/crypto/.. -I/work/src/secp256k1/include -I/work/src/leveldb/include -isystem /usr/include/jemalloc -isystem /usr/include/miniupnpc -g -O2 -fPIC -fvisibility=hidden -fstack-protector-all -Wstack-protector -fcf-protection=full -fstack-clash-protection -U_FORTIFY_SOURCE -D_FORTIFY_SOURCE=2 -Wall -Wextra -Wformat -Wgnu -Wvla -Wcast-align -Wunused-parameter -Wmissing-braces -Wthread-safety -Wrange-loop-analysis -Wredundant-decls -Wunreachable-code-loop-increment -Wsign-compare -Wconditional-uninitialized -Wdocumentation -Wformat-security -Wredundant-move -Woverloaded-virtual -Wshadow -Wshadow-field -Wno-unused-parameter -Wno-implicit-fallthrough -Wno-psabi -std=gnu++17 -MD -MT src/wallet/CMakeFiles/wallet.dir/wallet.cpp.o -MF src/wallet/CMakeFiles/wallet.dir/wallet.cpp.o.d -o src/wallet/CMakeFiles/wallet.dir/wallet.cpp.o -c /work/src/wallet/wallet.cpp
/work/src/wallet/wallet.cpp:160:39: error: statement should be inside braces [readability-braces-around-statements,-warnings-as-errors]
        if (wallet->GetName() == name) return wallet;
                                      ^
                                       {
2453 warnings generated.
Suppressed 2452 warnings (2452 in non-user code).
Use -header-filter=.* to display errors from all non-system headers. Use -system-headers to display errors from system headers as well.
1 warning treated as error
[440/580] Building CXX object src/iguana/CMakeFiles/iguana.dir/iguana_interpreter.cpp.o
[441/580] Building CXX object src/seeder/CMakeFiles/bitcoin-seeder.dir/main.cpp.o
[442/580] Building CXX object src/iguana/CMakeFiles/iguana.dir/iguana.cpp.o
[443/580] Linking CXX executable src/iguana/iguana
[444/580] Building CXX object src/seeder/CMakeFiles/seeder-base.dir/bitcoin.cpp.o
[445/580] Building CXX object src/wallet/CMakeFiles/wallet.dir/interfaces.cpp.o
[446/580] Building CXX object src/wallet/CMakeFiles/wallet.dir/spend.cpp.o
[447/580] Building CXX object src/wallet/CMakeFiles/wallet.dir/scriptpubkeyman.cpp.o
[448/580] Building CXX object src/wallet/CMakeFiles/wallet.dir/rpc/backup.cpp.o
[449/580] Building CXX object src/wallet/CMakeFiles/wallet-tool.dir/wallettool.cpp.o
[450/580] Building CXX object src/wallet/CMakeFiles/wallet.dir/walletdb.cpp.o
[451/580] Building CXX object src/wallet/CMakeFiles/wallet.dir/rpcwallet.cpp.o
ninja: build stopped: cannot make progress due to previous errors.
Build build-clang-tidy failed with exit code 1
teamcity added a comment.Sat, Apr 19, 08:53
Build Bitcoin ABC Diffs / Diff Testing (build-asan) failed.

Failed tests logs:

====== Bitcoin ABC functional tests: wallet_assumeutxo.py ======

------- Stdout: -------
2025-04-19T08:51:50.436000Z TestFramework (INFO): Initializing test directory /work/abc-ci-builds/build-asan/test/tmp/test_runner_₿₵_🏃_20250419_084827/wallet_assumeutxo_291
2025-04-19T08:51:51.959000Z TestFramework (INFO): -- Testing assumeutxo
2025-04-19T08:51:51.961000Z TestFramework (INFO): Creating a UTXO snapshot at height 299
2025-04-19T08:51:52.605000Z TestFramework (INFO): Loading snapshot into second node from /work/abc-ci-builds/build-asan/test/tmp/test_runner_₿₵_🏃_20250419_084827/wallet_assumeutxo_291/node0/regtest/utxos.dat
2025-04-19T08:51:52.713000Z TestFramework (INFO): Backup from the snapshot height can be loaded during background sync
2025-04-19T08:51:52.727000Z TestFramework (INFO): Backup from before the snapshot height can't be loaded during background sync
2025-04-19T08:51:52.749000Z TestFramework (INFO): Test that rescanning blocks from before the snapshot fails when blocks are not available from the background sync yet
2025-04-19T08:51:52.750000Z TestFramework (INFO): Restarting node to stop at height 359
2025-04-19T08:51:54.355000Z TestFramework (ERROR): Assertion failed
Traceback (most recent call last):
  File "/work/test/functional/test_framework/test_framework.py", line 152, in main
    self._run_test_internal()
  File "/work/test/functional/test_framework/test_framework.py", line 142, in _run_test_internal
    self.run_test()
  File "/work/test/functional/wallet_assumeutxo.py", line 209, in run_test
    self.restart_node(
  File "/work/test/functional/test_framework/test_framework.py", line 667, in restart_node
    self.stop_node(i)
  File "/work/test/functional/test_framework/test_framework.py", line 653, in stop_node
    self.nodes[i].stop_node(expected_stderr, wait=wait)
  File "/work/test/functional/test_framework/test_node.py", line 552, in stop_node
    self.wait_until_stopped()
  File "/work/test/functional/test_framework/test_node.py", line 577, in wait_until_stopped
    wait_until_helper(
  File "/work/test/functional/test_framework/util.py", line 302, in wait_until_helper
    if predicate():
       ^^^^^^^^^^^
  File "/work/test/functional/test_framework/test_node.py", line 566, in is_node_stopped
    assert return_code == 0, self._node_msg(
           ^^^^^^^^^^^^^^^^
AssertionError: [node 1] Node returned non-zero exit code (1) when stopping
2025-04-19T08:51:54.406000Z TestFramework (INFO): Stopping nodes
[node 2] Cleaning up leftover process
[node 1] Cleaning up leftover process
[node 0] Cleaning up leftover process
------- Stderr: -------
Traceback (most recent call last):
  File "/work/test/functional/wallet_assumeutxo.py", line 269, in <module>
    AssumeutxoTest().main()
  File "/work/test/functional/test_framework/test_framework.py", line 175, in main
    exit_code = self.shutdown()
                ^^^^^^^^^^^^^^^
  File "/work/test/functional/test_framework/test_framework.py", line 404, in shutdown
    self.stop_nodes()
  File "/work/test/functional/test_framework/test_framework.py", line 659, in stop_nodes
    node.stop_node(wait=wait, wait_until_stopped=False)
  File "/work/test/functional/test_framework/test_node.py", line 532, in stop_node
    self.stop(wait=wait)
  File "/work/test/functional/test_framework/coverage.py", line 46, in __call__
    return_val = self.auth_service_proxy_instance.__call__(*args, **kwargs)
                 ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/work/test/functional/test_framework/authproxy.py", line 146, in __call__
    response, status = self._request(
                       ^^^^^^^^^^^^^^
  File "/work/test/functional/test_framework/authproxy.py", line 114, in _request
    self.__conn.request(method, path, postdata, headers)
  File "/usr/lib/python3.11/http/client.py", line 1282, in request
    self._send_request(method, url, body, headers, encode_chunked)
  File "/usr/lib/python3.11/http/client.py", line 1328, in _send_request
    self.endheaders(body, encode_chunked=encode_chunked)
  File "/usr/lib/python3.11/http/client.py", line 1277, in endheaders
    self._send_output(message_body, encode_chunked=encode_chunked)
  File "/usr/lib/python3.11/http/client.py", line 1037, in _send_output
    self.send(msg)
  File "/usr/lib/python3.11/http/client.py", line 975, in send
    self.connect()
  File "/usr/lib/python3.11/http/client.py", line 941, in connect
    self.sock = self._create_connection(
                ^^^^^^^^^^^^^^^^^^^^^^^^
  File "/usr/lib/python3.11/socket.py", line 851, in create_connection
    raise exceptions[0]
  File "/usr/lib/python3.11/socket.py", line 836, in create_connection
    sock.connect(sa)
ConnectionRefusedError: [Errno 111] Connection refused
====== Bitcoin ABC functional tests: wallet_assumeutxo.py --descriptors ======

------- Stdout: -------
2025-04-19T08:51:50.431000Z TestFramework (INFO): Initializing test directory /work/abc-ci-builds/build-asan/test/tmp/test_runner_₿₵_🏃_20250419_084827/wallet_assumeutxo_292
2025-04-19T08:51:51.959000Z TestFramework (INFO): -- Testing assumeutxo
2025-04-19T08:51:51.960000Z TestFramework (INFO): Creating a UTXO snapshot at height 299
2025-04-19T08:51:52.955000Z TestFramework (INFO): Loading snapshot into second node from /work/abc-ci-builds/build-asan/test/tmp/test_runner_₿₵_🏃_20250419_084827/wallet_assumeutxo_292/node0/regtest/utxos.dat
2025-04-19T08:51:53.029000Z TestFramework (INFO): Backup from the snapshot height can be loaded during background sync
2025-04-19T08:51:53.038000Z TestFramework (INFO): Backup from before the snapshot height can't be loaded during background sync
2025-04-19T08:51:53.058000Z TestFramework (INFO): Test loading descriptors during background sync
2025-04-19T08:51:53.080000Z TestFramework (INFO): Test that rescanning blocks from before the snapshot fails when blocks are not available from the background sync yet
2025-04-19T08:51:53.081000Z TestFramework (INFO): Restarting node to stop at height 359
2025-04-19T08:51:54.785000Z TestFramework (ERROR): Assertion failed
Traceback (most recent call last):
  File "/work/test/functional/test_framework/test_framework.py", line 152, in main
    self._run_test_internal()
  File "/work/test/functional/test_framework/test_framework.py", line 142, in _run_test_internal
    self.run_test()
  File "/work/test/functional/wallet_assumeutxo.py", line 209, in run_test
    self.restart_node(
  File "/work/test/functional/test_framework/test_framework.py", line 667, in restart_node
    self.stop_node(i)
  File "/work/test/functional/test_framework/test_framework.py", line 653, in stop_node
    self.nodes[i].stop_node(expected_stderr, wait=wait)
  File "/work/test/functional/test_framework/test_node.py", line 552, in stop_node
    self.wait_until_stopped()
  File "/work/test/functional/test_framework/test_node.py", line 577, in wait_until_stopped
    wait_until_helper(
  File "/work/test/functional/test_framework/util.py", line 302, in wait_until_helper
    if predicate():
       ^^^^^^^^^^^
  File "/work/test/functional/test_framework/test_node.py", line 566, in is_node_stopped
    assert return_code == 0, self._node_msg(
           ^^^^^^^^^^^^^^^^
AssertionError: [node 1] Node returned non-zero exit code (1) when stopping
2025-04-19T08:51:54.837000Z TestFramework (INFO): Stopping nodes
[node 2] Cleaning up leftover process
[node 1] Cleaning up leftover process
[node 0] Cleaning up leftover process
------- Stderr: -------
Traceback (most recent call last):
  File "/work/test/functional/wallet_assumeutxo.py", line 269, in <module>
    AssumeutxoTest().main()
  File "/work/test/functional/test_framework/test_framework.py", line 175, in main
    exit_code = self.shutdown()
                ^^^^^^^^^^^^^^^
  File "/work/test/functional/test_framework/test_framework.py", line 404, in shutdown
    self.stop_nodes()
  File "/work/test/functional/test_framework/test_framework.py", line 659, in stop_nodes
    node.stop_node(wait=wait, wait_until_stopped=False)
  File "/work/test/functional/test_framework/test_node.py", line 532, in stop_node
    self.stop(wait=wait)
  File "/work/test/functional/test_framework/coverage.py", line 46, in __call__
    return_val = self.auth_service_proxy_instance.__call__(*args, **kwargs)
                 ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/work/test/functional/test_framework/authproxy.py", line 146, in __call__
    response, status = self._request(
                       ^^^^^^^^^^^^^^
  File "/work/test/functional/test_framework/authproxy.py", line 114, in _request
    self.__conn.request(method, path, postdata, headers)
  File "/usr/lib/python3.11/http/client.py", line 1282, in request
    self._send_request(method, url, body, headers, encode_chunked)
  File "/usr/lib/python3.11/http/client.py", line 1328, in _send_request
    self.endheaders(body, encode_chunked=encode_chunked)
  File "/usr/lib/python3.11/http/client.py", line 1277, in endheaders
    self._send_output(message_body, encode_chunked=encode_chunked)
  File "/usr/lib/python3.11/http/client.py", line 1037, in _send_output
    self.send(msg)
  File "/usr/lib/python3.11/http/client.py", line 975, in send
    self.connect()
  File "/usr/lib/python3.11/http/client.py", line 941, in connect
    self.sock = self._create_connection(
                ^^^^^^^^^^^^^^^^^^^^^^^^
  File "/usr/lib/python3.11/socket.py", line 851, in create_connection
    raise exceptions[0]
  File "/usr/lib/python3.11/socket.py", line 836, in create_connection
    sock.connect(sa)
ConnectionRefusedError: [Errno 111] Connection refused

Each failure log is accessible here:
Bitcoin ABC functional tests: wallet_assumeutxo.py
Bitcoin ABC functional tests: wallet_assumeutxo.py --descriptors

teamcity added a comment.Sat, Apr 19, 09:00
Build Bitcoin ABC Diffs / Diff Testing (build-debug) failed.

Tail of the build log:

Totals: 3 passed, 0 failed, 0 skipped, 0 blacklisted, 18ms
********* Finished testing of CompatTests *********
********* Start testing of GUIUtilTests *********
Config: Using QtTest library 5.15.8, Qt 5.15.8 (x86_64-little_endian-lp64 shared (dynamic) release build; by GCC 12.2.0), debian 12
PASS   : GUIUtilTests::initTestCase()
PASS   : GUIUtilTests::dummyAddressTest()
PASS   : GUIUtilTests::toCurrentEncodingTest()
PASS   : GUIUtilTests::cleanupTestCase()
Totals: 4 passed, 0 failed, 0 skipped, 0 blacklisted, 12ms
********* Finished testing of GUIUtilTests *********
********* Start testing of BitcoinAddressValidatorTests *********
Config: Using QtTest library 5.15.8, Qt 5.15.8 (x86_64-little_endian-lp64 shared (dynamic) release build; by GCC 12.2.0), debian 12
PASS   : BitcoinAddressValidatorTests::initTestCase()
PASS   : BitcoinAddressValidatorTests::inputTests()
PASS   : BitcoinAddressValidatorTests::cleanupTestCase()
Totals: 3 passed, 0 failed, 0 skipped, 0 blacklisted, 13ms
********* Finished testing of BitcoinAddressValidatorTests *********
********* Start testing of WalletTests *********
Config: Using QtTest library 5.15.8, Qt 5.15.8 (x86_64-little_endian-lp64 shared (dynamic) release build; by GCC 12.2.0), debian 12
PASS   : WalletTests::initTestCase()
QDEBUG : WalletTests::walletTests() TransactionTablePriv::refreshWallet
QWARN  : WalletTests::walletTests() This plugin does not support propagateSizeHints()
QDEBUG : WalletTests::walletTests() "NotifyTransactionChanged: d67c07197a75399adba8e929b7cb69cec71e5da2167ac34648b8ef2df3154a99 status= 0"
QDEBUG : WalletTests::walletTests() "NotifyTransactionChanged: 693325b1bfb743c6874514ad753e61979542afbceeb412619fca31f75f4cf64d status= 1"
QDEBUG : WalletTests::walletTests() "NotifyAddressBookChanged: ecregtest:qqqqqqqqqqqqqqqqqqqqqqqqqqqqqqqqqqcrl5mqkt  isMine=0 purpose=send status=0"
QDEBUG : WalletTests::walletTests() "TransactionTablePriv::updateWallet: d67c07197a75399adba8e929b7cb69cec71e5da2167ac34648b8ef2df3154a99 0"
QDEBUG : WalletTests::walletTests() "    inModel=0 Index=87-87 showTransaction=1 derivedStatus=0"
QDEBUG : WalletTests::walletTests() "TransactionTablePriv::updateWallet: 693325b1bfb743c6874514ad753e61979542afbceeb412619fca31f75f4cf64d 1"
QDEBUG : WalletTests::walletTests() "    inModel=1 Index=33-34 showTransaction=1 derivedStatus=1"
QWARN  : WalletTests::walletTests() This plugin does not support propagateSizeHints()
QDEBUG : WalletTests::walletTests() "NotifyTransactionChanged: 0a4e76457cdae025f9d93b60de35881ecdb3ceeee7cd17f9a2cf4047dac49c9a status= 0"
QDEBUG : WalletTests::walletTests() "NotifyTransactionChanged: 1251b5211793c4b3863e5c49ab8b0d78aca1dbfaa6836bf63f989b6d9aef78b6 status= 1"
QDEBUG : WalletTests::walletTests() "TransactionTablePriv::updateWallet: 0a4e76457cdae025f9d93b60de35881ecdb3ceeee7cd17f9a2cf4047dac49c9a 0"
QDEBUG : WalletTests::walletTests() "    inModel=0 Index=2-2 showTransaction=1 derivedStatus=0"
QDEBUG : WalletTests::walletTests() "TransactionTablePriv::updateWallet: 1251b5211793c4b3863e5c49ab8b0d78aca1dbfaa6836bf63f989b6d9aef78b6 1"
QDEBUG : WalletTests::walletTests() "    inModel=1 Index=7-8 showTransaction=1 derivedStatus=1"
QDEBUG : WalletTests::walletTests() "NotifyAddressBookChanged: ecregtest:qr6mapv7val9v2lmfadjven95u4pkml92s0rks5ta5 TEST_LABEL_1 isMine=1 purpose=receive status=0"
QWARN  : WalletTests::walletTests() This plugin does not support propagateSizeHints()
PASS   : WalletTests::walletTests()
PASS   : WalletTests::cleanupTestCase()
Totals: 3 passed, 0 failed, 0 skipped, 0 blacklisted, 1832ms
********* Finished testing of WalletTests *********
********* Start testing of AddressBookTests *********
Config: Using QtTest library 5.15.8, Qt 5.15.8 (x86_64-little_endian-lp64 shared (dynamic) release build; by GCC 12.2.0), debian 12
PASS   : AddressBookTests::initTestCase()
QDEBUG : AddressBookTests::addressBookTests() TransactionTablePriv::refreshWallet
QWARN  : AddressBookTests::addressBookTests() This plugin does not support propagateSizeHints()
QWARN  : AddressBookTests::addressBookTests() This plugin does not support propagateSizeHints()
QDEBUG : AddressBookTests::addressBookTests() "NotifyAddressBookChanged: ecregtest:qrhdtd63nm9vyxmfh0339k93jxuvrtqwpvp04uf3gy new isMine=0 purpose=send status=0"
PASS   : AddressBookTests::addressBookTests()
PASS   : AddressBookTests::cleanupTestCase()
Totals: 3 passed, 0 failed, 0 skipped, 0 blacklisted, 552ms
********* Finished testing of AddressBookTests *********
~BitcoinApplication : Stopping thread
~BitcoinApplication : Stopped thread
Segmentation fault (core dumped)
[527/529] Running bitcoin test suite
PASSED: bitcoin test suite
ninja: build stopped: cannot make progress due to previous errors.
Build build-debug failed with exit code 1
PiRK planned changes to this revision.Sat, Apr 19, 11:02
PiRK updated this revision to Diff 53561.Sat, Apr 19, 17:01

clang-tidy warnings

PiRK added a comment.Sat, Apr 19, 17:02

Let's see if the build-debug segfault is happening consistently

Harbormaster completed remote builds in B33019: Diff 53561.Sat, Apr 19, 17:09
teamcity added a comment.Sat, Apr 19, 17:09
Build Bitcoin ABC Diffs / Diff Testing (build-clang-tidy) failed.

Tail of the build log:

[217/521] Running utility command for check-seeder-message_writer_tests
[218/521] Running utility command for check-seeder-options_tests
[219/521] seeder: testing p2p_messaging_tests
[220/521] seeder: testing parse_name_tests
[221/521] Running utility command for check-seeder-p2p_messaging_tests
[222/521] seeder: testing write_name_tests
[223/521] Running utility command for check-seeder-parse_name_tests
[224/521] Running utility command for check-seeder-write_name_tests
[225/521] Running seeder test suite
PASSED: seeder test suite
[226/521] Building CXX object src/test/CMakeFiles/test_bitcoin.dir/__/wallet/test/walletdb_tests.cpp.o
[227/521] pow: testing aserti32d_tests
[228/521] Running utility command for check-pow-aserti32d_tests
[229/521] Running pow test suite
PASSED: pow test suite
[230/521] Building CXX object src/test/CMakeFiles/test_bitcoin.dir/__/wallet/test/psbt_wallet_tests.cpp.o
[231/521] Building CXX object src/test/CMakeFiles/test_bitcoin.dir/script_tests.cpp.o
[232/521] Building CXX object src/test/CMakeFiles/test_bitcoin.dir/__/wallet/test/coinselector_tests.cpp.o
[233/521] Building CXX object src/qt/test/CMakeFiles/test_bitcoin-qt.dir/compattests.cpp.o
[234/521] Building CXX object src/qt/test/CMakeFiles/test_bitcoin-qt.dir/util.cpp.o
[235/521] Building CXX object src/qt/test/CMakeFiles/test_bitcoin-qt.dir/bitcoinaddressvalidatortests.cpp.o
[236/521] Building CXX object src/qt/test/CMakeFiles/test_bitcoin-qt.dir/guiutiltests.cpp.o
[237/521] Building CXX object src/qt/test/CMakeFiles/test_bitcoin-qt.dir/optiontests.cpp.o
[238/521] Building CXX object src/qt/test/CMakeFiles/test_bitcoin-qt.dir/test_bitcoin-qt_autogen/mocs_compilation.cpp.o
[239/521] Building CXX object src/qt/test/CMakeFiles/test_bitcoin-qt.dir/addressbooktests.cpp.o
FAILED: src/qt/test/CMakeFiles/test_bitcoin-qt.dir/addressbooktests.cpp.o 
/usr/bin/cmake -E __run_co_compile --launcher=/usr/bin/ccache --tidy="/usr/bin/clang-tidy-16;-warnings-as-errors=*;--extra-arg-before=--driver-mode=g++" --source=/work/src/qt/test/addressbooktests.cpp -- /usr/bin/clang++ -DBOOST_ALL_NO_LIB -DBOOST_NO_CXX98_FUNCTION_BASE -DBUILD_BITCOIN_INTERNAL -DENABLE_AVX2 -DENABLE_SHANI -DENABLE_SSE41 -DHAVE_BUILD_INFO -DHAVE_CONFIG_H -DHAVE_CONSENSUS_LIB -DLEVELDB_ATOMIC_PRESENT -DLEVELDB_PLATFORM_POSIX -DOS_LINUX -DQT_CORE_LIB -DQT_DBUS_LIB -DQT_GUI_LIB -DQT_NETWORK_LIB -DQT_NO_DEBUG -DQT_TESTCASE_BUILDDIR=\"/work/abc-ci-builds/build-clang-tidy\" -DQT_TESTLIB_LIB -DQT_WIDGETS_LIB -I/work/abc-ci-builds/build-clang-tidy/src/qt/test/test_bitcoin-qt_autogen/include -I/work/src/. -I/work/abc-ci-builds/build-clang-tidy/src -I/work/src/univalue/include -I/work/abc-ci-builds/build-clang-tidy/src/crypto/.. -I/work/src/secp256k1/include -I/work/src/leveldb/include -I/work/abc-ci-builds/build-clang-tidy/src/qt -isystem /usr/include/jemalloc -isystem /usr/include/miniupnpc -isystem /usr/include/x86_64-linux-gnu/qt5 -isystem /usr/include/x86_64-linux-gnu/qt5/QtWidgets -isystem /usr/include/x86_64-linux-gnu/qt5/QtGui -isystem /usr/include/x86_64-linux-gnu/qt5/QtCore -isystem /usr/lib/x86_64-linux-gnu/qt5/mkspecs/linux-g++ -isystem /usr/include/x86_64-linux-gnu/qt5/QtNetwork -isystem /usr/include/x86_64-linux-gnu/qt5/QtDBus -isystem /usr/include/x86_64-linux-gnu/qt5/QtTest -g -O2 -fPIE -fvisibility=hidden -fstack-protector-all -Wstack-protector -fcf-protection=full -fstack-clash-protection -U_FORTIFY_SOURCE -D_FORTIFY_SOURCE=2 -Wall -Wextra -Wformat -Wgnu -Wvla -Wcast-align -Wunused-parameter -Wmissing-braces -Wthread-safety -Wrange-loop-analysis -Wredundant-decls -Wunreachable-code-loop-increment -Wsign-compare -Wconditional-uninitialized -Wdocumentation -Wformat-security -Wredundant-move -Woverloaded-virtual -Wshadow -Wshadow-field -Wno-unused-parameter -Wno-implicit-fallthrough -Wno-psabi -fPIC -std=gnu++17 -MD -MT src/qt/test/CMakeFiles/test_bitcoin-qt.dir/addressbooktests.cpp.o -MF src/qt/test/CMakeFiles/test_bitcoin-qt.dir/addressbooktests.cpp.o.d -o src/qt/test/CMakeFiles/test_bitcoin-qt.dir/addressbooktests.cpp.o -c /work/src/qt/test/addressbooktests.cpp
/work/src/qt/test/addressbooktests.cpp:123:35: error: argument name 'load_on_startup' in comment does not match parameter name 'load_on_start' [bugprone-argument-comment,-warnings-as-errors]
    RemoveWallet(context, wallet, /* load_on_startup= */ std::nullopt);
                                  ^~~~~~~~~~~~~~~~~~~~~~
                                  /* load_on_start= */
/work/src/./wallet/wallet.h:68:39: note: 'load_on_start' declared here
                  std::optional<bool> load_on_start);
                                      ^
3150 warnings generated.
Suppressed 3149 warnings (3149 in non-user code).
Use -header-filter=.* to display errors from all non-system headers. Use -system-headers to display errors from system headers as well.
1 warning treated as error
[240/521] Building CXX object src/qt/test/CMakeFiles/test_bitcoin-qt.dir/wallettests.cpp.o
FAILED: src/qt/test/CMakeFiles/test_bitcoin-qt.dir/wallettests.cpp.o 
/usr/bin/cmake -E __run_co_compile --launcher=/usr/bin/ccache --tidy="/usr/bin/clang-tidy-16;-warnings-as-errors=*;--extra-arg-before=--driver-mode=g++" --source=/work/src/qt/test/wallettests.cpp -- /usr/bin/clang++ -DBOOST_ALL_NO_LIB -DBOOST_NO_CXX98_FUNCTION_BASE -DBUILD_BITCOIN_INTERNAL -DENABLE_AVX2 -DENABLE_SHANI -DENABLE_SSE41 -DHAVE_BUILD_INFO -DHAVE_CONFIG_H -DHAVE_CONSENSUS_LIB -DLEVELDB_ATOMIC_PRESENT -DLEVELDB_PLATFORM_POSIX -DOS_LINUX -DQT_CORE_LIB -DQT_DBUS_LIB -DQT_GUI_LIB -DQT_NETWORK_LIB -DQT_NO_DEBUG -DQT_TESTCASE_BUILDDIR=\"/work/abc-ci-builds/build-clang-tidy\" -DQT_TESTLIB_LIB -DQT_WIDGETS_LIB -I/work/abc-ci-builds/build-clang-tidy/src/qt/test/test_bitcoin-qt_autogen/include -I/work/src/. -I/work/abc-ci-builds/build-clang-tidy/src -I/work/src/univalue/include -I/work/abc-ci-builds/build-clang-tidy/src/crypto/.. -I/work/src/secp256k1/include -I/work/src/leveldb/include -I/work/abc-ci-builds/build-clang-tidy/src/qt -isystem /usr/include/jemalloc -isystem /usr/include/miniupnpc -isystem /usr/include/x86_64-linux-gnu/qt5 -isystem /usr/include/x86_64-linux-gnu/qt5/QtWidgets -isystem /usr/include/x86_64-linux-gnu/qt5/QtGui -isystem /usr/include/x86_64-linux-gnu/qt5/QtCore -isystem /usr/lib/x86_64-linux-gnu/qt5/mkspecs/linux-g++ -isystem /usr/include/x86_64-linux-gnu/qt5/QtNetwork -isystem /usr/include/x86_64-linux-gnu/qt5/QtDBus -isystem /usr/include/x86_64-linux-gnu/qt5/QtTest -g -O2 -fPIE -fvisibility=hidden -fstack-protector-all -Wstack-protector -fcf-protection=full -fstack-clash-protection -U_FORTIFY_SOURCE -D_FORTIFY_SOURCE=2 -Wall -Wextra -Wformat -Wgnu -Wvla -Wcast-align -Wunused-parameter -Wmissing-braces -Wthread-safety -Wrange-loop-analysis -Wredundant-decls -Wunreachable-code-loop-increment -Wsign-compare -Wconditional-uninitialized -Wdocumentation -Wformat-security -Wredundant-move -Woverloaded-virtual -Wshadow -Wshadow-field -Wno-unused-parameter -Wno-implicit-fallthrough -Wno-psabi -fPIC -std=gnu++17 -MD -MT src/qt/test/CMakeFiles/test_bitcoin-qt.dir/wallettests.cpp.o -MF src/qt/test/CMakeFiles/test_bitcoin-qt.dir/wallettests.cpp.o.d -o src/qt/test/CMakeFiles/test_bitcoin-qt.dir/wallettests.cpp.o -c /work/src/qt/test/wallettests.cpp
/work/src/qt/test/wallettests.cpp:160:35: error: argument name 'load_on_startup' in comment does not match parameter name 'load_on_start' [bugprone-argument-comment,-warnings-as-errors]
    RemoveWallet(context, wallet, /* load_on_startup= */ std::nullopt);
                                  ^~~~~~~~~~~~~~~~~~~~~~
                                  /* load_on_start= */
/work/src/./wallet/wallet.h:68:39: note: 'load_on_start' declared here
                  std::optional<bool> load_on_start);
                                      ^
3159 warnings generated.
Suppressed 3158 warnings (3158 in non-user code).
Use -header-filter=.* to display errors from all non-system headers. Use -system-headers to display errors from system headers as well.
1 warning treated as error
[241/521] Building CXX object src/qt/test/CMakeFiles/test_bitcoin-qt.dir/uritests.cpp.o
[242/521] Building CXX object src/qt/test/CMakeFiles/test_bitcoin-qt.dir/apptests.cpp.o
[243/521] Building CXX object src/qt/test/CMakeFiles/test_bitcoin-qt.dir/test_main.cpp.o
[244/521] Building CXX object src/qt/test/CMakeFiles/test_bitcoin-qt.dir/rpcnestedtests.cpp.o
[245/521] Building CXX object src/qt/test/CMakeFiles/test_bitcoin-qt.dir/__/__/wallet/test/wallet_test_fixture.cpp.o
[246/521] Building CXX object src/qt/test/CMakeFiles/test_bitcoin-qt.dir/paymentservertests.cpp.o
ninja: build stopped: cannot make progress due to previous errors.
Build build-clang-tidy failed with exit code 1
teamcity added a comment.Sat, Apr 19, 17:17
Build Bitcoin ABC Diffs / Diff Testing (build-debug) failed.

Tail of the build log:

Totals: 3 passed, 0 failed, 0 skipped, 0 blacklisted, 0ms
********* Finished testing of CompatTests *********
********* Start testing of GUIUtilTests *********
Config: Using QtTest library 5.15.8, Qt 5.15.8 (x86_64-little_endian-lp64 shared (dynamic) release build; by GCC 12.2.0), debian 12
PASS   : GUIUtilTests::initTestCase()
PASS   : GUIUtilTests::dummyAddressTest()
PASS   : GUIUtilTests::toCurrentEncodingTest()
PASS   : GUIUtilTests::cleanupTestCase()
Totals: 4 passed, 0 failed, 0 skipped, 0 blacklisted, 1ms
********* Finished testing of GUIUtilTests *********
********* Start testing of BitcoinAddressValidatorTests *********
Config: Using QtTest library 5.15.8, Qt 5.15.8 (x86_64-little_endian-lp64 shared (dynamic) release build; by GCC 12.2.0), debian 12
PASS   : BitcoinAddressValidatorTests::initTestCase()
PASS   : BitcoinAddressValidatorTests::inputTests()
PASS   : BitcoinAddressValidatorTests::cleanupTestCase()
Totals: 3 passed, 0 failed, 0 skipped, 0 blacklisted, 2ms
********* Finished testing of BitcoinAddressValidatorTests *********
********* Start testing of WalletTests *********
Config: Using QtTest library 5.15.8, Qt 5.15.8 (x86_64-little_endian-lp64 shared (dynamic) release build; by GCC 12.2.0), debian 12
PASS   : WalletTests::initTestCase()
QDEBUG : WalletTests::walletTests() TransactionTablePriv::refreshWallet
QWARN  : WalletTests::walletTests() This plugin does not support propagateSizeHints()
QDEBUG : WalletTests::walletTests() "NotifyTransactionChanged: 94c4fa8756f9dd50e2428560321cfe82a9a59fe2993038ae998eade8519edefd status= 0"
QDEBUG : WalletTests::walletTests() "NotifyTransactionChanged: 962bc10572420d1f1601186a5e58b62441edb765cdc20e2b098aef58184201c3 status= 1"
QDEBUG : WalletTests::walletTests() "NotifyAddressBookChanged: ecregtest:qqqqqqqqqqqqqqqqqqqqqqqqqqqqqqqqqqcrl5mqkt  isMine=0 purpose=send status=0"
QDEBUG : WalletTests::walletTests() "TransactionTablePriv::updateWallet: 94c4fa8756f9dd50e2428560321cfe82a9a59fe2993038ae998eade8519edefd 0"
QDEBUG : WalletTests::walletTests() "    inModel=0 Index=59-59 showTransaction=1 derivedStatus=0"
QDEBUG : WalletTests::walletTests() "TransactionTablePriv::updateWallet: 962bc10572420d1f1601186a5e58b62441edb765cdc20e2b098aef58184201c3 1"
QDEBUG : WalletTests::walletTests() "    inModel=1 Index=60-61 showTransaction=1 derivedStatus=1"
QWARN  : WalletTests::walletTests() This plugin does not support propagateSizeHints()
QDEBUG : WalletTests::walletTests() "NotifyTransactionChanged: 42f8514e3c589cb1050b2b6374667a58159bb1fef8c3eb2bcfe8c82aae2e9118 status= 0"
QDEBUG : WalletTests::walletTests() "NotifyTransactionChanged: 1251b5211793c4b3863e5c49ab8b0d78aca1dbfaa6836bf63f989b6d9aef78b6 status= 1"
QDEBUG : WalletTests::walletTests() "TransactionTablePriv::updateWallet: 42f8514e3c589cb1050b2b6374667a58159bb1fef8c3eb2bcfe8c82aae2e9118 0"
QDEBUG : WalletTests::walletTests() "    inModel=0 Index=22-22 showTransaction=1 derivedStatus=0"
QDEBUG : WalletTests::walletTests() "TransactionTablePriv::updateWallet: 1251b5211793c4b3863e5c49ab8b0d78aca1dbfaa6836bf63f989b6d9aef78b6 1"
QDEBUG : WalletTests::walletTests() "    inModel=1 Index=6-7 showTransaction=1 derivedStatus=1"
QDEBUG : WalletTests::walletTests() "NotifyAddressBookChanged: ecregtest:qzf75afgy05gcncezt6cajeuy43fg99kkvm2xqsa20 TEST_LABEL_1 isMine=1 purpose=receive status=0"
QWARN  : WalletTests::walletTests() This plugin does not support propagateSizeHints()
PASS   : WalletTests::walletTests()
PASS   : WalletTests::cleanupTestCase()
Totals: 3 passed, 0 failed, 0 skipped, 0 blacklisted, 1238ms
********* Finished testing of WalletTests *********
********* Start testing of AddressBookTests *********
Config: Using QtTest library 5.15.8, Qt 5.15.8 (x86_64-little_endian-lp64 shared (dynamic) release build; by GCC 12.2.0), debian 12
PASS   : AddressBookTests::initTestCase()
QDEBUG : AddressBookTests::addressBookTests() TransactionTablePriv::refreshWallet
QWARN  : AddressBookTests::addressBookTests() This plugin does not support propagateSizeHints()
QWARN  : AddressBookTests::addressBookTests() This plugin does not support propagateSizeHints()
QDEBUG : AddressBookTests::addressBookTests() "NotifyAddressBookChanged: ecregtest:qpcs70rrz93qxk8wsvxm9kktfcfzq9ceuuadnahrf9 new isMine=0 purpose=send status=0"
PASS   : AddressBookTests::addressBookTests()
PASS   : AddressBookTests::cleanupTestCase()
Totals: 3 passed, 0 failed, 0 skipped, 0 blacklisted, 382ms
********* Finished testing of AddressBookTests *********
~BitcoinApplication : Stopping thread
~BitcoinApplication : Stopped thread
Segmentation fault (core dumped)
[527/529] Running bitcoin test suite
PASSED: bitcoin test suite
ninja: build stopped: cannot make progress due to previous errors.
Build build-debug failed with exit code 1
PiRK updated this revision to Diff 53562.Sat, Apr 19, 17:21

more clang-tidy issues (argument names)

Harbormaster completed remote builds in B33020: Diff 53562.Sat, Apr 19, 17:37
teamcity added a comment.Sat, Apr 19, 17:37
Build Bitcoin ABC Diffs / Diff Testing (build-debug) failed.

Tail of the build log:

********* Start testing of GUIUtilTests *********
Config: Using QtTest library 5.15.8, Qt 5.15.8 (x86_64-little_endian-lp64 shared (dynamic) release build; by GCC 12.2.0), debian 12
PASS   : GUIUtilTests::initTestCase()
PASS   : GUIUtilTests::dummyAddressTest()
PASS   : GUIUtilTests::toCurrentEncodingTest()
PASS   : GUIUtilTests::cleanupTestCase()
Totals: 4 passed, 0 failed, 0 skipped, 0 blacklisted, 1ms
********* Finished testing of GUIUtilTests *********
********* Start testing of BitcoinAddressValidatorTests *********
Config: Using QtTest library 5.15.8, Qt 5.15.8 (x86_64-little_endian-lp64 shared (dynamic) release build; by GCC 12.2.0), debian 12
PASS   : BitcoinAddressValidatorTests::initTestCase()
PASS   : BitcoinAddressValidatorTests::inputTests()
PASS   : BitcoinAddressValidatorTests::cleanupTestCase()
Totals: 3 passed, 0 failed, 0 skipped, 0 blacklisted, 0ms
********* Finished testing of BitcoinAddressValidatorTests *********
********* Start testing of WalletTests *********
Config: Using QtTest library 5.15.8, Qt 5.15.8 (x86_64-little_endian-lp64 shared (dynamic) release build; by GCC 12.2.0), debian 12
PASS   : WalletTests::initTestCase()
QDEBUG : WalletTests::walletTests() TransactionTablePriv::refreshWallet
QWARN  : WalletTests::walletTests() This plugin does not support propagateSizeHints()
QDEBUG : WalletTests::walletTests() "NotifyTransactionChanged: 98999eb55c950b4fe32c6d5abc10824618121f3070debeac86834f3887893d0d status= 0"
QDEBUG : WalletTests::walletTests() "NotifyTransactionChanged: 962bc10572420d1f1601186a5e58b62441edb765cdc20e2b098aef58184201c3 status= 1"
QDEBUG : WalletTests::walletTests() "NotifyAddressBookChanged: ecregtest:qqqqqqqqqqqqqqqqqqqqqqqqqqqqqqqqqqcrl5mqkt  isMine=0 purpose=send status=0"
QDEBUG : WalletTests::walletTests() "TransactionTablePriv::updateWallet: 98999eb55c950b4fe32c6d5abc10824618121f3070debeac86834f3887893d0d 0"
QDEBUG : WalletTests::walletTests() "    inModel=0 Index=60-60 showTransaction=1 derivedStatus=0"
QDEBUG : WalletTests::walletTests() "TransactionTablePriv::updateWallet: 962bc10572420d1f1601186a5e58b62441edb765cdc20e2b098aef58184201c3 1"
QDEBUG : WalletTests::walletTests() "    inModel=1 Index=59-60 showTransaction=1 derivedStatus=1"
QWARN  : WalletTests::walletTests() This plugin does not support propagateSizeHints()
QDEBUG : WalletTests::walletTests() "NotifyTransactionChanged: 0ce1eb343bad5168f3eb1f873ea4dcc0885b632d06716f6efd24ed04f3cbc625 status= 0"
QDEBUG : WalletTests::walletTests() "NotifyTransactionChanged: 8314b95e704b6107a0f3b9bdaa305336c33bb921f50bcfae2d059b33d0e1e008 status= 1"
QDEBUG : WalletTests::walletTests() "TransactionTablePriv::updateWallet: 0ce1eb343bad5168f3eb1f873ea4dcc0885b632d06716f6efd24ed04f3cbc625 0"
QDEBUG : WalletTests::walletTests() "    inModel=0 Index=2-2 showTransaction=1 derivedStatus=0"
QDEBUG : WalletTests::walletTests() "TransactionTablePriv::updateWallet: 8314b95e704b6107a0f3b9bdaa305336c33bb921f50bcfae2d059b33d0e1e008 1"
QDEBUG : WalletTests::walletTests() "    inModel=1 Index=48-49 showTransaction=1 derivedStatus=1"
QDEBUG : WalletTests::walletTests() "NotifyAddressBookChanged: ecregtest:qp234e06k4tx5w9h8fapfrgz9x4vgw8kguv6xfs5ga TEST_LABEL_1 isMine=1 purpose=receive status=0"
QWARN  : WalletTests::walletTests() This plugin does not support propagateSizeHints()
PASS   : WalletTests::walletTests()
PASS   : WalletTests::cleanupTestCase()
Totals: 3 passed, 0 failed, 0 skipped, 0 blacklisted, 1516ms
********* Finished testing of WalletTests *********
********* Start testing of AddressBookTests *********
Config: Using QtTest library 5.15.8, Qt 5.15.8 (x86_64-little_endian-lp64 shared (dynamic) release build; by GCC 12.2.0), debian 12
PASS   : AddressBookTests::initTestCase()
QDEBUG : AddressBookTests::addressBookTests() TransactionTablePriv::refreshWallet
QWARN  : AddressBookTests::addressBookTests() This plugin does not support propagateSizeHints()
QWARN  : AddressBookTests::addressBookTests() This plugin does not support propagateSizeHints()
QDEBUG : AddressBookTests::addressBookTests() "NotifyAddressBookChanged: ecregtest:qqqhclw4uls5slmqtfasrfzenzhu7s0jnu4s6nsyvw new isMine=0 purpose=send status=0"
PASS   : AddressBookTests::addressBookTests()
PASS   : AddressBookTests::cleanupTestCase()
Totals: 3 passed, 0 failed, 0 skipped, 0 blacklisted, 802ms
********* Finished testing of AddressBookTests *********
~BitcoinApplication : Stopping thread
~BitcoinApplication : Stopped thread
Segmentation fault (core dumped)
[522/529] Running pow test suite
PASSED: pow test suite
[527/529] Running bitcoin test suite
PASSED: bitcoin test suite
ninja: build stopped: cannot make progress due to previous errors.
Build build-debug failed with exit code 1
PiRK added a comment.Sat, Apr 19, 19:31

Maybe core#22992

PiRK updated this revision to Diff 53565.Sat, Apr 19, 21:36
PiRK edited the summary of this revision. (Show Details)
PiRK edited the test plan for this revision. (Show Details)

squash with core#22992

PiRK edited the summary of this revision. (Show Details)Sat, Apr 19, 21:36
Harbormaster completed remote builds in B33022: Diff 53565.Sat, Apr 19, 21:48
teamcity added a comment.Sat, Apr 19, 21:48
Build Bitcoin ABC Diffs / Diff Testing (build-debug) failed.

Tail of the build log:

********* Start testing of GUIUtilTests *********
Config: Using QtTest library 5.15.8, Qt 5.15.8 (x86_64-little_endian-lp64 shared (dynamic) release build; by GCC 12.2.0), debian 12
PASS   : GUIUtilTests::initTestCase()
PASS   : GUIUtilTests::dummyAddressTest()
PASS   : GUIUtilTests::toCurrentEncodingTest()
PASS   : GUIUtilTests::cleanupTestCase()
Totals: 4 passed, 0 failed, 0 skipped, 0 blacklisted, 1ms
********* Finished testing of GUIUtilTests *********
********* Start testing of BitcoinAddressValidatorTests *********
Config: Using QtTest library 5.15.8, Qt 5.15.8 (x86_64-little_endian-lp64 shared (dynamic) release build; by GCC 12.2.0), debian 12
PASS   : BitcoinAddressValidatorTests::initTestCase()
PASS   : BitcoinAddressValidatorTests::inputTests()
PASS   : BitcoinAddressValidatorTests::cleanupTestCase()
Totals: 3 passed, 0 failed, 0 skipped, 0 blacklisted, 0ms
********* Finished testing of BitcoinAddressValidatorTests *********
********* Start testing of WalletTests *********
Config: Using QtTest library 5.15.8, Qt 5.15.8 (x86_64-little_endian-lp64 shared (dynamic) release build; by GCC 12.2.0), debian 12
PASS   : WalletTests::initTestCase()
QDEBUG : WalletTests::walletTests() TransactionTablePriv::refreshWallet
QWARN  : WalletTests::walletTests() This plugin does not support propagateSizeHints()
QDEBUG : WalletTests::walletTests() "NotifyTransactionChanged: 169f21a855b5d238a76044f295f9af0372505f2bde577a4291089eb2610c7299 status= 0"
QDEBUG : WalletTests::walletTests() "NotifyTransactionChanged: 693325b1bfb743c6874514ad753e61979542afbceeb412619fca31f75f4cf64d status= 1"
QDEBUG : WalletTests::walletTests() "NotifyAddressBookChanged: ecregtest:qqqqqqqqqqqqqqqqqqqqqqqqqqqqqqqqqqcrl5mqkt  isMine=0 purpose=send status=0"
QDEBUG : WalletTests::walletTests() "TransactionTablePriv::updateWallet: 169f21a855b5d238a76044f295f9af0372505f2bde577a4291089eb2610c7299 0"
QDEBUG : WalletTests::walletTests() "    inModel=0 Index=8-8 showTransaction=1 derivedStatus=0"
QDEBUG : WalletTests::walletTests() "TransactionTablePriv::updateWallet: 693325b1bfb743c6874514ad753e61979542afbceeb412619fca31f75f4cf64d 1"
QDEBUG : WalletTests::walletTests() "    inModel=1 Index=34-35 showTransaction=1 derivedStatus=1"
QWARN  : WalletTests::walletTests() This plugin does not support propagateSizeHints()
QDEBUG : WalletTests::walletTests() "NotifyTransactionChanged: 985ea13bd077039ffcc1ccf8415132f6d9f8d4277e1e1fe553201090eda06766 status= 0"
QDEBUG : WalletTests::walletTests() "NotifyTransactionChanged: 962bc10572420d1f1601186a5e58b62441edb765cdc20e2b098aef58184201c3 status= 1"
QDEBUG : WalletTests::walletTests() "TransactionTablePriv::updateWallet: 985ea13bd077039ffcc1ccf8415132f6d9f8d4277e1e1fe553201090eda06766 0"
QDEBUG : WalletTests::walletTests() "    inModel=0 Index=61-61 showTransaction=1 derivedStatus=0"
QDEBUG : WalletTests::walletTests() "TransactionTablePriv::updateWallet: 962bc10572420d1f1601186a5e58b62441edb765cdc20e2b098aef58184201c3 1"
QDEBUG : WalletTests::walletTests() "    inModel=1 Index=60-61 showTransaction=1 derivedStatus=1"
QDEBUG : WalletTests::walletTests() "NotifyAddressBookChanged: ecregtest:qp7x720jlcc2u3y2z5nth3z4t726hk06mcgu097836 TEST_LABEL_1 isMine=1 purpose=receive status=0"
QWARN  : WalletTests::walletTests() This plugin does not support propagateSizeHints()
PASS   : WalletTests::walletTests()
PASS   : WalletTests::cleanupTestCase()
Totals: 3 passed, 0 failed, 0 skipped, 0 blacklisted, 1593ms
********* Finished testing of WalletTests *********
********* Start testing of AddressBookTests *********
Config: Using QtTest library 5.15.8, Qt 5.15.8 (x86_64-little_endian-lp64 shared (dynamic) release build; by GCC 12.2.0), debian 12
PASS   : AddressBookTests::initTestCase()
QDEBUG : AddressBookTests::addressBookTests() TransactionTablePriv::refreshWallet
QWARN  : AddressBookTests::addressBookTests() This plugin does not support propagateSizeHints()
QWARN  : AddressBookTests::addressBookTests() This plugin does not support propagateSizeHints()
QDEBUG : AddressBookTests::addressBookTests() "NotifyAddressBookChanged: ecregtest:qz48yh9ux83pcryha2r9ksfmzael4egrfqqz5fuwdn new isMine=0 purpose=send status=0"
PASS   : AddressBookTests::addressBookTests()
PASS   : AddressBookTests::cleanupTestCase()
Totals: 3 passed, 0 failed, 0 skipped, 0 blacklisted, 398ms
********* Finished testing of AddressBookTests *********
~BitcoinApplication : Stopping thread
~BitcoinApplication : Stopped thread
Segmentation fault (core dumped)
[522/529] Running secp256k1 test suite
PASSED: secp256k1 test suite
[527/529] Running bitcoin test suite
PASSED: bitcoin test suite
ninja: build stopped: cannot make progress due to previous errors.
Build build-debug failed with exit code 1
PiRK planned changes to this revision.Sun, Apr 20, 05:47
Fabien added a child revision: D17958: wallet: Move restorewallet() logic to the wallet section.Mon, Apr 21, 12:59
PiRK added a comment.Mon, Apr 21, 13:02

@bot build-tsan

teamcity updated a token.Mon, Apr 21, 13:02
Fabien added a subscriber: Fabien.Mon, Apr 21, 18:23

You can now rebase, the issue should be fixed

PiRK updated this revision to Diff 53583.Mon, Apr 21, 18:36

rebase on D17960

Fabien accepted this revision.Mon, Apr 21, 18:44
This revision is now accepted and ready to land.Mon, Apr 21, 18:44
Harbormaster completed remote builds in B33034: Diff 53583.Mon, Apr 21, 18:53
Closed by commit rABCb59ed33b3ac1: refactor: remove ::vpwallets and related global variables (authored by Russell Yanofsky <russ@yanofsky.org>, committed by PiRK). · Explain WhyMon, Apr 21, 21:07
This revision was automatically updated to reflect the committed changes.
PiRK added a commit: rABCb59ed33b3ac1: refactor: remove ::vpwallets and related global variables.

Revision Contents
Changeset List

PathSize
src/
interfaces/
6 lines
qt/
test/
9 lines
9 lines
wallet/
16 lines
42 lines
15 lines
39 lines
rpc/
11 lines
10 lines
test/
49 lines
29 lines
97 lines
3 lines
8 lines

Diff 53561

View Options

src/interfaces/wallet.h

Loading...
View Options

src/qt/test/addressbooktests.cpp

Loading...
View Options

src/qt/test/wallettests.cpp

Loading...
View Options

src/wallet/context.h

Loading...
View Options

src/wallet/interfaces.cpp

Loading...
View Options

src/wallet/load.h

Loading...
View Options

src/wallet/load.cpp

Loading...
View Options

src/wallet/rpc/util.cpp

Loading...
View Options

src/wallet/rpcwallet.cpp

Loading...
View Options

src/wallet/test/wallet_tests.cpp

Loading...
View Options

src/wallet/wallet.h

Loading...
View Options

src/wallet/wallet.cpp

Loading...
View Options

src/wallet/walletdb.h

Loading...
View Options

src/wallet/walletdb.cpp

Loading...