Move global wallet variables to WalletContext struct
This is a backport of [[https://github.com/bitcoin/bitcoin/pull/19101 | core#19101]] and [[https://github.com/bitcoin/bitcoin/pull/22992 | core#22992]]
Details
Details
- Reviewers
- None
- Group Reviewers
Restricted Project
ninja all check-all
Diff Detail
Diff Detail
- Repository
- rABC Bitcoin ABC
- Branch
- arcpatch-D17952
- Lint
Lint Passed - Unit
No Test Coverage - Build Status
Buildable 33029 Build 65542: Build Diff build-diff · build-debug · build-clang-tidy · build-clang · build-without-wallet · lint-circular-dependencies Build 65541: arc lint + arc unit
Event Timeline
Comment Actions
Build Bitcoin ABC Diffs / Diff Testing (build-debug) failed.
Tail of the build log:
Config: Using QtTest library 5.15.8, Qt 5.15.8 (x86_64-little_endian-lp64 shared (dynamic) release build; by GCC 12.2.0), debian 12 PASS : WalletTests::initTestCase() QDEBUG : WalletTests::walletTests() TransactionTablePriv::refreshWallet QWARN : WalletTests::walletTests() This plugin does not support propagateSizeHints() QDEBUG : WalletTests::walletTests() "NotifyTransactionChanged: b97d168b7178957020445dd712256fce8ceb6406d87b34ec5aa961cacd5cc50a status= 0" QDEBUG : WalletTests::walletTests() "NotifyTransactionChanged: 693325b1bfb743c6874514ad753e61979542afbceeb412619fca31f75f4cf64d status= 1" QDEBUG : WalletTests::walletTests() "NotifyAddressBookChanged: ecregtest:qqqqqqqqqqqqqqqqqqqqqqqqqqqqqqqqqqcrl5mqkt isMine=0 purpose=send status=0" QDEBUG : WalletTests::walletTests() "TransactionTablePriv::updateWallet: b97d168b7178957020445dd712256fce8ceb6406d87b34ec5aa961cacd5cc50a 0" QDEBUG : WalletTests::walletTests() " inModel=0 Index=70-70 showTransaction=1 derivedStatus=0" QDEBUG : WalletTests::walletTests() "TransactionTablePriv::updateWallet: 693325b1bfb743c6874514ad753e61979542afbceeb412619fca31f75f4cf64d 1" QDEBUG : WalletTests::walletTests() " inModel=1 Index=33-34 showTransaction=1 derivedStatus=1" QWARN : WalletTests::walletTests() This plugin does not support propagateSizeHints() QDEBUG : WalletTests::walletTests() "NotifyTransactionChanged: ddc9a2378e6caf8566e69d559f5ca94f9a5b6c4d6fa2aa1597dc7ffcaef3e37c status= 0" QDEBUG : WalletTests::walletTests() "NotifyTransactionChanged: 8314b95e704b6107a0f3b9bdaa305336c33bb921f50bcfae2d059b33d0e1e008 status= 1" QDEBUG : WalletTests::walletTests() "TransactionTablePriv::updateWallet: ddc9a2378e6caf8566e69d559f5ca94f9a5b6c4d6fa2aa1597dc7ffcaef3e37c 0" QDEBUG : WalletTests::walletTests() " inModel=0 Index=94-94 showTransaction=1 derivedStatus=0" QDEBUG : WalletTests::walletTests() "TransactionTablePriv::updateWallet: 8314b95e704b6107a0f3b9bdaa305336c33bb921f50bcfae2d059b33d0e1e008 1" QDEBUG : WalletTests::walletTests() " inModel=1 Index=47-48 showTransaction=1 derivedStatus=1" QDEBUG : WalletTests::walletTests() "NotifyAddressBookChanged: ecregtest:qrxpwu6hyzx4cyex96p22p385459rcu9qcghf53ctr TEST_LABEL_1 isMine=1 purpose=receive status=0" QWARN : WalletTests::walletTests() This plugin does not support propagateSizeHints() PASS : WalletTests::walletTests() PASS : WalletTests::cleanupTestCase() Totals: 3 passed, 0 failed, 0 skipped, 0 blacklisted, 1080ms ********* Finished testing of WalletTests ********* ********* Start testing of AddressBookTests ********* Config: Using QtTest library 5.15.8, Qt 5.15.8 (x86_64-little_endian-lp64 shared (dynamic) release build; by GCC 12.2.0), debian 12 PASS : AddressBookTests::initTestCase() QDEBUG : AddressBookTests::addressBookTests() TransactionTablePriv::refreshWallet QWARN : AddressBookTests::addressBookTests() This plugin does not support propagateSizeHints() QWARN : AddressBookTests::addressBookTests() This plugin does not support propagateSizeHints() QDEBUG : AddressBookTests::addressBookTests() "NotifyAddressBookChanged: ecregtest:qz2x8f52hp8c6r97xwr580qdkh7qax5pgspmv40n36 new isMine=0 purpose=send status=0" PASS : AddressBookTests::addressBookTests() PASS : AddressBookTests::cleanupTestCase() Totals: 3 passed, 0 failed, 0 skipped, 0 blacklisted, 322ms ********* Finished testing of AddressBookTests ********* ~BitcoinApplication : Stopping thread ~BitcoinApplication : Stopped thread Segmentation fault (core dumped) [511/528] bitcoin: testing wallet_tests [512/528] Running utility command for check-bitcoin-wallet_tests [513/528] bitcoin: testing validation_block_tests [514/528] Running utility command for check-bitcoin-validation_block_tests [515/528] avalanche: testing voterecord_tests [516/528] Running utility command for check-avalanche-voterecord_tests [517/528] Running avalanche test suite PASSED: avalanche test suite [518/528] bitcoin: testing checkqueue_tests [519/528] Running utility command for check-bitcoin-checkqueue_tests [520/528] pow: testing aserti32d_tests [521/528] Running utility command for check-pow-aserti32d_tests [522/528] Running pow test suite PASSED: pow test suite [523/528] bitcoin: testing coinselector_tests [524/528] Running utility command for check-bitcoin-coinselector_tests [525/528] bitcoin: testing coins_tests [526/528] Running utility command for check-bitcoin-coins_tests [527/528] Running bitcoin test suite PASSED: bitcoin test suite ninja: build stopped: cannot make progress due to previous errors. Build build-debug failed with exit code 1
Comment Actions
Build Bitcoin ABC Diffs / Diff Testing (build-debug) failed.
Tail of the build log:
PASS : CompatTests::bswapTests() PASS : CompatTests::cleanupTestCase() Totals: 3 passed, 0 failed, 0 skipped, 0 blacklisted, 0ms ********* Finished testing of CompatTests ********* ********* Start testing of GUIUtilTests ********* Config: Using QtTest library 5.15.8, Qt 5.15.8 (x86_64-little_endian-lp64 shared (dynamic) release build; by GCC 12.2.0), debian 12 PASS : GUIUtilTests::initTestCase() PASS : GUIUtilTests::dummyAddressTest() PASS : GUIUtilTests::toCurrentEncodingTest() PASS : GUIUtilTests::cleanupTestCase() Totals: 4 passed, 0 failed, 0 skipped, 0 blacklisted, 0ms ********* Finished testing of GUIUtilTests ********* ********* Start testing of BitcoinAddressValidatorTests ********* Config: Using QtTest library 5.15.8, Qt 5.15.8 (x86_64-little_endian-lp64 shared (dynamic) release build; by GCC 12.2.0), debian 12 PASS : BitcoinAddressValidatorTests::initTestCase() PASS : BitcoinAddressValidatorTests::inputTests() PASS : BitcoinAddressValidatorTests::cleanupTestCase() Totals: 3 passed, 0 failed, 0 skipped, 0 blacklisted, 0ms ********* Finished testing of BitcoinAddressValidatorTests ********* ********* Start testing of WalletTests ********* Config: Using QtTest library 5.15.8, Qt 5.15.8 (x86_64-little_endian-lp64 shared (dynamic) release build; by GCC 12.2.0), debian 12 PASS : WalletTests::initTestCase() QDEBUG : WalletTests::walletTests() TransactionTablePriv::refreshWallet QWARN : WalletTests::walletTests() This plugin does not support propagateSizeHints() QDEBUG : WalletTests::walletTests() "NotifyTransactionChanged: 62042ce1c8bbe06dd7f89dd5e487f362f37bd205f2a6b5ae66795ab2b75e9f0b status= 0" QDEBUG : WalletTests::walletTests() "NotifyTransactionChanged: 1251b5211793c4b3863e5c49ab8b0d78aca1dbfaa6836bf63f989b6d9aef78b6 status= 1" QDEBUG : WalletTests::walletTests() "NotifyAddressBookChanged: ecregtest:qqqqqqqqqqqqqqqqqqqqqqqqqqqqqqqqqqcrl5mqkt isMine=0 purpose=send status=0" QDEBUG : WalletTests::walletTests() "TransactionTablePriv::updateWallet: 62042ce1c8bbe06dd7f89dd5e487f362f37bd205f2a6b5ae66795ab2b75e9f0b 0" QDEBUG : WalletTests::walletTests() " inModel=0 Index=30-30 showTransaction=1 derivedStatus=0" QDEBUG : WalletTests::walletTests() "TransactionTablePriv::updateWallet: 1251b5211793c4b3863e5c49ab8b0d78aca1dbfaa6836bf63f989b6d9aef78b6 1" QDEBUG : WalletTests::walletTests() " inModel=1 Index=6-7 showTransaction=1 derivedStatus=1" QWARN : WalletTests::walletTests() This plugin does not support propagateSizeHints() QDEBUG : WalletTests::walletTests() "NotifyTransactionChanged: 7cd5735ceeb6aaa0f356d1b26149acb9c3dbdc6b037aac0608bdc1bc888c7a09 status= 0" QDEBUG : WalletTests::walletTests() "NotifyTransactionChanged: 4eac54168d424139b50232e0d9b62ed7b0aa4238e8c0e7bda0fcf1cd88730d2b status= 1" QDEBUG : WalletTests::walletTests() "TransactionTablePriv::updateWallet: 7cd5735ceeb6aaa0f356d1b26149acb9c3dbdc6b037aac0608bdc1bc888c7a09 0" QDEBUG : WalletTests::walletTests() " inModel=0 Index=45-45 showTransaction=1 derivedStatus=0" QDEBUG : WalletTests::walletTests() "TransactionTablePriv::updateWallet: 4eac54168d424139b50232e0d9b62ed7b0aa4238e8c0e7bda0fcf1cd88730d2b 1" QDEBUG : WalletTests::walletTests() " inModel=1 Index=25-26 showTransaction=1 derivedStatus=1" QDEBUG : WalletTests::walletTests() "NotifyAddressBookChanged: ecregtest:qq7p02geylrap8lrm3mhte00wth0rkmxrqpcy59p5f TEST_LABEL_1 isMine=1 purpose=receive status=0" QWARN : WalletTests::walletTests() This plugin does not support propagateSizeHints() PASS : WalletTests::walletTests() PASS : WalletTests::cleanupTestCase() Totals: 3 passed, 0 failed, 0 skipped, 0 blacklisted, 708ms ********* Finished testing of WalletTests ********* ********* Start testing of AddressBookTests ********* Config: Using QtTest library 5.15.8, Qt 5.15.8 (x86_64-little_endian-lp64 shared (dynamic) release build; by GCC 12.2.0), debian 12 PASS : AddressBookTests::initTestCase() QDEBUG : AddressBookTests::addressBookTests() TransactionTablePriv::refreshWallet QWARN : AddressBookTests::addressBookTests() This plugin does not support propagateSizeHints() QWARN : AddressBookTests::addressBookTests() This plugin does not support propagateSizeHints() QDEBUG : AddressBookTests::addressBookTests() "NotifyAddressBookChanged: ecregtest:qppqzz2aa5dknysv6wa7fz9kszn3wdccw5jxheqrsa new isMine=0 purpose=send status=0" PASS : AddressBookTests::addressBookTests() PASS : AddressBookTests::cleanupTestCase() Totals: 3 passed, 0 failed, 0 skipped, 0 blacklisted, 225ms ********* Finished testing of AddressBookTests ********* ~BitcoinApplication : Stopping thread ~BitcoinApplication : Stopped thread Segmentation fault (core dumped) ninja: build stopped: cannot make progress due to previous errors. Build build-debug failed with exit code 1