Page MenuHomePhabricator
Differential D17998

RPC: Extract InvalidateBlock and ReconsiderBlock helpers
Needs ReviewPublic
Actions

Authored by PiRK on Sat, Apr 26, 06:41.

Details

Reviewers
Fabien
Group Reviewers
Restricted Project
Summary

The end goal is to reuse these helpers in dumptxoutset when dumping a utxo snapshot for a particular block height.

This is a partial backport of core#29553

https://github.com/bitcoin/bitcoin/pull/29553/commits/446ce51c21cd2466cb12fa0166fd069d42b603bf
https://github.com/bitcoin/bitcoin/pull/29553/commits/fccf4f91d21c351d742943d35476f53d40963b8b
Depends on D17997

Test Plan

ninja all check-all

Diff Detail

Event Timeline

PiRK created this revision.Sat, Apr 26, 06:41
Herald added a reviewer: Restricted Project. · View Herald TranscriptSat, Apr 26, 06:41
PiRK requested review of this revision.Sat, Apr 26, 06:41
teamcity edited the summary of this revision. (Show Details)Sat, Apr 26, 06:41
Harbormaster completed remote builds in B33113: Diff 53702.Sat, Apr 26, 06:55
Fabien requested changes to this revision.Sat, Apr 26, 09:13
Fabien added a subscriber: Fabien.

Please avoid copies when possible

src/rpc/blockchain.cpp
1617
1723
This revision now requires changes to proceed.Sat, Apr 26, 09:13
PiRK updated this revision to Diff 53706.Sat, Apr 26, 12:12

pass block hash by const reference & mark function as static

PiRK added a child revision: D17999: rpc: call RecalculateBestHeader as part of reconsiderblock.Sat, Apr 26, 12:20
Harbormaster completed remote builds in B33114: Diff 53706.Sat, Apr 26, 12:44

Revision Contents
Changeset List

PathSize
src/
rpc/
92 lines

Diff 53702

View Options

src/rpc/blockchain.cpp

Loading...