Page MenuHomePhabricator
Differential D18003

[avalanche] Fix incomplete testing of contenders when staking rewards are active
AbandonedPublic
Actions

Authored by roqqit on Sun, Apr 27, 02:05.

Details

Reviewers
Fabien
Group Reviewers
Restricted Project
Summary

D17997 erroneously asserts ACCEPTED for all contenders which is obviously wrong. I mistakenly assumed the contenders test was being run on the diff but it turns out contenders just barely exceeds the cutoff timing.

This diff does a few things:

  1. After the node is restarted, but before a new block is mined, check staking rewards status and use that to verify avalanche status of contenders.
  2. Activate staking rewards predictably and invalidate contenders for each block. This ensures the vote statuses are predictable and we get the same results on CI and local dev.
  3. Skip the very end of the test for now. This part is still flaky and needs more investigation, but master has been red for too long. It is best if we make it green again and fixup the last part in a separate diff.

Depends on D18022

Test Plan

Verify the test is not flaky:

for I in {0..20} do ; ./test/functional/test_runner.py abc_p2p_avalanche_contender_voting || break ; done

And have the bot run extended tests on this diff.

Diff Detail

Repository
rABC Bitcoin ABC
Branch
sc-fix-sr-lw-case
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 33123
Build 65729: Build Diffbuild-without-wallet · build-clang-tidy · build-clang · build-diff · build-debug
Build 65728: arc lint + arc unit

Event Timeline

roqqit created this revision.Sun, Apr 27, 02:05
Herald added a reviewer: Restricted Project. · View Herald TranscriptSun, Apr 27, 02:05
roqqit requested review of this revision.Sun, Apr 27, 02:05
roqqit added a comment.Sun, Apr 27, 02:06

@bot build-master

teamcity awarded a token.Sun, Apr 27, 02:06
roqqit edited the test plan for this revision. (Show Details)Sun, Apr 27, 02:07
Harbormaster completed remote builds in B33123: Diff 53716.Sun, Apr 27, 02:17
teamcity added a comment.Sun, Apr 27, 02:55
Build Bitcoin ABC Diffs / Diff Testing (build-master) failed.

Failed tests logs:

====== Bitcoin ABC extended functional tests: abc_p2p_avalanche_contender_voting.py ======

------- Stdout: -------
2025-04-27T02:07:43.384000Z TestFramework (INFO): Initializing test directory /work/abc-ci-builds/build-master/test/tmp/test_runner_₿₵_🏃_20250427_020741_1020/abc_p2p_avalanche_contender_voting_10
2025-04-27T02:07:56.648000Z TestFramework (INFO): Check votes after contender promotion
2025-04-27T02:08:06.118000Z TestFramework (INFO): Check votes after staking rewards have been computed
2025-04-27T02:08:06.283000Z TestFramework (INFO): Vote on contenders: manual winner + local winner
2025-04-27T02:08:16.559000Z TestFramework (INFO): Vote on contenders: local winner only
2025-04-27T02:08:20.605000Z TestFramework (INFO): Vote on contenders: 1 winner(s) other than local winner
2025-04-27T02:08:25.293000Z TestFramework (INFO): Vote on contenders: 2 winner(s) other than local winner
2025-04-27T02:08:29.770000Z TestFramework (INFO): Vote on contenders: 3 winner(s) other than local winner
2025-04-27T02:08:34.932000Z TestFramework (INFO): Vote on contenders: zero winners
2025-04-27T02:08:45.004000Z TestFramework (INFO): Vote on contenders: stale contenders
2025-04-27T02:08:50.825000Z TestFramework (INFO): Check votes after node restart
2025-04-27T02:09:07.649000Z TestFramework (ERROR): Assertion failed
Traceback (most recent call last):
  File "/work/test/functional/test_framework/test_framework.py", line 152, in main
    self._run_test_internal()
  File "/work/test/functional/test_framework/test_framework.py", line 142, in _run_test_internal
    self.run_test()
  File "/work/test/functional/abc_p2p_avalanche_contender_voting.py", line 553, in run_test
    assert_contender_polls(tip, get_all_contender_ids(tip))
  File "/work/test/functional/abc_p2p_avalanche_contender_voting.py", line 546, in assert_contender_polls
    assert_response(
  File "/work/test/functional/test_framework/avatools.py", line 532, in assert_response
    assert_equal(repr(votes[i]), repr(expected[i]))
  File "/work/test/functional/test_framework/util.py", line 56, in assert_equal
    raise AssertionError(
AssertionError: not(AvalancheVote(error=0, hash=bc8e8b58064f005b122187f478c0f89a7bd056abadf0f2ea4fbda27bd6759561) == AvalancheVote(error=1, hash=bc8e8b58064f005b122187f478c0f89a7bd056abadf0f2ea4fbda27bd6759561))
2025-04-27T02:09:07.652000Z TestFramework (INFO): Stopping nodes
2025-04-27T02:09:07.804000Z TestFramework (WARNING): Not cleaning up dir /work/abc-ci-builds/build-master/test/tmp/test_runner_₿₵_🏃_20250427_020741_1020/abc_p2p_avalanche_contender_voting_10
2025-04-27T02:09:07.804000Z TestFramework (ERROR): Test failed. Test logging available at /work/abc-ci-builds/build-master/test/tmp/test_runner_₿₵_🏃_20250427_020741_1020/abc_p2p_avalanche_contender_voting_10/test_framework.log
2025-04-27T02:09:07.804000Z TestFramework (ERROR): 
2025-04-27T02:09:07.804000Z TestFramework (ERROR): Hint: Call /work/test/functional/combine_logs.py '/work/abc-ci-builds/build-master/test/tmp/test_runner_₿₵_🏃_20250427_020741_1020/abc_p2p_avalanche_contender_voting_10' to consolidate all logs
2025-04-27T02:09:07.804000Z TestFramework (ERROR): 
2025-04-27T02:09:07.804000Z TestFramework (ERROR): If this failure happened unexpectedly or intermittently, please file a bug and provide a link or upload of the combined log.
2025-04-27T02:09:07.804000Z TestFramework (ERROR): https://github.com/Bitcoin-ABC/bitcoin-abc/issues
2025-04-27T02:09:07.804000Z TestFramework (ERROR):
====== Bitcoin ABC extended functional tests with the next upgrade activated: abc_p2p_avalanche_contender_voting.py ======

------- Stdout: -------
2025-04-27T02:31:01.213000Z TestFramework (INFO): Initializing test directory /work/abc-ci-builds/build-master/test/tmp/test_runner_₿₵_🏃_20250427_023059_24440/abc_p2p_avalanche_contender_voting_10
2025-04-27T02:31:08.561000Z TestFramework (INFO): Check votes after contender promotion
2025-04-27T02:31:14.307000Z TestFramework (ERROR): Assertion failed
Traceback (most recent call last):
  File "/work/test/functional/test_framework/test_framework.py", line 152, in main
    self._run_test_internal()
  File "/work/test/functional/test_framework/test_framework.py", line 142, in _run_test_internal
    self.run_test()
  File "/work/test/functional/abc_p2p_avalanche_contender_voting.py", line 247, in run_test
    self.wait_until(lambda: find_polled_contenders())
  File "/work/test/functional/test_framework/test_framework.py", line 890, in wait_until
    return wait_until_helper(
           ^^^^^^^^^^^^^^^^^^
  File "/work/test/functional/test_framework/util.py", line 302, in wait_until_helper
    if predicate():
       ^^^^^^^^^^^
  File "/work/test/functional/abc_p2p_avalanche_contender_voting.py", line 247, in <lambda>
    self.wait_until(lambda: find_polled_contenders())
                            ^^^^^^^^^^^^^^^^^^^^^^^^
  File "/work/test/functional/abc_p2p_avalanche_contender_voting.py", line 237, in find_polled_contenders
    assert_equal(len(polled_contenders), 12)
  File "/work/test/functional/test_framework/util.py", line 56, in assert_equal
    raise AssertionError(
AssertionError: not(1 == 12)
2025-04-27T02:31:14.359000Z TestFramework (INFO): Stopping nodes
2025-04-27T02:31:14.460000Z TestFramework (WARNING): Not cleaning up dir /work/abc-ci-builds/build-master/test/tmp/test_runner_₿₵_🏃_20250427_023059_24440/abc_p2p_avalanche_contender_voting_10
2025-04-27T02:31:14.460000Z TestFramework (ERROR): Test failed. Test logging available at /work/abc-ci-builds/build-master/test/tmp/test_runner_₿₵_🏃_20250427_023059_24440/abc_p2p_avalanche_contender_voting_10/test_framework.log
2025-04-27T02:31:14.460000Z TestFramework (ERROR): 
2025-04-27T02:31:14.460000Z TestFramework (ERROR): Hint: Call /work/test/functional/combine_logs.py '/work/abc-ci-builds/build-master/test/tmp/test_runner_₿₵_🏃_20250427_023059_24440/abc_p2p_avalanche_contender_voting_10' to consolidate all logs
2025-04-27T02:31:14.460000Z TestFramework (ERROR): 
2025-04-27T02:31:14.460000Z TestFramework (ERROR): If this failure happened unexpectedly or intermittently, please file a bug and provide a link or upload of the combined log.
2025-04-27T02:31:14.460000Z TestFramework (ERROR): https://github.com/Bitcoin-ABC/bitcoin-abc/issues
2025-04-27T02:31:14.460000Z TestFramework (ERROR):

Each failure log is accessible here:
Bitcoin ABC extended functional tests: abc_p2p_avalanche_contender_voting.py
Bitcoin ABC extended functional tests with the next upgrade activated: abc_p2p_avalanche_contender_voting.py

roqqit added a comment.Sun, Apr 27, 03:00

@bot build-master

teamcity updated a token.Sun, Apr 27, 03:00
roqqit planned changes to this revision.Sun, Apr 27, 03:00
teamcity added a comment.Sun, Apr 27, 03:59
Build Bitcoin ABC Diffs / Diff Testing (build-master) failed.

Failed tests logs:

====== Bitcoin ABC extended functional tests: abc_p2p_avalanche_contender_voting.py ======

------- Stdout: -------
2025-04-27T03:09:17.082000Z TestFramework (INFO): Initializing test directory /work/abc-ci-builds/build-master/test/tmp/test_runner_₿₵_🏃_20250427_030914_56865/abc_p2p_avalanche_contender_voting_10
2025-04-27T03:09:34.443000Z TestFramework (INFO): Check votes after contender promotion
2025-04-27T03:09:45.338000Z TestFramework (INFO): Check votes after staking rewards have been computed
2025-04-27T03:09:45.522000Z TestFramework (INFO): Vote on contenders: manual winner + local winner
2025-04-27T03:09:49.865000Z TestFramework (INFO): Vote on contenders: local winner only
2025-04-27T03:09:54.788000Z TestFramework (INFO): Vote on contenders: 1 winner(s) other than local winner
2025-04-27T03:09:59.783000Z TestFramework (INFO): Vote on contenders: 2 winner(s) other than local winner
2025-04-27T03:10:05.569000Z TestFramework (INFO): Vote on contenders: 3 winner(s) other than local winner
2025-04-27T03:10:11.673000Z TestFramework (INFO): Vote on contenders: zero winners
2025-04-27T03:10:22.784000Z TestFramework (INFO): Vote on contenders: stale contenders
2025-04-27T03:10:30.110000Z TestFramework (INFO): Check votes after node restart
2025-04-27T03:11:03.231000Z TestFramework (ERROR): Assertion failed
Traceback (most recent call last):
  File "/work/test/functional/test_framework/test_framework.py", line 152, in main
    self._run_test_internal()
  File "/work/test/functional/test_framework/test_framework.py", line 142, in _run_test_internal
    self.run_test()
  File "/work/test/functional/abc_p2p_avalanche_contender_voting.py", line 553, in run_test
    assert_contender_polls(tip, get_all_contender_ids(tip))
  File "/work/test/functional/abc_p2p_avalanche_contender_voting.py", line 546, in assert_contender_polls
    assert_response(
  File "/work/test/functional/test_framework/avatools.py", line 532, in assert_response
    assert_equal(repr(votes[i]), repr(expected[i]))
  File "/work/test/functional/test_framework/util.py", line 56, in assert_equal
    raise AssertionError(
AssertionError: not(AvalancheVote(error=0, hash=ee27118bd40c641fb238adc3d7ea86980439af7be9dd8503d9293698632bc7eb) == AvalancheVote(error=1, hash=ee27118bd40c641fb238adc3d7ea86980439af7be9dd8503d9293698632bc7eb))
2025-04-27T03:11:03.236000Z TestFramework (INFO): Stopping nodes
2025-04-27T03:11:03.338000Z TestFramework (WARNING): Not cleaning up dir /work/abc-ci-builds/build-master/test/tmp/test_runner_₿₵_🏃_20250427_030914_56865/abc_p2p_avalanche_contender_voting_10
2025-04-27T03:11:03.338000Z TestFramework (ERROR): Test failed. Test logging available at /work/abc-ci-builds/build-master/test/tmp/test_runner_₿₵_🏃_20250427_030914_56865/abc_p2p_avalanche_contender_voting_10/test_framework.log
2025-04-27T03:11:03.338000Z TestFramework (ERROR): 
2025-04-27T03:11:03.338000Z TestFramework (ERROR): Hint: Call /work/test/functional/combine_logs.py '/work/abc-ci-builds/build-master/test/tmp/test_runner_₿₵_🏃_20250427_030914_56865/abc_p2p_avalanche_contender_voting_10' to consolidate all logs
2025-04-27T03:11:03.338000Z TestFramework (ERROR): 
2025-04-27T03:11:03.338000Z TestFramework (ERROR): If this failure happened unexpectedly or intermittently, please file a bug and provide a link or upload of the combined log.
2025-04-27T03:11:03.338000Z TestFramework (ERROR): https://github.com/Bitcoin-ABC/bitcoin-abc/issues
2025-04-27T03:11:03.339000Z TestFramework (ERROR):
====== Bitcoin ABC extended functional tests with the next upgrade activated: abc_p2p_avalanche_contender_voting.py ======

------- Stdout: -------
2025-04-27T03:34:15.791000Z TestFramework (INFO): Initializing test directory /work/abc-ci-builds/build-master/test/tmp/test_runner_₿₵_🏃_20250427_033414_30330/abc_p2p_avalanche_contender_voting_10
2025-04-27T03:34:23.864000Z TestFramework (INFO): Check votes after contender promotion
2025-04-27T03:34:31.715000Z TestFramework (INFO): Check votes after staking rewards have been computed
2025-04-27T03:34:32.049000Z TestFramework (INFO): Vote on contenders: manual winner + local winner
2025-04-27T03:34:34.539000Z TestFramework (INFO): Vote on contenders: local winner only
2025-04-27T03:34:37.585000Z TestFramework (INFO): Vote on contenders: 1 winner(s) other than local winner
2025-04-27T03:34:40.003000Z TestFramework (INFO): Vote on contenders: 2 winner(s) other than local winner
2025-04-27T03:34:42.880000Z TestFramework (INFO): Vote on contenders: 3 winner(s) other than local winner
2025-04-27T03:34:45.819000Z TestFramework (INFO): Vote on contenders: zero winners
2025-04-27T03:34:48.620000Z TestFramework (INFO): Vote on contenders: stale contenders
2025-04-27T03:34:52.275000Z TestFramework (INFO): Check votes after node restart
2025-04-27T03:35:06.207000Z TestFramework (ERROR): Assertion failed
Traceback (most recent call last):
  File "/work/test/functional/test_framework/test_framework.py", line 152, in main
    self._run_test_internal()
  File "/work/test/functional/test_framework/test_framework.py", line 142, in _run_test_internal
    self.run_test()
  File "/work/test/functional/abc_p2p_avalanche_contender_voting.py", line 553, in run_test
    assert_contender_polls(tip, get_all_contender_ids(tip))
  File "/work/test/functional/abc_p2p_avalanche_contender_voting.py", line 546, in assert_contender_polls
    assert_response(
  File "/work/test/functional/test_framework/avatools.py", line 532, in assert_response
    assert_equal(repr(votes[i]), repr(expected[i]))
  File "/work/test/functional/test_framework/util.py", line 56, in assert_equal
    raise AssertionError(
AssertionError: not(AvalancheVote(error=0, hash=d8d8afbcc2914b07a30d0ebcd39ad0c7e0c16f72d2cb5b2ed3f42fb6b844e1c8) == AvalancheVote(error=1, hash=d8d8afbcc2914b07a30d0ebcd39ad0c7e0c16f72d2cb5b2ed3f42fb6b844e1c8))
2025-04-27T03:35:06.260000Z TestFramework (INFO): Stopping nodes
2025-04-27T03:35:06.370000Z TestFramework (WARNING): Not cleaning up dir /work/abc-ci-builds/build-master/test/tmp/test_runner_₿₵_🏃_20250427_033414_30330/abc_p2p_avalanche_contender_voting_10
2025-04-27T03:35:06.370000Z TestFramework (ERROR): Test failed. Test logging available at /work/abc-ci-builds/build-master/test/tmp/test_runner_₿₵_🏃_20250427_033414_30330/abc_p2p_avalanche_contender_voting_10/test_framework.log
2025-04-27T03:35:06.370000Z TestFramework (ERROR): 
2025-04-27T03:35:06.370000Z TestFramework (ERROR): Hint: Call /work/test/functional/combine_logs.py '/work/abc-ci-builds/build-master/test/tmp/test_runner_₿₵_🏃_20250427_033414_30330/abc_p2p_avalanche_contender_voting_10' to consolidate all logs
2025-04-27T03:35:06.370000Z TestFramework (ERROR): 
2025-04-27T03:35:06.370000Z TestFramework (ERROR): If this failure happened unexpectedly or intermittently, please file a bug and provide a link or upload of the combined log.
2025-04-27T03:35:06.371000Z TestFramework (ERROR): https://github.com/Bitcoin-ABC/bitcoin-abc/issues
2025-04-27T03:35:06.371000Z TestFramework (ERROR):

Each failure log is accessible here:
Bitcoin ABC extended functional tests: abc_p2p_avalanche_contender_voting.py
Bitcoin ABC extended functional tests with the next upgrade activated: abc_p2p_avalanche_contender_voting.py

roqqit mentioned this in D18013: [avalanche] Only re-add contenders to the cache if the remote proof is present.Mon, Apr 28, 23:53
roqqit mentioned this in rABC8ebbda579e21: [avalanche] Only re-add contenders to the cache if the remote proof is present.Tue, Apr 29, 18:53
roqqit updated this revision to Diff 53778.Wed, Apr 30, 03:32

fix various flakiness issues

roqqit planned changes to this revision.Wed, Apr 30, 03:32

@bot build-master

teamcity updated a token.Wed, Apr 30, 03:33
Harbormaster completed remote builds in B33167: Diff 53778.Wed, Apr 30, 03:47
roqqit requested review of this revision.Wed, Apr 30, 04:14
roqqit edited the summary of this revision. (Show Details)
roqqit edited the test plan for this revision. (Show Details)
roqqit added a comment.Wed, Apr 30, 04:17

see updated summary. skipping the end of the test is not ideal but it is unclear how much investigation that last piece will take. on the other hand, fixing the flakiness in the rest of the test ensures we are not regressing on the majority of contenders logic. CI deserves to be green again.

roqqit added a parent revision: D18022: [avalanche] Fix dangling proof flakiness in contender test.Wed, Apr 30, 04:17
roqqit edited the summary of this revision. (Show Details)
teamcity added a comment.Wed, Apr 30, 04:29
Build Bitcoin ABC Diffs / Diff Testing (build-master) failed.

Failed tests logs:

====== Bitcoin ABC extended functional tests: abc_p2p_avalanche_contender_voting.py ======

------- Stdout: -------
2025-04-30T03:40:08.055000Z TestFramework (INFO): Initializing test directory /work/abc-ci-builds/build-master/test/tmp/test_runner_₿₵_🏃_20250430_034005_41810/abc_p2p_avalanche_contender_voting_10
2025-04-30T03:40:24.886000Z TestFramework (INFO): Check votes after contender promotion
2025-04-30T03:40:34.522000Z TestFramework (ERROR): Assertion failed
Traceback (most recent call last):
  File "/work/test/functional/test_framework/test_framework.py", line 152, in main
    self._run_test_internal()
  File "/work/test/functional/test_framework/test_framework.py", line 142, in _run_test_internal
    self.run_test()
  File "/work/test/functional/abc_p2p_avalanche_contender_voting.py", line 249, in run_test
    self.wait_until(lambda: find_polled_contenders())
  File "/work/test/functional/test_framework/test_framework.py", line 890, in wait_until
    return wait_until_helper(
           ^^^^^^^^^^^^^^^^^^
  File "/work/test/functional/test_framework/util.py", line 302, in wait_until_helper
    if predicate():
       ^^^^^^^^^^^
  File "/work/test/functional/abc_p2p_avalanche_contender_voting.py", line 249, in <lambda>
    self.wait_until(lambda: find_polled_contenders())
                            ^^^^^^^^^^^^^^^^^^^^^^^^
  File "/work/test/functional/abc_p2p_avalanche_contender_voting.py", line 239, in find_polled_contenders
    assert_equal(len(polled_contenders), 12)
  File "/work/test/functional/test_framework/util.py", line 56, in assert_equal
    raise AssertionError(
AssertionError: not(1 == 12)
2025-04-30T03:40:34.524000Z TestFramework (INFO): Stopping nodes
2025-04-30T03:40:34.682000Z TestFramework (WARNING): Not cleaning up dir /work/abc-ci-builds/build-master/test/tmp/test_runner_₿₵_🏃_20250430_034005_41810/abc_p2p_avalanche_contender_voting_10
2025-04-30T03:40:34.682000Z TestFramework (ERROR): Test failed. Test logging available at /work/abc-ci-builds/build-master/test/tmp/test_runner_₿₵_🏃_20250430_034005_41810/abc_p2p_avalanche_contender_voting_10/test_framework.log
2025-04-30T03:40:34.682000Z TestFramework (ERROR): 
2025-04-30T03:40:34.682000Z TestFramework (ERROR): Hint: Call /work/test/functional/combine_logs.py '/work/abc-ci-builds/build-master/test/tmp/test_runner_₿₵_🏃_20250430_034005_41810/abc_p2p_avalanche_contender_voting_10' to consolidate all logs
2025-04-30T03:40:34.682000Z TestFramework (ERROR): 
2025-04-30T03:40:34.682000Z TestFramework (ERROR): If this failure happened unexpectedly or intermittently, please file a bug and provide a link or upload of the combined log.
2025-04-30T03:40:34.682000Z TestFramework (ERROR): https://github.com/Bitcoin-ABC/bitcoin-abc/issues
2025-04-30T03:40:34.682000Z TestFramework (ERROR):
====== Bitcoin ABC extended functional tests: abc_p2p_avalanche_voting.py ======

------- Stdout: -------
2025-04-30T03:40:07.925000Z TestFramework (INFO): Initializing test directory /work/abc-ci-builds/build-master/test/tmp/test_runner_₿₵_🏃_20250430_034005_41810/abc_p2p_avalanche_voting_9
2025-04-30T03:40:20.448000Z TestFramework (INFO): Poll for the chain tip...
2025-04-30T03:40:20.622000Z TestFramework (INFO): Poll for a selection of blocks...
2025-04-30T03:40:20.688000Z TestFramework (INFO): Poll for a selection of blocks, but some are now invalid...
2025-04-30T03:40:21.034000Z TestFramework (INFO): Poll for unknown blocks...
2025-04-30T03:40:21.091000Z TestFramework (INFO): Trigger polling from the node...
2025-04-30T03:40:22.318000Z TestFramework (INFO): Answer all polls to finalize...
2025-04-30T03:40:29.888000Z TestFramework (INFO): Answer all polls to park...
2025-04-30T03:40:42.370000Z TestFramework (INFO): Verify finalization sticks...
2025-04-30T03:40:42.370000Z TestFramework (INFO): ...for a chain 1 block long...
2025-04-30T03:40:42.384000Z TestFramework (INFO): ...for a chain 2 blocks long...
2025-04-30T03:40:45.631000Z TestFramework (INFO): ...for a chain 3 blocks long...
2025-04-30T03:40:48.774000Z TestFramework (INFO): ...for a chain 4 blocks long...
2025-04-30T03:40:52.240000Z TestFramework (INFO): ...for a chain 5 blocks long...
2025-04-30T03:40:55.692000Z TestFramework (INFO): Check the node is discouraging unexpected avaresponses.
2025-04-30T03:40:58.653000Z TestFramework (ERROR): Assertion failed
Traceback (most recent call last):
  File "/work/test/functional/test_framework/test_framework.py", line 152, in main
    self._run_test_internal()
  File "/work/test/functional/test_framework/test_framework.py", line 142, in _run_test_internal
    self.run_test()
  File "/work/test/functional/abc_p2p_avalanche_voting.py", line 365, in run_test
    with node.assert_debug_log(["Misbehaving", "unexpected-ava-response"]):
  File "/usr/lib/python3.11/contextlib.py", line 144, in __exit__
    next(self.gen)
  File "/work/test/functional/test_framework/test_node.py", line 647, in assert_debug_log
    self._raise_assertion_error(
  File "/work/test/functional/test_framework/test_node.py", line 271, in _raise_assertion_error
    raise AssertionError(self._node_msg(msg))
AssertionError: [node 0] Captured debug log:

 - 2025-04-30T03:40:56.637504Z (mocktime: 2025-04-30T03:40:56Z) [/work/src/net_processing.cpp:4833] [ProcessMessage] [netdebug] received: avaresponse (77 bytes) peer=0

Expected messages "['Misbehaving', 'unexpected-ava-response']" does not partially match the above log.

All expected messages are missing.

2025-04-30T03:40:58.705000Z TestFramework (INFO): Stopping nodes
2025-04-30T03:40:58.808000Z TestFramework (WARNING): Not cleaning up dir /work/abc-ci-builds/build-master/test/tmp/test_runner_₿₵_🏃_20250430_034005_41810/abc_p2p_avalanche_voting_9
2025-04-30T03:40:58.808000Z TestFramework (ERROR): Test failed. Test logging available at /work/abc-ci-builds/build-master/test/tmp/test_runner_₿₵_🏃_20250430_034005_41810/abc_p2p_avalanche_voting_9/test_framework.log
2025-04-30T03:40:58.808000Z TestFramework (ERROR): 
2025-04-30T03:40:58.808000Z TestFramework (ERROR): Hint: Call /work/test/functional/combine_logs.py '/work/abc-ci-builds/build-master/test/tmp/test_runner_₿₵_🏃_20250430_034005_41810/abc_p2p_avalanche_voting_9' to consolidate all logs
2025-04-30T03:40:58.808000Z TestFramework (ERROR): 
2025-04-30T03:40:58.809000Z TestFramework (ERROR): If this failure happened unexpectedly or intermittently, please file a bug and provide a link or upload of the combined log.
2025-04-30T03:40:58.809000Z TestFramework (ERROR): https://github.com/Bitcoin-ABC/bitcoin-abc/issues
2025-04-30T03:40:58.809000Z TestFramework (ERROR):
====== Bitcoin ABC extended functional tests with the next upgrade activated: abc_p2p_avalanche_contender_voting.py ======

------- Stdout: -------
2025-04-30T04:03:55.707000Z TestFramework (INFO): Initializing test directory /work/abc-ci-builds/build-master/test/tmp/test_runner_₿₵_🏃_20250430_040354_2761/abc_p2p_avalanche_contender_voting_10
2025-04-30T04:04:03.053000Z TestFramework (INFO): Check votes after contender promotion
2025-04-30T04:04:08.001000Z TestFramework (ERROR): Assertion failed
Traceback (most recent call last):
  File "/work/test/functional/test_framework/test_framework.py", line 152, in main
    self._run_test_internal()
  File "/work/test/functional/test_framework/test_framework.py", line 142, in _run_test_internal
    self.run_test()
  File "/work/test/functional/abc_p2p_avalanche_contender_voting.py", line 249, in run_test
    self.wait_until(lambda: find_polled_contenders())
  File "/work/test/functional/test_framework/test_framework.py", line 890, in wait_until
    return wait_until_helper(
           ^^^^^^^^^^^^^^^^^^
  File "/work/test/functional/test_framework/util.py", line 302, in wait_until_helper
    if predicate():
       ^^^^^^^^^^^
  File "/work/test/functional/abc_p2p_avalanche_contender_voting.py", line 249, in <lambda>
    self.wait_until(lambda: find_polled_contenders())
                            ^^^^^^^^^^^^^^^^^^^^^^^^
  File "/work/test/functional/abc_p2p_avalanche_contender_voting.py", line 239, in find_polled_contenders
    assert_equal(len(polled_contenders), 12)
  File "/work/test/functional/test_framework/util.py", line 56, in assert_equal
    raise AssertionError(
AssertionError: not(6 == 12)
2025-04-30T04:04:08.003000Z TestFramework (INFO): Stopping nodes
2025-04-30T04:04:08.154000Z TestFramework (WARNING): Not cleaning up dir /work/abc-ci-builds/build-master/test/tmp/test_runner_₿₵_🏃_20250430_040354_2761/abc_p2p_avalanche_contender_voting_10
2025-04-30T04:04:08.154000Z TestFramework (ERROR): Test failed. Test logging available at /work/abc-ci-builds/build-master/test/tmp/test_runner_₿₵_🏃_20250430_040354_2761/abc_p2p_avalanche_contender_voting_10/test_framework.log
2025-04-30T04:04:08.154000Z TestFramework (ERROR): 
2025-04-30T04:04:08.154000Z TestFramework (ERROR): Hint: Call /work/test/functional/combine_logs.py '/work/abc-ci-builds/build-master/test/tmp/test_runner_₿₵_🏃_20250430_040354_2761/abc_p2p_avalanche_contender_voting_10' to consolidate all logs
2025-04-30T04:04:08.154000Z TestFramework (ERROR): 
2025-04-30T04:04:08.154000Z TestFramework (ERROR): If this failure happened unexpectedly or intermittently, please file a bug and provide a link or upload of the combined log.
2025-04-30T04:04:08.154000Z TestFramework (ERROR): https://github.com/Bitcoin-ABC/bitcoin-abc/issues
2025-04-30T04:04:08.154000Z TestFramework (ERROR):
====== Bitcoin ABC extended functional tests with the next upgrade activated: abc_p2p_avalanche_voting.py ======

------- Stdout: -------
2025-04-30T04:03:55.707000Z TestFramework (INFO): Initializing test directory /work/abc-ci-builds/build-master/test/tmp/test_runner_₿₵_🏃_20250430_040354_2761/abc_p2p_avalanche_voting_9
2025-04-30T04:04:03.091000Z TestFramework (INFO): Poll for the chain tip...
2025-04-30T04:04:03.146000Z TestFramework (INFO): Poll for a selection of blocks...
2025-04-30T04:04:03.205000Z TestFramework (INFO): Poll for a selection of blocks, but some are now invalid...
2025-04-30T04:04:03.410000Z TestFramework (INFO): Poll for unknown blocks...
2025-04-30T04:04:03.466000Z TestFramework (INFO): Trigger polling from the node...
2025-04-30T04:04:03.952000Z TestFramework (INFO): Answer all polls to finalize...
2025-04-30T04:04:06.623000Z TestFramework (INFO): Answer all polls to park...
2025-04-30T04:04:14.459000Z TestFramework (INFO): Verify finalization sticks...
2025-04-30T04:04:14.460000Z TestFramework (INFO): ...for a chain 1 block long...
2025-04-30T04:04:14.521000Z TestFramework (INFO): ...for a chain 2 blocks long...
2025-04-30T04:04:16.731000Z TestFramework (INFO): ...for a chain 3 blocks long...
2025-04-30T04:04:19.022000Z TestFramework (INFO): ...for a chain 4 blocks long...
2025-04-30T04:04:21.806000Z TestFramework (INFO): ...for a chain 5 blocks long...
2025-04-30T04:04:24.394000Z TestFramework (INFO): Check the node is discouraging unexpected avaresponses.
2025-04-30T04:04:27.262000Z TestFramework (ERROR): Assertion failed
Traceback (most recent call last):
  File "/work/test/functional/test_framework/test_framework.py", line 152, in main
    self._run_test_internal()
  File "/work/test/functional/test_framework/test_framework.py", line 142, in _run_test_internal
    self.run_test()
  File "/work/test/functional/abc_p2p_avalanche_voting.py", line 365, in run_test
    with node.assert_debug_log(["Misbehaving", "unexpected-ava-response"]):
  File "/usr/lib/python3.11/contextlib.py", line 144, in __exit__
    next(self.gen)
  File "/work/test/functional/test_framework/test_node.py", line 647, in assert_debug_log
    self._raise_assertion_error(
  File "/work/test/functional/test_framework/test_node.py", line 271, in _raise_assertion_error
    raise AssertionError(self._node_msg(msg))
AssertionError: [node 0] Captured debug log:

 - 2025-04-30T04:04:25.239419Z (mocktime: 2025-04-30T04:04:24Z) [/work/src/net_processing.cpp:4833] [ProcessMessage] [netdebug] received: avaresponse (77 bytes) peer=0

Expected messages "['Misbehaving', 'unexpected-ava-response']" does not partially match the above log.

All expected messages are missing.

2025-04-30T04:04:27.315000Z TestFramework (INFO): Stopping nodes
2025-04-30T04:04:27.374000Z TestFramework (WARNING): Not cleaning up dir /work/abc-ci-builds/build-master/test/tmp/test_runner_₿₵_🏃_20250430_040354_2761/abc_p2p_avalanche_voting_9
2025-04-30T04:04:27.374000Z TestFramework (ERROR): Test failed. Test logging available at /work/abc-ci-builds/build-master/test/tmp/test_runner_₿₵_🏃_20250430_040354_2761/abc_p2p_avalanche_voting_9/test_framework.log
2025-04-30T04:04:27.374000Z TestFramework (ERROR): 
2025-04-30T04:04:27.374000Z TestFramework (ERROR): Hint: Call /work/test/functional/combine_logs.py '/work/abc-ci-builds/build-master/test/tmp/test_runner_₿₵_🏃_20250430_040354_2761/abc_p2p_avalanche_voting_9' to consolidate all logs
2025-04-30T04:04:27.374000Z TestFramework (ERROR): 
2025-04-30T04:04:27.374000Z TestFramework (ERROR): If this failure happened unexpectedly or intermittently, please file a bug and provide a link or upload of the combined log.
2025-04-30T04:04:27.374000Z TestFramework (ERROR): https://github.com/Bitcoin-ABC/bitcoin-abc/issues
2025-04-30T04:04:27.374000Z TestFramework (ERROR):

Each failure log is accessible here:
Bitcoin ABC extended functional tests: abc_p2p_avalanche_contender_voting.py
Bitcoin ABC extended functional tests: abc_p2p_avalanche_voting.py
Bitcoin ABC extended functional tests with the next upgrade activated: abc_p2p_avalanche_contender_voting.py
Bitcoin ABC extended functional tests with the next upgrade activated: abc_p2p_avalanche_voting.py

Fabien requested changes to this revision.Wed, Apr 30, 08:37
Fabien added a subscriber: Fabien.

Rebase for the other test failure

test/functional/abc_p2p_avalanche_contender_voting.py
488 ↗(On Diff #53778)

This is creating peers with a proof, and the proof is built by using coinbase utxos... and mining blocks to provide these coinbases. Because of the 3 confirmations this is actually mining 48 blocks (3 * 16 peers).

494 ↗(On Diff #53778)

This is actually not true, you mined a lot. 48 blocks exactly.

This revision now requires changes to proceed.Wed, Apr 30, 08:37
Fabien mentioned this in D18036: [avalanche] Fix incomplete testing of contenders when staking rewards are active.Wed, Apr 30, 20:01
roqqit mentioned this in rABC029da727864b: [avalanche] Fix incomplete testing of contenders when staking rewards are active.Thu, May 1, 18:22
roqqit abandoned this revision.Thu, May 1, 19:37

see D18036

Revision Contents
Changeset List

PathSize
test/
functional/
78 lines

Diff 53716

View Options

test/functional/abc_p2p_avalanche_contender_voting.py

Loading...