Differential D18083

More clang-tidy fixes
ClosedPublic
Actions

Authored by Fabien on Mon, May 12, 20:29.

Details

Reviewers

PiRK

Group Reviewers

Restricted Project

Commits

rABC0b231a78864e: More clang-tidy fixes

Summary

Fix more performance optimization found by a more recent version of clang-tidy and exclude the ones that we didn't attempt to fix yet.

Test Plan

Ran the clang tidy build with version 19.1.7

Diff Detail

Repository

rABC Bitcoin ABC

Branch

clang_tidy_fixes

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 33281
Build 66044: Build Diff	build-diff · build-without-wallet · build-debug · lint-circular-dependencies · build-bench · build-clang · build-clang-tidy
Build 66043: arc lint + arc unit

Event Timeline

Fabien created this revision.Mon, May 12, 20:29

Herald added a reviewer: Restricted Project. · View Herald TranscriptMon, May 12, 20:29

Fabien requested review of this revision.Mon, May 12, 20:29

Harbormaster completed remote builds in B33281: Diff 53958.Mon, May 12, 20:45

PiRK accepted this revision.Mon, May 12, 22:04

This revision is now accepted and ready to land.Mon, May 12, 22:04

Closed by commit rABC0b231a78864e: More clang-tidy fixes (authored by Fabien). · Explain WhyMon, May 12, 22:24

This revision was automatically updated to reflect the committed changes.

Fabien added a commit: rABC0b231a78864e: More clang-tidy fixes.

Revision Contents
Changeset List

Path

Size

src/

.clang-tidy

2 lines

avalanche/

test/

stakecontendercache_tests.cpp

1 line

bench/

prevector.cpp

2 lines

bitcoin-tx.cpp

10 lines

qt/

bitcoinunits.cpp

2 lines

rest.cpp

2 lines

seeder/

db.cpp

2 lines

test/

checkqueue_tests.cpp

1 line

cuckoocache_tests.cpp

1 line

rcu_tests.cpp

1 line

script_tests.cpp

6 lines

validation_block_tests.cpp

3 lines

Diff 53958

View Options

src/.clang-tidy

View Options

src/avalanche/test/stakecontendercache_tests.cpp

View Options

src/bench/prevector.cpp

View Options

src/bitcoin-tx.cpp

View Options

src/qt/bitcoinunits.cpp

View Options

src/rest.cpp

View Options

src/seeder/db.cpp

View Options

src/test/checkqueue_tests.cpp

View Options

src/test/cuckoocache_tests.cpp

View Options

src/test/rcu_tests.cpp

View Options

src/test/script_tests.cpp

View Options

src/test/validation_block_tests.cpp

More clang-tidy fixesClosedPublicActions

Details

Diff Detail

Event Timeline

Revision ContentsChangeset List

Diff 53958

src/.clang-tidy

src/avalanche/test/stakecontendercache_tests.cpp

src/bench/prevector.cpp

src/bitcoin-tx.cpp

src/qt/bitcoinunits.cpp

src/rest.cpp

src/seeder/db.cpp

src/test/checkqueue_tests.cpp

src/test/cuckoocache_tests.cpp

src/test/rcu_tests.cpp

src/test/script_tests.cpp

src/test/validation_block_tests.cpp

More clang-tidy fixes
ClosedPublic
Actions

Revision Contents
Changeset List