Differential D18105

[chronik] Electrum: don't enforce returning an array in notifications
ClosedPublic
Actions

Authored by Fabien on Mon, May 19, 07:25.

Tags

None

Subscribers

None

Details

Reviewers

Group Reviewers

Restricted Project

Commits

rABC91000692faec: [chronik] Electrum: don't enforce returning an array in notifications

Summary

This prevents the array from having several inside content, so better build directly the array at callsite. Also it makes it possible to return named parameters instead of positional parameters if needed in the future. For now there is no change in behavior.

Test Plan

./test/functional/test_runner.py chronik_electrum_*

Diff Detail

Repository

rABC Bitcoin ABC

Branch

chronik_encoder_no_array

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 33357
Build 66195: Build Diff	build-chronik-plugins · chronik-client-integration-tests · build-chronik · ecash-agora-integration-tests · ecash-lib-integration-tests
Build 66194: arc lint + arc unit

Event Timeline

Fabien created this revision.Mon, May 19, 07:25

Herald added a reviewer: Restricted Project. · View Herald TranscriptMon, May 19, 07:25

Fabien requested review of this revision.Mon, May 19, 07:25

Fabien added a child revision: D18106: [chronik] Electrum: consistently avoid repeating the serde_json namespace.Mon, May 19, 07:30

Harbormaster completed remote builds in B33357: Diff 54062.Mon, May 19, 07:43

Fabien added a child revision: D18107: [chronik] Electrum: don't assume notifications are returning in array in tests.Mon, May 19, 08:00

PiRK accepted this revision.Mon, May 19, 08:54

This revision is now accepted and ready to land.Mon, May 19, 08:54

Closed by commit rABC91000692faec: [chronik] Electrum: don't enforce returning an array in notifications (authored by Fabien). · Explain WhyMon, May 19, 09:15

This revision was automatically updated to reflect the committed changes.

Fabien added a commit: rABC91000692faec: [chronik] Electrum: don't enforce returning an array in notifications.

Revision Contents
Changeset List

Path

Size

chronik/

chronik-http/

src/

31 lines

Diff 54062

chronik/chronik-http/src/electrum.rs

Loading...