Paths

Table of Contentst

Differential D18176

test: Add tests for tableView in AddressBookPage dialog
ClosedPublic
Actions

Authored by PiRK on May 31 2025, 11:42.

Tags

None

Subscribers

None

Details

Reviewers

Group Reviewers

Restricted Project

Commits

rABCf01762842a8f: test: Add tests for tableView in AddressBookPage dialog

Summary

This PR is a prerequisite for more thorough testing of filtering in the AddressBookPage class

qt: No need to force Qt::QueuedConnection for NotifyAddressBookChanged

This change simplifies tests for AddressBookPage class.
No user-faced behavior change.

qt, test: Add tests for tableView in AddressBookPage dialog

This is a backport of core-gui#591
Depends on D18164

Test Plan

ninja check

Diff Detail

Repository

rABC Bitcoin ABC

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 33486
Build 66451: Build Diff	build-clang · build-debug · lint-circular-dependencies · build-without-wallet · build-diff · build-clang-tidy
Build 66450: arc lint + arc unit

Event Timeline

PiRK created this revision.May 31 2025, 11:42

Herald added a reviewer: Restricted Project. · View Herald TranscriptMay 31 2025, 11:42

PiRK requested review of this revision.May 31 2025, 11:42

teamcity edited the summary of this revision. (Show Details)May 31 2025, 11:42

PiRK added a child revision: D18177: qt: Use QRegularExpression in AddressBookSortFilterProxyModel class.May 31 2025, 11:43

Harbormaster completed remote builds in B33486: Diff 54266.May 31 2025, 11:53

Fabien accepted this revision.Jun 2 2025, 08:38

This revision is now accepted and ready to land.Jun 2 2025, 08:38

Closed by commit rABCf01762842a8f: test: Add tests for tableView in AddressBookPage dialog (authored by Hennadii Stepanov <32963518+hebasto@users.noreply.github.com>, committed by PiRK). · Explain WhyJun 2 2025, 09:21

This revision was automatically updated to reflect the committed changes.

PiRK added a commit: rABCf01762842a8f: test: Add tests for tableView in AddressBookPage dialog.

Revision Contents
Changeset List

Path

Size

src/

qt/

test/

addressbooktests.cpp

15 lines

walletmodel.cpp

6 lines

Diff 54266

src/qt/test/addressbooktests.cpp

Loading...

src/qt/walletmodel.cpp

Loading...