Page MenuHomePhabricator
Differential D18163

qt: Replace `QCoreApplication::quit()` with `QCoreApplication::exit(0)`
ClosedPublic
Actions

Authored by PiRK on May 28 2025, 08:52.

Details

Reviewers
Fabien
Group Reviewers
Restricted Project
Commits
rABC0a567d65df81: qt: Replace `QCoreApplication::quit()` with `QCoreApplication::exit(0)`
Summary

Qt 5:

  • no behavior change

Qt 6:

  • this change avoids sending a duplicated QEvent::Quit

This is a backport of core-gui#586

Test Plan

ninja all check-all
Run bitcoin-qt and quit the gui.

Diff Detail

Repository
rABC Bitcoin ABC
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

PiRK created this revision.May 28 2025, 08:52
Herald added a reviewer: Restricted Project. · View Herald TranscriptMay 28 2025, 08:52
PiRK requested review of this revision.May 28 2025, 08:52
teamcity edited the summary of this revision. (Show Details)May 28 2025, 08:52
PiRK added a child revision: D18164: qt: Do not pass WalletModel* to a queued connection.May 28 2025, 08:53
Fabien accepted this revision.May 28 2025, 09:03
This revision is now accepted and ready to land.May 28 2025, 09:03
Harbormaster completed remote builds in B33460: Diff 54223.May 28 2025, 09:25
PiRK requested review of this revision.May 29 2025, 14:28

will need to be rebased onto D18170 (if/when it is tested and reviewed)

PiRK planned changes to this revision.May 29 2025, 14:28
PiRK updated this revision to Diff 54264.May 31 2025, 06:17

rebase after landing D18170

Harbormaster completed remote builds in B33484: Diff 54264.May 31 2025, 06:42
Fabien accepted this revision.Jun 1 2025, 14:55
This revision is now accepted and ready to land.Jun 1 2025, 14:55
Closed by commit rABC0a567d65df81: qt: Replace `QCoreApplication::quit()` with `QCoreApplication::exit(0)` (authored by Hennadii Stepanov <32963518+hebasto@users.noreply.github.com>, committed by PiRK). · Explain WhyJun 2 2025, 09:21
This revision was automatically updated to reflect the committed changes.
PiRK added a commit: rABC0a567d65df81: qt: Replace `QCoreApplication::quit()` with `QCoreApplication::exit(0)`.

Revision Contents
Changeset List

PathSize
src/
qt/
2 lines
test/
2 lines

Diff 54273

View Options

src/qt/bitcoin.cpp

Loading...
View Options

src/qt/test/apptests.cpp

Loading...