Differential D18308

[tests] Use ConnmanTestMsg when possible
ClosedPublic
Actions

Authored by Fabien on Jul 2 2025, 08:45.

Details

Reviewers

PiRK

Group Reviewers

Restricted Project

Commits

rABC068e8191aa62: [tests] Use ConnmanTestMsg when possible

Summary

This gets rid of the CConnmanTest struct in the processor tests and denialofservice tests. This code was duplicated.

Test Plan

ninja check

Diff Detail

Repository

rABC Bitcoin ABC

Branch

processor_connmantestmsg

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 33730
Build 66938: Build Diff	build-clang-tidy · lint-circular-dependencies · build-debug · build-without-wallet · build-clang · build-diff
Build 66937: arc lint + arc unit

Event Timeline

Fabien created this revision.Jul 2 2025, 08:45

Herald added a reviewer: Restricted Project. · View Herald TranscriptJul 2 2025, 08:45

Fabien requested review of this revision.Jul 2 2025, 08:45

Harbormaster completed remote builds in B33730: Diff 54645.Jul 2 2025, 09:17

Fabien added a child revision: D18310: [avalanche] Test: move the AvalancheTestingSetup to the common test header.Jul 2 2025, 11:17

PiRK accepted this revision.Jul 2 2025, 11:48

This revision is now accepted and ready to land.Jul 2 2025, 11:48

Closed by commit rABC068e8191aa62: [tests] Use ConnmanTestMsg when possible (authored by Fabien). · Explain WhyJul 2 2025, 13:18

This revision was automatically updated to reflect the committed changes.

Fabien added a commit: rABC068e8191aa62: [tests] Use ConnmanTestMsg when possible.

Revision Contents
Changeset List

Path

Size

src/

avalanche/

test/

processor_tests.cpp

26 lines

test/

denialofservice_tests.cpp

27 lines

Diff 54645

View Options

src/avalanche/test/processor_tests.cpp