Page MenuHomePhabricator
Differential D18447

p2p: sync from limited peer, only request blocks below threshold
AcceptedPublic
Actions

Authored by PiRK on Aug 5 2025, 15:52.

Details

Reviewers
Fabien
Group Reviewers
Restricted Project
Summary

Requesting historical blocks from network limited peers is a direct disconnection cause.
The node must only request the blocks who know for sure the limited peer can provide, and not just assume that it can request any blocks as soon as it leaves IBD.

This is a backport of core#28120

Test Plan

Checked that the new functional test fails on master, so this diff actually fixes something.

ninja all check-all

Diff Detail

Event Timeline

PiRK created this revision.Aug 5 2025, 15:52
Herald added a reviewer: Restricted Project. · View Herald TranscriptAug 5 2025, 15:52
teamcity edited the summary of this revision. (Show Details)Aug 5 2025, 15:52
Harbormaster completed remote builds in B34046: Diff 55103.Aug 5 2025, 16:04
PiRK published this revision for review.Aug 6 2025, 11:35
Fabien accepted this revision.Aug 9 2025, 16:33
Fabien added a subscriber: Fabien.
Fabien added inline comments.
src/net_processing.cpp
2087 ↗(On Diff #55103)
test/functional/p2p_node_network_limited.py
22 ↗(On Diff #55103)
This revision is now accepted and ready to land.Aug 9 2025, 16:33
PiRK updated this revision to Diff 55317.Aug 21 2025, 15:20

const, comment layout

Harbormaster completed remote builds in B34201: Diff 55317.Aug 21 2025, 15:39

Revision Contents
Changeset List

PathSize
src/
58 lines
test/
functional/
87 lines

Diff 55317

View Options

src/net_processing.cpp

Loading...
View Options

test/functional/p2p_node_network_limited.py

Loading...