Page MenuHomePhabricator
Differential D18946

test: use a regexp in ecash-agora test
ClosedPublic
Actions

Authored by PiRK on Mon, Nov 17, 09:14.

Details

Reviewers
Fabien
Group Reviewers
Restricted Project
Commits
rABC3abc25461f59: test: use a regexp in ecash-agora test
Summary

The error message is now more specific, it mentions the txid and input index of the failing tx as well as the outpoint being spent.
So match a regex instead of trying to get the exact error message with potentially non-deterministic data in it.

Test Plan

ecash-agora-integration-tests

Diff Detail

Event Timeline

PiRK created this revision.Mon, Nov 17, 09:14
Herald added a reviewer: Restricted Project. · View Herald TranscriptMon, Nov 17, 09:14
PiRK requested review of this revision.Mon, Nov 17, 09:14
PiRK added a comment.Mon, Nov 17, 09:15

see https://reviews.bitcoinabc.org/D18933#431712 for a failure example

PiRK added a comment.Mon, Nov 17, 09:15

@bot ecash-agora-integration-tests

teamcity awarded a token.Mon, Nov 17, 09:15
Harbormaster completed remote builds in B35082: Diff 56631.Mon, Nov 17, 09:29
Fabien accepted this revision.Mon, Nov 17, 09:33
This revision is now accepted and ready to land.Mon, Nov 17, 09:33
PiRK retitled this revision from test: use a regext in ecash-agora test to test: use a regexp in ecash-agora test.Mon, Nov 17, 09:50
Closed by commit rABC3abc25461f59: test: use a regexp in ecash-agora test (authored by PiRK). · Explain WhyMon, Nov 17, 09:53
This revision was automatically updated to reflect the committed changes.
PiRK added a commit: rABC3abc25461f59: test: use a regexp in ecash-agora test.

Revision Contents
Changeset List

PathSize
modules/
ecash-agora/
tests/
2 lines

Diff 56631

View Options

modules/ecash-agora/tests/partial.locktime.test.ts

Loading...