crypto: add the ChaCha20Poly1305 AEAD as specified in RFC8439
AcceptedPublic
Actions

Authored by PiRK on Tue, Dec 2, 14:47.

Details

Reviewers

Fabien

Group Reviewers

Restricted Project

Summary

This adds an implementation of the ChaCha20Poly1305 AEAD exactly matching
the version specified in RFC8439 section 2.8, including tests and official
test vectors.

This is a partial backport of core#28008 and a backport of core#29815
https://github.com/bitcoin/bitcoin/pull/28008/commits/9ff0768bdcca06836ccc673eacfa648e801930cb

Squashing with ccore#29815 bypasses a change from core#29404 (#include <config/bitcoin-config.h>)

Depends on D19017

Test Plan

ninja all check-all

Diff Detail

Repository

rABC Bitcoin ABC

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 35188
Build 69834: Build Diff	lint-circular-dependencies · build-without-wallet · build-diff · build-debug · build-clang-tidy · build-clang
Build 69833: arc lint + arc unit

Event Timeline

PiRK created this revision.Tue, Dec 2, 14:47

Herald added a reviewer: Restricted Project. · View Herald TranscriptTue, Dec 2, 14:47

PiRK requested review of this revision.Tue, Dec 2, 14:47

teamcity edited the summary of this revision. (Show Details)Tue, Dec 2, 14:47

PiRK added a child revision: D19019: crypto: add FSChaCha20, a rekeying wrapper around ChaCha20.Tue, Dec 2, 14:48

Harbormaster completed remote builds in B35188: Diff 56801.Tue, Dec 2, 15:15

Fabien requested changes to this revision.Wed, Dec 3, 08:48

Fabien added a subscriber: Fabien.

Fabien added inline comments.

src/crypto/chacha20poly1305.cpp
29	What's the point? It won't build if this is defined, and there is no build system check for the availability of this function. Also it's defined in string.h/cstring which is not included
src/crypto/chacha20poly1305.h
12	this should come before the std headers