Page MenuHomePhabricator
Differential D2015

[qa] fix abc-p2p-compactblocks test to use add_argument
ClosedPublic
Actions

Authored by schancel on Nov 7 2018, 00:10.

Details

Reviewers
jasonbcox
Group Reviewers
Restricted Project
Commits
rSTAGINGc42521518207: [qa] fix abc-p2p-compactblocks test to use add_argument
rABCc42521518207: [qa] fix abc-p2p-compactblocks test to use add_argument
Summary

As per title, fixes issue that was introduced with D2010

Test Plan
make && ./test/functional/test_runner.py --extended

Diff Detail

Repository
rABC Bitcoin ABC
Branch
fix-abc-p2p-test
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 3798
Build 5670: Bitcoin ABC Buildbot (legacy)
Build 5669: arc lint + arc unit

Event Timeline

schancel created this revision.Nov 7 2018, 00:10
Herald added a reviewer: Restricted Project. · View Herald TranscriptNov 7 2018, 00:10
teamcity added a subscriber: teamcity.Nov 7 2018, 00:10

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing started.

jasonbcox requested changes to this revision.Nov 7 2018, 00:16
jasonbcox added a subscriber: jasonbcox.

I literally just landed D1961 so you'll need to rebase and rename add_options there too. Otherwise, looks good.

This revision now requires changes to proceed.Nov 7 2018, 00:16
Harbormaster completed remote builds in B3797: Diff 5683.Nov 7 2018, 00:18
teamcity added a comment.Nov 7 2018, 00:18

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing passed.

schancel updated this revision to Diff 5685.Nov 7 2018, 00:23

Remove add_options change

schancel retitled this revision from [qa] fix abc-p2p-compactblocks test to use add_argument and rename add_options to [qa] fix abc-p2p-compactblocks test to use add_argument.Nov 7 2018, 00:23
teamcity added a comment.Nov 7 2018, 00:24

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing started.

jasonbcox accepted this revision.Nov 7 2018, 00:25
This revision is now accepted and ready to land.Nov 7 2018, 00:25
Closed by commit rABCc42521518207: [qa] fix abc-p2p-compactblocks test to use add_argument (authored by schancel). · Explain WhyNov 7 2018, 00:26
This revision was automatically updated to reflect the committed changes.
teamcity added a comment.Nov 7 2018, 00:31

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing passed.

Harbormaster completed remote builds in B3798: Diff 5685.Nov 7 2018, 00:31

Revision Contents
Changeset List

PathSize
test/
functional/
2 lines

Diff 5685

View Options

test/functional/abc-p2p-compactblocks.py

Loading...