Fix various bugs in the seeder.
ClosedPublic
Actions

Authored by deadalnix on Nov 21 2018, 15:07.

Details

Reviewers

Fabien

Group Reviewers

Restricted Project

Commits

Summary

fix fubared logs format
Ensure that the main logger dump on the console just like the rest of the seeder does.
Ensure connections to new nodes are etablished properly.

Test Plan

Run the seeder manually, ensure it starts crawling the network and that the log look much better.

Repository

rABC Bitcoin ABC

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Also close sockets properly

Fabien requested changes to this revision.Nov 22 2018, 00:43

Fabien added a subscriber: Fabien.

Fabien added inline comments.

src/seeder/main.cpp
426 ↗	(On Diff #5979)	You may want to print line by line instead, because the logs and the loop print overlap giving some weird output to the console

This revision now requires changes to proceed.Nov 22 2018, 00:43

deadalnix requested review of this revision.Nov 22 2018, 01:59

deadalnix marked an inline comment as done.

deadalnix added inline comments.

src/seeder/main.cpp
426 ↗	(On Diff #5979)	That is what the \n a few line bellow is doing.

src/seeder/main.cpp
426 ↗	(On Diff #5979)	This does not seem to be sufficient. I suppose other logs can be printed in another thread ? I ended up with lines like this : NS requests, 0 db queriesct() to [<ip>]:8333 failed: Netwo on a standard 80 char terminal or 2018-11-22 00:35:13 connect() to <ip>:8333 failed after select(): Connection refused (111)nreachable (101) on a larger one