Add new test cases and assertions.
Also replace the sync_blocks calls with a proper wait_for_tip() function.
Depends on D2161
Details
Details
- Reviewers
deadalnix - Group Reviewers
Restricted Project - Commits
- rSTAGING0890051f4081: Add new test cases to abc-finalize-.py
rABC0890051f4081: Add new test cases to abc-finalize-.py
./test/functional/test_runner.py abc-finalize-block
Diff Detail
Diff Detail
- Repository
- rABC Bitcoin ABC
- Branch
- add_finalization_test_cases
- Lint
Lint Passed - Unit
No Test Coverage - Build Status
Buildable 4203 Build 6472: Bitcoin ABC Buildbot (legacy) Build 6471: arc lint + arc unit
Event Timeline
Comment Actions
This ends up changing all the tests for no good reasons. Just add the new tests cases after the existing ones. You can use reconsiderblock/invalidate block to recreate the situation you desire.
| test/functional/abc-finalize-block.py | ||
|---|---|---|
| 154 ↗ | (On Diff #6233) | It's clearly not doing this anymore. |
| 171 ↗ | (On Diff #6233) | alt_node.generate(10) And then wait for node to catch up. You want to check that the node sync the way you expect note force the test framework to do it. |
| test/functional/abc-finalize-block.py | ||
|---|---|---|
| 152 ↗ | (On Diff #6280) |
|
| 171 ↗ | (On Diff #6280) | 210 is finalized, so why change the comment ? |
| 179 ↗ | (On Diff #6280) | This test really isn't testing anything useful. I don't see in what situation you'd end finalizing that block anyways. Plus we already checked that the finalized block is the tip. |
| 180 ↗ | (On Diff #6280) | Plus you actually check the value here. |
| test/functional/abc-finalize-block.py | ||
|---|---|---|
| 171 ↗ | (On Diff #6280) | Good catch, looks like a merge error while rebasing. |
| test/functional/abc-finalize-block.py | ||
|---|---|---|
| 228 ↗ | (On Diff #6286) | Maybe using alt_node_new_tip here would be best. |