Any error code starting with a the bit 1 will be considered as an inconclusive vote. The node is not for or against.
Depends on D2148
Details
Details
- Reviewers
jasonbcox - Group Reviewers
Restricted Project - Commits
- rSTAGING7f7f55cc7216: [avalanche] Add the concept of inconclusive votes
rABC7f7f55cc7216: [avalanche] Add the concept of inconclusive votes
Added test cases to make sure this is handled properly.
Diff Detail
Diff Detail
- Repository
- rABC Bitcoin ABC
- Branch
- avaignorevote
- Lint
Lint Passed - Unit
No Test Coverage - Build Status
Buildable 4254 Build 6573: Bitcoin ABC Buildbot (legacy) Build 6572: arc lint + arc unit
Event Timeline
| src/avalanche.cpp | ||
|---|---|---|
| 29 ↗ | (On Diff #6196) | This section had me confused. Calling this error is only accurate for values <= 0. It wasn't clear that error could be the full range of int values until I ran this over a few times. There needs to be function-level documentation of the expected/supported values: /** * registerVote() adds a vote for consideration. * Vote values are calculated as follows: * > 0 for "no" votes * 0 for "yes" votes * < 0 for error states. */ This information is not covered sufficiently by the comment below this one since it primarily covers calculating of the yes/no/error votes from votes and consider, rather than how yes/no/error votes are input'd into the function. |
| src/avalanche.cpp | ||
|---|---|---|
| 114 ↗ | (On Diff #6196) | int -> uint16_t unless there is a good reason to abstract away the size |
| src/avalanche.cpp | ||
|---|---|---|
| 36 ↗ | (On Diff #6236) | erro -> error |