Use tobytes instead of tostring in netutil.py
ClosedPublic
Actions

Authored by deadalnix on Dec 21 2018, 11:32.

Details

Reviewers

Group Reviewers

Restricted Project

Commits

rSTAGING295ecf0ab9de: Use tobytes instead of tostring in netutil.py
rABC295ecf0ab9de: Use tobytes instead of tostring in netutil.py

Summary

tostring was deprecated in pything 3.7 and this is spewing errors

Test Plan

./test/functional/test_runner.py rpcbind_test.py

Diff Detail

Repository

rABC Bitcoin ABC

Branch

pr13963

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 4336
Build 6737: Bitcoin ABC Buildbot (legacy)
Build 6736: arc lint + arc unit

Event Timeline

deadalnix created this revision.Dec 21 2018, 11:32

Herald added a reviewer: Restricted Project. · View Herald TranscriptDec 21 2018, 11:32

Herald added a subscriber: schancel. · View Herald Transcript

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing started.

Fabien accepted this revision.Dec 21 2018, 11:37

This revision is now accepted and ready to land.Dec 21 2018, 11:37

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing passed.

Harbormaster completed remote builds in B4336: Diff 6381.Dec 21 2018, 11:42

Closed by commit rABC295ecf0ab9de: Use tobytes instead of tostring in netutil.py (authored by deadalnix). · Explain WhyDec 21 2018, 12:04

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

test/

functional/

test_framework/

netutil.py

2 lines

Diff 6381

View Options

test/functional/test_framework/netutil.py

Use tobytes instead of tostring in netutil.pyClosedPublicActions