Fix missing lock in AvalancheProcessor::getInvsForNextPoll()
ClosedPublic
Actions

Authored by Fabien on Jan 11 2019, 17:29.

Details

Reviewers

Group Reviewers

Restricted Project

Commits

rSTAGING3980299697b2: Fix missing lock in AvalancheProcessor::getInvsForNextPoll()
rABC3980299697b2: Fix missing lock in AvalancheProcessor::getInvsForNextPoll()

Summary

IsWorthPolling requires cs_main to be held (for
IsBlockFinalized that accesses pIndexFinalized)

Test Plan

./autogen.sh
mkdir build
cd build
../configure --enable-debug
make -j<your machine number of logic core> check

Diff Detail

Repository

rABC Bitcoin ABC

Branch

avalanche_fix_missing_lock

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 4488
Build 7039: Bitcoin ABC Buildbot (legacy)
Build 7038: arc lint + arc unit

Event Timeline

Fabien created this revision.Jan 11 2019, 17:29

Herald added a reviewer: Restricted Project. · View Herald TranscriptJan 11 2019, 17:29

Herald added a reviewer: deadalnix. · View Herald Transcript

Herald added a subscriber: schancel. · View Herald Transcript

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing started.

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing passed.

Harbormaster completed remote builds in B4488: Diff 6615.Jan 11 2019, 17:39

deadalnix accepted this revision.Jan 11 2019, 22:28

This revision is now accepted and ready to land.Jan 11 2019, 22:28

Closed by commit rABC3980299697b2: Fix missing lock in AvalancheProcessor::getInvsForNextPoll() (authored by Fabien). · Explain WhyJan 12 2019, 09:42

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

src/

avalanche.cpp

2 lines

Diff 6615

View Options

Fix missing lock in AvalancheProcessor::getInvsForNextPoll()ClosedPublicActions