Page MenuHomePhabricator
Differential D2300

Various nits in the RCU mechanism
ClosedPublic
Actions

Authored by deadalnix on Jan 13 2019, 17:52.

Details

Reviewers
jasonbcox
Group Reviewers
Restricted Project
Commits
rSTAGINGa428e37c8181: Various nits in the RCU mechanism
rABCa428e37c8181: Various nits in the RCU mechanism
Summary

Remove uneeded include.
Rename variable with poor name foo.
Remove redundant loads as compare_exchange_weak update expected value when the update fails.
Fix copyright notice.

Test Plan
make check

Diff Detail

Repository
rABC Bitcoin ABC
Branch
rcunits
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 4498
Build 7059: Bitcoin ABC Buildbot (legacy)
Build 7058: arc lint + arc unit

Event Timeline

deadalnix created this revision.Jan 13 2019, 17:52
Herald added a reviewer: Restricted Project. · View Herald TranscriptJan 13 2019, 17:52
Herald added a subscriber: schancel. · View Herald Transcript
teamcity added a subscriber: teamcity.Jan 13 2019, 17:54

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing started.

deadalnix updated this revision to Diff 6632.Jan 13 2019, 17:56

Also fix copyright year for te test.

deadalnix edited the summary of this revision. (Show Details)Jan 13 2019, 17:56
teamcity added a comment.Jan 13 2019, 17:57

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing started.

teamcity added a comment.Jan 13 2019, 18:03

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing passed.

Harbormaster completed remote builds in B4497: Diff 6631.Jan 13 2019, 18:03
teamcity added a comment.Jan 13 2019, 18:06

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing failed.

Harbormaster failed remote builds in B4498: Diff 6632!Jan 13 2019, 18:06
jasonbcox accepted this revision.Jan 13 2019, 21:00
jasonbcox retitled this revision from Various nits in the RUC mechanism to Various nits in the RCU mechanism.
This revision is now accepted and ready to land.Jan 13 2019, 21:00
teamcity added a comment.Jan 13 2019, 21:02

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing started.

teamcity added a comment.Jan 13 2019, 21:11

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing passed.

Harbormaster completed remote builds in B4498: Diff 6632.Jan 13 2019, 21:11
Closed by commit rABCa428e37c8181: Various nits in the RCU mechanism (authored by deadalnix). · Explain WhyJan 14 2019, 00:55
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathSize
src/
1 line
13 lines
test/
2 lines

Diff 6632

View Options

src/rcu.h

Loading...
View Options

src/rcu.cpp

Loading...
View Options

src/test/rcu_tests.cpp

Loading...