Page MenuHomePhabricator
Differential D2340

[RCU] Implement RCUPtr, a smart pointer that free asynchronousely when other threads did synchronize.
ClosedPublic
Actions

Authored by deadalnix on Jan 18 2019, 20:21.

Details

Reviewers
Fabien
Group Reviewers
Restricted Project
Commits
rSTAGING77afb6c05669: [RCU] Implement RCUPtr, a smart pointer that free asynchronousely when other…
rABC77afb6c05669: [RCU] Implement RCUPtr, a smart pointer that free asynchronousely when other…
Summary

This will make the memory managaement for the RadixTree significantly easier and even allow the tree to share some of its innard with the outside world.

Depends on D2317

Test Plan

Adde unt tests for the various behaviors implemented.

Diff Detail

Repository
rABC Bitcoin ABC
Branch
rcuptr
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 4572
Build 7207: Bitcoin ABC Buildbot (legacy)
Build 7206: arc lint + arc unit

Event Timeline

deadalnix created this revision.Jan 18 2019, 20:21
Herald added a reviewer: Restricted Project. · View Herald TranscriptJan 18 2019, 20:21
Herald added a subscriber: schancel. · View Herald Transcript
teamcity added a subscriber: teamcity.Jan 18 2019, 20:23

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing started.

teamcity added a comment.Jan 18 2019, 20:31

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing passed.

Harbormaster completed remote builds in B4572: Diff 6735.Jan 18 2019, 20:32
deadalnix updated this revision to Diff 6747.Jan 19 2019, 16:02

Use a factory method instead of a free function for make

teamcity added a comment.Jan 19 2019, 16:02

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing started.

Harbormaster completed remote builds in B4582: Diff 6747.Jan 19 2019, 16:11
teamcity added a comment.Jan 19 2019, 16:11

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing passed.

deadalnix added a child revision: D2350: [RCU] Add new features to RCUPtr.Jan 20 2019, 17:55
Fabien requested changes to this revision.Jan 24 2019, 14:35
Fabien added a subscriber: Fabien.
Fabien added inline comments.
src/rcu.h
159 ↗(On Diff #6747)

What prevents from using a signed ?

src/test/rcu_tests.cpp
205 ↗(On Diff #6747)

desturction => destruction

This revision now requires changes to proceed.Jan 24 2019, 14:35
deadalnix added inline comments.Jan 25 2019, 21:16
src/rcu.h
159 ↗(On Diff #6747)

Because that can only be a mistake as you'd truncate you range in half and gain nothing.

deadalnix updated this revision to Diff 6941.Jan 25 2019, 21:20

Fix typo

teamcity added a comment.Jan 25 2019, 21:21

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing started.

teamcity added a comment.Jan 25 2019, 21:35

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing passed.

Harbormaster completed remote builds in B4710: Diff 6941.Jan 25 2019, 21:35
Fabien accepted this revision.Jan 28 2019, 17:56
This revision is now accepted and ready to land.Jan 28 2019, 17:56
Closed by commit rABC77afb6c05669: [RCU] Implement RCUPtr, a smart pointer that free asynchronousely when other… (authored by deadalnix). · Explain WhyJan 29 2019, 18:56
This revision was automatically updated to reflect the committed changes.
deadalnix added a commit: rSTAGING77afb6c05669: [RCU] Implement RCUPtr, a smart pointer that free asynchronousely when other….Sep 18 2019, 22:08

Revision Contents
Changeset List

PathSize
src/
86 lines
test/
127 lines

Diff 6735

View Options

src/rcu.h

Loading...
View Options

src/test/rcu_tests.cpp

Loading...