Details

Reviewers

Group Reviewers

Restricted Project

Commits

rSTAGING1cab8a4eb82a: [Radix] Use RCUPtr to keep track of items in the tree
rABC1cab8a4eb82a: [Radix] Use RCUPtr to keep track of items in the tree

Summary

This ensures that ownership can be shared in between the tree and its users, and ensures that elements gets cleaned up properly as all owners get rid of references to them.

The tree is steal leaking it's internal nodes on destructions.

Depends on D2336, D2351 and D2352

Test Plan

Added test cases.

Diff Detail

Repository

rABC Bitcoin ABC

Branch

radixfree

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 4655
Build 7373: Bitcoin ABC Buildbot (legacy)
Build 7372: arc lint + arc unit

Event Timeline

deadalnix created this revision.Jan 21 2019, 16:55

Herald added a reviewer: Restricted Project. · View Herald TranscriptJan 21 2019, 16:56

Herald added a subscriber: schancel. · View Herald Transcript

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing started.

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing failed.

Harbormaster failed remote builds in B4617: Diff 6787!Jan 21 2019, 17:01

Remove call to synchronize now that it is not needed as we use RCUPtr.

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing started.

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing failed.

Harbormaster failed remote builds in B4628: Diff 6803!Jan 22 2019, 02:23

deadalnix added a child revision: D2385: [Radix] Have the radix tree cleanup after itself.Jan 22 2019, 19:09

Rebase on top of patches using the NULLPTR trick to make old versions of boost happy.

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing started.

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing failed.

Harbormaster failed remote builds in B4655: Diff 6852!Jan 23 2019, 00:26

rebase

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing started.

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing failed.

Harbormaster failed remote builds in B4686: Diff 6900!Jan 24 2019, 13:30

rebase

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing started.

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing passed.

Harbormaster completed remote builds in B4757: Diff 7010.Jan 30 2019, 02:24

Fabien requested changes to this revision.Jan 30 2019, 07:37

Fabien added a subscriber: Fabien.

Fabien added inline comments.

src/test/radix_tests.cpp
291 ↗	(On Diff #7010)	Why `!!` ? Is this an operator I'm not aware of, or a double negation ?
src/test/rcu_tests.cpp
147 ↗	(On Diff #7010)	Why do you need this ? It seems unrelated to the other parts of the diff

This revision now requires changes to proceed.Jan 30 2019, 07:37

deadalnix requested review of this revision.Jan 30 2019, 20:04

deadalnix added inline comments.

src/test/radix_tests.cpp
291 ↗	(On Diff #7010)	It is a double negation. It's a common way to force bool conversion.
src/test/rcu_tests.cpp
147 ↗	(On Diff #7010)	The cleanup queue is not going to clear itself up.

Fabien accepted this revision.Jan 31 2019, 08:30

This revision is now accepted and ready to land.Jan 31 2019, 08:30

Closed by commit rABC1cab8a4eb82a: [Radix] Use RCUPtr to keep track of items in the tree (authored by deadalnix). · Explain WhyJan 31 2019, 12:20

This revision was automatically updated to reflect the committed changes.

deadalnix added a commit: rSTAGING1cab8a4eb82a: [Radix] Use RCUPtr to keep track of items in the tree.Sep 18 2019, 22:11

[Radix] Use RCUPtr to keep track of items in the tree
ClosedPublic
Actions

Details

Diff Detail

Event Timeline

Revision Contents
Changeset List

Diff 6852

src/radix.h

src/test/radix_tests.cpp

src/test/rcu_tests.cpp

[Radix] Use RCUPtr to keep track of items in the treeClosedPublicActions

Details

Diff Detail

Event Timeline

Revision ContentsChangeset List

Diff 6852

src/radix.h

src/test/radix_tests.cpp

src/test/rcu_tests.cpp

[Radix] Use RCUPtr to keep track of items in the tree
ClosedPublic
Actions

Revision Contents
Changeset List