Differential D2410

Fix code style in keystore.cpp/crypter.cpp
AbandonedPublic
Actions

Authored by Fabien on Jan 24 2019, 14:43.

Details

Reviewers

deadalnix

Group Reviewers

Restricted Project

Summary

Only changes from the PR are backported. Another pass is needed to
remove the remaining nits.

Partial backport of core PR11272 (commit dd9bb25)

Depends on D2408

Test Plan

make check

Diff Detail

Repository

rABC Bitcoin ABC

Branch

PR11272_part2

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 4690
Build 7443: Bitcoin ABC Buildbot (legacy)
Build 7442: arc lint + arc unit

Event Timeline

Fabien created this revision.Jan 24 2019, 14:43

Herald added a reviewer: Restricted Project. · View Herald TranscriptJan 24 2019, 14:43

Herald added a reviewer: deadalnix. · View Herald Transcript

Herald added a subscriber: schancel. · View Herald Transcript

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing started.

deadalnix requested changes to this revision.Jan 24 2019, 14:53

deadalnix added inline comments.

src/wallet/crypter.cpp
163	It would be preferable to not introduce code with broken style and then fix it. Please fix these in the parent diff and then rebase.

This revision now requires changes to proceed.Jan 24 2019, 14:53

Fabien abandoned this revision.Jan 24 2019, 14:54

Fabien mentioned this in D2408: CKeystore/CCrypter: move relevant implementation out of the header.

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing passed.

Harbormaster completed remote builds in B4690: Diff 6904.Jan 24 2019, 14:58

Revision Contents
Changeset List

Path

Size

src/

keystore.cpp

12 lines

wallet/

crypter.cpp

118 lines

Diff 6904

View Options

src/keystore.cpp