Page MenuHomePhabricator
Differential D2352

[RCU] Make RCUPtr compatible with const payloads.
ClosedPublic
Actions

Authored by deadalnix on Jan 20 2019, 22:16.

Details

Reviewers
Fabien
Group Reviewers
Restricted Project
Commits
rSTAGINGfa427697cba8: [RCU] Make RCUPtr compatible with const payloads.
rABCfa427697cba8: [RCU] Make RCUPtr compatible with const payloads.
Summary

As per title.

Depends on D2350

Test Plan

Added tests cases.

Diff Detail

Repository
rABC Bitcoin ABC
Branch
rcuptrconst
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 4756
Build 7575: Bitcoin ABC Buildbot (legacy)
Build 7574: arc lint + arc unit

Event Timeline

deadalnix created this revision.Jan 20 2019, 22:16
Herald added a reviewer: Restricted Project. · View Herald TranscriptJan 20 2019, 22:16
Herald added a subscriber: schancel. · View Herald Transcript
teamcity added a subscriber: teamcity.Jan 20 2019, 22:18

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing started.

teamcity added a comment.Jan 20 2019, 22:22

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing failed.

Harbormaster failed remote builds in B4596: Diff 6765!Jan 20 2019, 22:22
deadalnix added a child revision: D2371: [Radix] Use RCUPtr to keep track of items in the tree.Jan 21 2019, 16:55
Fabien requested changes to this revision.Jan 28 2019, 19:56
Fabien added a subscriber: Fabien.

Code looks good, could you rebase on top of the boost NULL_PTR() workaround to make it build ?

This revision now requires changes to proceed.Jan 28 2019, 19:56
deadalnix updated this revision to Diff 6991.Jan 29 2019, 19:04

rebase

teamcity added a comment.Jan 29 2019, 19:05

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing started.

teamcity added a comment.Jan 29 2019, 19:12

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing failed.

Harbormaster failed remote builds in B4742: Diff 6991!Jan 29 2019, 19:12
deadalnix updated this revision to Diff 6999.Jan 29 2019, 20:50

rerebase

teamcity added a comment.Jan 29 2019, 20:50

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing started.

teamcity added a comment.Jan 29 2019, 21:05

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing passed.

Harbormaster completed remote builds in B4750: Diff 6999.Jan 29 2019, 21:05
deadalnix updated this revision to Diff 7007.Jan 29 2019, 23:29

rerebase

teamcity added a comment.Jan 29 2019, 23:30

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing started.

teamcity added a comment.Jan 29 2019, 23:43

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing passed.

Harbormaster completed remote builds in B4756: Diff 7007.Jan 29 2019, 23:43
Fabien accepted this revision.Jan 30 2019, 07:21
This revision is now accepted and ready to land.Jan 30 2019, 07:21
Closed by commit rABCfa427697cba8: [RCU] Make RCUPtr compatible with const payloads. (authored by deadalnix). · Explain WhyJan 30 2019, 13:30
This revision was automatically updated to reflect the committed changes.
deadalnix added a commit: rSTAGINGfa427697cba8: [RCU] Make RCUPtr compatible with const payloads..Sep 18 2019, 22:09

Revision Contents
Changeset List

PathSize
src/
8 lines
test/
11 lines

Diff 7007

View Options

src/rcu.h

Loading...
View Options

src/test/rcu_tests.cpp

Loading...