Page MenuHomePhabricator
Differential D2482

fix ineffective checkdatasig_tests
ClosedPublic
Actions

Authored by markblundeberg on Feb 2 2019, 15:37.

Details

Reviewers
deadalnix
Group Reviewers
Restricted Project
Commits
rSTAGING6bcf11b84499: fix ineffective checkdatasig_tests
rABC6bcf11b84499: fix ineffective checkdatasig_tests
Summary

These tests were totally broken:

  • Only did 1 iteration because it set flags |= ENABLE_CHECKDATASIG at start
  • Wasn't aware of SCRIPT_VERIFY_COMPRESSED_PUBKEYTYPE
  • Missed some SCRIPT_VERIFY_NULLFAIL cases

Also I changed it to use pseudorandom flags generator since the original intent of 262000 iterations would have been way way too slow anyway. Runtime is now ~3 sec, would have been 3 minutes (dominating test_bitcoin runtime) if original iter count ever actually worked.

Test Plan

test_bitcoin

Diff Detail

Repository
rABC Bitcoin ABC
Branch
fix_cds_tests
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 4838
Build 7739: Bitcoin ABC Buildbot (legacy)
Build 7738: arc lint + arc unit

Event Timeline

markblundeberg created this revision.Feb 2 2019, 15:37
Herald added a reviewer: Restricted Project. · View Herald TranscriptFeb 2 2019, 15:37
Herald added a reviewer: deadalnix. · View Herald Transcript
Herald added a subscriber: schancel. · View Herald Transcript
teamcity added a subscriber: teamcity.Feb 2 2019, 15:38

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing started.

deadalnix requested changes to this revision.Feb 2 2019, 15:43

Some minor changes, but overall LGTM.

src/test/checkdatasig_tests.cpp
48 ↗(On Diff #7121)

Keep the check equal.

50 ↗(On Diff #7121)

Do not try to format tthese is specific format, especially not with colors.

63 ↗(On Diff #7121)

dito

This revision now requires changes to proceed.Feb 2 2019, 15:43
markblundeberg updated this revision to Diff 7122.Feb 2 2019, 15:49
markblundeberg marked 2 inline comments as done.

remove custom messaging

markblundeberg marked an inline comment as done.Feb 2 2019, 15:49
teamcity added a comment.Feb 2 2019, 15:49

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing started.

teamcity added a comment.Feb 2 2019, 15:53

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing passed.

Harbormaster completed remote builds in B4837: Diff 7121.Feb 2 2019, 15:53
teamcity added a comment.Feb 2 2019, 16:04

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing passed.

Harbormaster completed remote builds in B4838: Diff 7122.Feb 2 2019, 16:04
deadalnix accepted this revision.Feb 2 2019, 16:06
This revision is now accepted and ready to land.Feb 2 2019, 16:06
Closed by commit rABC6bcf11b84499: fix ineffective checkdatasig_tests (authored by Mark Lundeberg <36528214+markblundeberg@users.noreply.github.com>). · Explain WhyFeb 2 2019, 16:17
This revision was automatically updated to reflect the committed changes.
Mark Lundeberg <36528214+markblundeberg@users.noreply.github.com> added a commit: rSTAGING6bcf11b84499: fix ineffective checkdatasig_tests.Sep 18 2019, 22:13
markblundeberg mentioned this in D4671: fix incomplete txvalidationcache_tests.Dec 9 2019, 20:59
Mark Lundeberg <markblundeberg@users.noreply.github.com> mentioned this in rABC6516515d7bbb: fix incomplete txvalidationcache_tests.Dec 10 2019, 20:24
Mark Lundeberg <markblundeberg@users.noreply.github.com> mentioned this in rSTAGING6516515d7bbb: fix incomplete txvalidationcache_tests.Apr 7 2020, 22:01

Revision Contents
Changeset List

PathSize
src/
test/
81 lines

Diff 7122

View Options

src/test/checkdatasig_tests.cpp

Loading...