With the scripts being renamed, it could be interesting to allow for
specifying a category of functional tests to run. This diff adds
support for a trailing wildcard in the name given to test_runner.py. For
example, all the abc functional tests can be run with
./test/functional/test_runner.py abc-*
Details
Details
- Reviewers
deadalnix - Group Reviewers
Restricted Project - Commits
- rSTAGINGd0ca5336f4cb: Make test_runner.py scripts argument accept wildcard
rABCd0ca5336f4cb: Make test_runner.py scripts argument accept wildcard
Run all the abc functional tests
./test/functional/test_runner.py abc-*
Check all the tests are run
Run:
./test/functional/test_runner.py interface_* interface_zmq
Check that the interface_zmq test is not run twice
Diff Detail
Diff Detail
- Repository
- rABC Bitcoin ABC
- Branch
- test_runner_wildcard
- Lint
Lint Passed - Unit
No Test Coverage - Build Status
Buildable 4859 Build 7781: Bitcoin ABC Buildbot (legacy) Build 7780: arc lint + arc unit
Event Timeline
| test/functional/test_runner.py | ||
|---|---|---|
| 227 | This will not simply remove extension. It breaks existing semantic, and frankly, for no good reasons. | |
Comment Actions
This shows all the sign of code that has been banged on until it more or less passes some smoke test.
The '.py$' being removed from various places. The argument passed being kind of regex kind of not. This code has not been designed in any way, it just happen to work in some specific case.
Comment Actions
Complete re-design:
- Focus on the use case: only accept wildcard at the end
- Avoid side effects by not using regex
| test/functional/test_runner.py | ||
|---|---|---|
| 234 ↗ | (On Diff #7448) | fnmatch.translate seems like a good candidate for what you are trying to do here. |