Page MenuHomePhabricator

Add additional test in segwit recovery activation
ClosedPublic

Authored by florian on Apr 10 2019, 22:48.

Details

Reviewers
deadalnix
Group Reviewers
Restricted Owners Package(Owns No Changed Paths)
Restricted Project
Commits
rSTAGING5e3527194d8a: Add additional test in segwit recovery activation
rABC5e3527194d8a: Add additional test in segwit recovery activation
Summary

Add a new test case to ensure nodes won't ban each other before and after activation.

Test Plan

./test_runner abc-segwit-recovery-activation.py

Diff Detail

Repository
rABC Bitcoin ABC
Branch
swrecovery2
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 5432
Build 8926: Bitcoin ABC Buildbot (legacy)
Build 8925: arc lint + arc unit

Event Timeline

Owners added a reviewer: Restricted Owners Package.Apr 10 2019, 22:48
test/functional/abc-segwit-recovery-activation.py
341

I moved this check before the sendrawtransaction call to avoid a race condition. The previous version could fail if node_nonstd, after sendrawtransaction, sent the segwit spending txn to node_std *before* we did this check. In this case, the transaction would be included in recentRejects and node_std would never send the REJECT message back to the mininode.

deadalnix requested changes to this revision.Apr 10 2019, 22:57

The purpose of this test is to test activation. This isn't the right place for test vectors.

This revision now requires changes to proceed.Apr 10 2019, 22:57

OK the goal is to check for bans when the error is EVAL_FALSE.

This revision is now accepted and ready to land.Apr 10 2019, 23:18
This revision was automatically updated to reflect the committed changes.