[qt] Avoid potential null pointer dereference in TransactionView::exportClicked()
ClosedPublic
Actions

Authored by jasonbcox on Apr 24 2019, 20:46.

Details

Reviewers

deadalnix
Fabien

Group Reviewers

Restricted Project

Commits

rSTAGING370d6146a348: [qt] Avoid potential null pointer dereference in TransactionView::exportClicked…
rABC370d6146a348: [qt] Avoid potential null pointer dereference in TransactionView::exportClicked…

Summary

Backport of Core PR 10673
https://github.com/bitcoin/bitcoin/pull/10673/commits/fd9599b1358a314b073a9ca0a68ca8037915d91d

Test Plan

make check
bitcoin-qt # sanity checks on export transaction history

Diff Detail

Repository

rABC Bitcoin ABC

Branch

pr10673

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 5594
Build 9250: Bitcoin ABC Buildbot (legacy)
Build 9249: arc lint + arc unit

Event Timeline

jasonbcox created this revision.Apr 24 2019, 20:46

Herald added a reviewer: Restricted Project. · View Herald TranscriptApr 24 2019, 20:46

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing started.

jasonbcox added a child revision: D2876: [qt] Simplifies boolean expression model && model->haveWatchOnly().Apr 24 2019, 20:48

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing passed.

Harbormaster completed remote builds in B5594: Diff 8260.Apr 24 2019, 21:00

Fabien accepted this revision.Apr 25 2019, 06:29

This revision is now accepted and ready to land.Apr 25 2019, 06:29

Closed by commit rABC370d6146a348: [qt] Avoid potential null pointer dereference in TransactionView::exportClicked… (authored by practicalswift <practicalswift@users.noreply.github.com>, committed by jasonbcox). · Explain WhyApr 25 2019, 15:37

This revision was automatically updated to reflect the committed changes.

jasonbcox added a commit: rSTAGING370d6146a348: [qt] Avoid potential null pointer dereference in TransactionView::exportClicked….Sep 18 2019, 23:08

Revision Contents
Changeset List

Path

Size

src/

qt/

transactionview.cpp

4 lines

Diff 8260

View Options

src/qt/transactionview.cpp

[qt] Avoid potential null pointer dereference in TransactionView::exportClicked()ClosedPublicActions