Page MenuHomePhabricator

[LINTER] Improve lint-format-strings.sh performance
ClosedPublic

Authored by Fabien on Apr 26 2019, 14:03.

Details

Summary

The mapfile line originates from the initial script version which
worked on all files. It is no longer needed as arcanist passes each file
individually as an argument.

The performance has been mesured by running arc lint --everything with
this single linter enabled; the gain is about 20% on my machine.

Test Plan
arc lint --everything

Should return no error

Comment one of the false positive at the beginning of the
lint-format-strings.py file.
Add a comment in the file from the commented false positive.

arc lint

The false positive should be catched by the linter.

Diff Detail

Repository
rABC Bitcoin ABC
Branch
lint_format_string_performance_improve
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 5610
Build 9282: Bitcoin ABC Buildbot (legacy)
Build 9281: arc lint + arc unit

Event Timeline

Add newline at end of line

This revision is now accepted and ready to land.Apr 29 2019, 17:57
This revision was automatically updated to reflect the committed changes.