Page MenuHomePhabricator
Differential D2960

Merge #10489: build: silence gcc7's implicit fallthrough warning
ClosedPublic
Actions

Authored by jasonbcox on May 7 2019, 02:52.

Details

Reviewers
deadalnix
Fabien
Group Reviewers
Restricted Project
Commits
rSTAGING3bd53249b037: Merge #10489: build: silence gcc7's implicit fallthrough warning
rABC3bd53249b037: Merge #10489: build: silence gcc7's implicit fallthrough warning
Summary

cf390df build: silence gcc7's implicit fallthrough warning (Cory Fields)

Tree-SHA512: 330a4258161529c6e7af34ba3dc9703c24d897d7fff317c078441405c4546c7236e260603181001954b214d4640ad09ed3d34d3b518be991cb1712a02bcaa1d9

Backport of Core PR10489
https://github.com/bitcoin/bitcoin/pull/10489/files
I noticed these fallthrough warnings appearing repeatedly due to tinyformat as the original PR describes.
Although I don't 100% agree that it is good to always silence this warning, it is proving to add
cognitive load when digging through real build error messages. I'll leave this diff up for discussion.

Test Plan
make # no longer vomits warnings related to fallthrough
ninja # does not show fallthrough warnings
cmake -GNinja -DEXTRA_WARNINGS=1 ..
ninja # vomits fallthrough warnings as expected

Diff Detail

Repository
rABC Bitcoin ABC
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

jasonbcox created this revision.May 7 2019, 02:52
Herald added a reviewer: Restricted Project. · View Herald TranscriptMay 7 2019, 02:52
teamcity added a comment.May 7 2019, 02:54

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing started.

teamcity added a comment.May 7 2019, 03:07

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing passed.

Harbormaster completed remote builds in B5719: Diff 8447.May 7 2019, 03:07
Fabien requested changes to this revision.May 7 2019, 07:04

Can you also add it to src/CMakeLists.txt ?

This revision now requires changes to proceed.May 7 2019, 07:04
jasonbcox edited the summary of this revision. (Show Details)May 9 2019, 00:15
jasonbcox updated this revision to Diff 8537.May 9 2019, 00:25

Rebase + added to CMake build

teamcity added a comment.May 9 2019, 00:26

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing started.

jasonbcox edited the test plan for this revision. (Show Details)May 9 2019, 00:27
teamcity added a comment.May 9 2019, 00:40

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing passed.

Harbormaster completed remote builds in B5771: Diff 8537.May 9 2019, 00:40
Fabien requested changes to this revision.May 9 2019, 06:35
Fabien added inline comments.
src/CMakeLists.txt
92 ↗(On Diff #8537)

We want to remove it because it is part of Wextra since gcc7. No need to enable it first.

This revision now requires changes to proceed.May 9 2019, 06:35
jasonbcox updated this revision to Diff 8553.May 9 2019, 16:07

Removed enabling implicit-fallthrough as the default

teamcity added a comment.May 9 2019, 16:08

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing started.

Fabien accepted this revision.May 9 2019, 16:13
This revision is now accepted and ready to land.May 9 2019, 16:13
teamcity added a comment.May 9 2019, 16:22

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing passed.

Harbormaster completed remote builds in B5781: Diff 8553.May 9 2019, 16:22
Closed by commit rABC3bd53249b037: Merge #10489: build: silence gcc7's implicit fallthrough warning (authored by Wladimir J. van der Laan <laanwj@gmail.com>, committed by jasonbcox). · Explain WhyMay 9 2019, 17:41
This revision was automatically updated to reflect the committed changes.
jasonbcox added a commit: rSTAGING3bd53249b037: Merge #10489: build: silence gcc7's implicit fallthrough warning.Sep 18 2019, 23:26

Revision Contents
Changeset List

PathSize
1 line
src/
1 line

Diff 8564

View Options

configure.ac

Loading...
View Options

src/CMakeLists.txt

Loading...