Ensure config is resetted with each tests.
ClosedPublic
Actions

Authored by deadalnix on Jul 20 2017, 11:37.

Details

Reviewers

Group Reviewers

Restricted Project

Commits

rSTAGING81dc539bcb39: Ensure config is resetted with each tests.
rABC81dc539bcb39: Ensure config is resetted with each tests.

Summary

This fixes problems where there are leftover cofngis from other tests.

The long term plan would be to make sure the config is not a global singleton but we are not there yet.

Test Plan

./src/test/test_bitcoin --random=13174

Diff Detail

Repository

rABC Bitcoin ABC

Branch

testdefault

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 544
Build 544: arc lint + arc unit

Event Timeline

deadalnix created this revision.Jul 20 2017, 11:37

Herald added a reviewer: Restricted Project. · View Herald TranscriptJul 20 2017, 11:37

Harbormaster completed remote builds in B544: Diff 876.Jul 20 2017, 11:37

freetrader accepted this revision.Jul 20 2017, 11:45

freetrader added inline comments.

src/test/test_bitcoin.cpp
51	typo: parameters

This revision is now accepted and ready to land.Jul 20 2017, 11:45

Note about test plan random seed:

A particular seed may usually be assumed to be effective at reproducing a problem only for a particular build configuration, and often only on particular installation (machine + OS).
Unless there is something magical about '13174' ?

Closed by commit rABC81dc539bcb39: Ensure config is resetted with each tests. (authored by deadalnix, committed by deadalnix). · Explain WhyJul 20 2017, 11:57

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

src/

test/

test_bitcoin.cpp

12 lines

Diff 876

View Options

Ensure config is resetted with each tests.ClosedPublicActions