Improve testing for the difficulty adjustment algorithm.
ClosedPublic
Actions

Authored by deadalnix on Jul 20 2017, 14:42.

Details

Reviewers

kyuupichan
freetrader

Group Reviewers

Restricted Project

Commits

rSTAGING3b0325f2626e: Improve testing for the difficulty adjustment algorithm.
rABC3b0325f2626e: Improve testing for the difficulty adjustment algorithm.

Summary

It now tests that we plateau at the minimal pow limit.

Test Plan

make check

Diff Detail

Repository

rABC Bitcoin ABC

Branch

powtest

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 547
Build 547: arc lint + arc unit

Event Timeline

deadalnix created this revision.Jul 20 2017, 14:42

Herald added a reviewer: Restricted Project. · View Herald TranscriptJul 20 2017, 14:42

freetrader requested changes to this revision.Jul 20 2017, 17:23

freetrader added a subscriber: freetrader.

freetrader added inline comments.

src/test/pow_tests.cpp
172 ↗	(On Diff #882)	typos: below (more than 1 occurrence in this file) minimal

This revision now requires changes to proceed.Jul 20 2017, 17:23

and it should be " adjustment" in the title.

Code changes look ok to me, but still need to test.

Fix typos

Harbormaster completed remote builds in B547: Diff 883.Jul 20 2017, 17:41

deadalnix retitled this revision from Improve testing for the difficulty adjustement algorithm. to Improve testing for the difficulty adjustment algorithm..Jul 20 2017, 17:41

Tested ok

This revision is now accepted and ready to land.Jul 20 2017, 17:48

Closed by commit rABC3b0325f2626e: Improve testing for the difficulty adjustment algorithm. (authored by deadalnix, committed by deadalnix). · Explain WhyJul 20 2017, 17:58

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

src/

test/

pow_tests.cpp

65 lines

Diff 883

View Options

Improve testing for the difficulty adjustment algorithm.ClosedPublicActions