Page MenuHomePhabricator
Differential D3104

Allow wallet files not in -walletdir directory
ClosedPublic
Actions

Authored by Fabien on May 24 2019, 14:09.

Details

Reviewers
deadalnix
Group Reviewers
Restricted Project
Commits
rSTAGING9d25e4bfaf86: Allow wallet files not in -walletdir directory
rABC9d25e4bfaf86: Allow wallet files not in -walletdir directory
Summary
Remove restriction that -wallet filenames can only refer to files in the
-walletdir directory.

Partial backport of core PR11687 (commit 26c06f2)
https://github.com/bitcoin/bitcoin/pull/11687/commits/26c06f24e5dcc32a7599abb8d670d22993c82bc2

Depends on D3103
Progress towards T651

Test Plan
make check
./test/functional/test_runner.py wallet_multiwallet

Diff Detail

Repository
rABC Bitcoin ABC
Branch
PR11687_part2
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 6015
Build 10089: Bitcoin ABC Buildbot (legacy)
Build 10088: arc lint + arc unit

Event Timeline

Fabien created this revision.May 24 2019, 14:09
Herald added a reviewer: Restricted Project. · View Herald TranscriptMay 24 2019, 14:09
Herald added a reviewer: deadalnix. · View Herald Transcript
teamcity added a comment.May 24 2019, 14:10

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing started.

Fabien added a child revision: D3105: Create new wallet databases as directories rather than files.May 24 2019, 14:13
Harbormaster completed remote builds in B5968: Diff 8848.May 24 2019, 14:24
teamcity added a comment.May 24 2019, 14:24

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing passed.

Fabien updated this revision to Diff 8928.May 27 2019, 15:59

Rebase

teamcity added a comment.May 27 2019, 16:00

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing started.

teamcity added a comment.May 27 2019, 16:14

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing passed.

Harbormaster completed remote builds in B6015: Diff 8928.May 27 2019, 16:14
deadalnix requested changes to this revision.May 27 2019, 21:43

Fix the release notes.

This revision now requires changes to proceed.May 27 2019, 21:43
Fabien updated this revision to Diff 8952.May 28 2019, 09:28

Restore the original PR layout in release notes.

teamcity added a comment.May 28 2019, 09:29

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing started.

teamcity added a comment.May 28 2019, 09:43

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing passed.

Harbormaster completed remote builds in B6032: Diff 8952.May 28 2019, 09:43
deadalnix accepted this revision.May 28 2019, 15:24
This revision is now accepted and ready to land.May 28 2019, 15:24
Closed by commit rABC9d25e4bfaf86: Allow wallet files not in -walletdir directory (authored by Russell Yanofsky <russ@yanofsky.org>, committed by Fabien). · Explain WhyMay 28 2019, 15:55
This revision was automatically updated to reflect the committed changes.
Fabien added a commit: rABC9d25e4bfaf86: Allow wallet files not in -walletdir directory.
Fabien added a commit: rSTAGING9d25e4bfaf86: Allow wallet files not in -walletdir directory.Sep 18 2019, 23:51

Revision Contents
Changeset List

PathSize
doc/
5 lines
src/
10 lines
wallet/
1 line
24 lines
test/
functional/
61 lines

Diff 8928

View Options

doc/release-notes.md

Loading...
View Options

src/bitcoin-cli.cpp

Loading...
View Options

src/wallet/db.cpp

Loading...
View Options

src/wallet/init.cpp

Loading...
View Options

test/functional/wallet_multiwallet.py

Loading...