Page MenuHomePhabricator

Allow wallet files in multiple directories
ClosedPublic

Authored by Fabien on Fri, May 24, 14:06.

Details

Reviewers
deadalnix
Group Reviewers
Restricted Project
Commits
rABCf00d8bc7e0e5: Allow wallet files in multiple directories
Summary
Remove requirement that two wallet files can only be opened at the same
time if
they are contained in the same directory.

This change mostly consists of updates to function signatures (updating
functions to take fs::path arguments, instead of combinations of
strings,
fs::path, and CDBEnv / CWalletDBWrapper arguments).

Partial backport of core PR11687 (commit d8a99f6)
https://github.com/bitcoin/bitcoin/pull/11687/commits/d8a99f65e53019becdd8d2631396012bafb29741#diff-5ddca6879fe54b576a2fc4598d9f29ce

Depends on D3102
Progress towards T651

Test Plan
make check
./test/functional/test_runner.py wallet_*

Diff Detail

Repository
rABC Bitcoin ABC
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

Fabien created this revision.Fri, May 24, 14:06
Herald added a reviewer: Restricted Project. · View Herald TranscriptFri, May 24, 14:06
Fabien updated this revision to Diff 8927.Mon, May 27, 15:59

Rebase

deadalnix requested changes to this revision.Mon, May 27, 16:38
deadalnix added inline comments.
src/wallet/test/wallet_tests.cpp
45 ↗(On Diff #8927)

There is something missing here, meaning you have missing dependency, and you must know it because you also must have got a merge conflict.

This revision now requires changes to proceed.Mon, May 27, 16:38
Fabien requested review of this revision.Mon, May 27, 18:24
Fabien added inline comments.
src/wallet/test/wallet_tests.cpp
45 ↗(On Diff #8927)

If you're talking about static const CWallet testWallet("dummy", CWalletDBWrapper::CreateDummy());, the static test wallet has been removed in https://reviews.bitcoinabc.org/D1079, thus not reintroduced here.

If you prefer to abandon ownership of this code this can be rolled back, but is out of scope for this PR.

deadalnix accepted this revision.Mon, May 27, 20:51
This revision is now accepted and ready to land.Mon, May 27, 20:51
This revision was automatically updated to reflect the committed changes.