Page MenuHomePhabricator

Allow wallet files in multiple directories

Authored by Fabien on May 24 2019, 14:06.


Remove requirement that two wallet files can only be opened at the same
time if
they are contained in the same directory.

This change mostly consists of updates to function signatures (updating
functions to take fs::path arguments, instead of combinations of
fs::path, and CDBEnv / CWalletDBWrapper arguments).

Partial backport of core PR11687 (commit d8a99f6)

Depends on D3102
Progress towards T651

Test Plan
make check
./test/functional/ wallet_*

Diff Detail

rABC Bitcoin ABC
Automatic diff as part of commit; lint not applicable.
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

Fabien created this revision.May 24 2019, 14:06
Herald added a reviewer: Restricted Project. · View Herald TranscriptMay 24 2019, 14:06
Fabien updated this revision to Diff 8927.May 27 2019, 15:59


deadalnix requested changes to this revision.May 27 2019, 16:38
deadalnix added inline comments.
45 ↗(On Diff #8927)

There is something missing here, meaning you have missing dependency, and you must know it because you also must have got a merge conflict.

This revision now requires changes to proceed.May 27 2019, 16:38
Fabien requested review of this revision.May 27 2019, 18:24
Fabien added inline comments.
45 ↗(On Diff #8927)

If you're talking about static const CWallet testWallet("dummy", CWalletDBWrapper::CreateDummy());, the static test wallet has been removed in, thus not reintroduced here.

If you prefer to abandon ownership of this code this can be rolled back, but is out of scope for this PR.

deadalnix accepted this revision.May 27 2019, 20:51
This revision is now accepted and ready to land.May 27 2019, 20:51
This revision was automatically updated to reflect the committed changes.