Page MenuHomePhabricator
Differential D3222

Merge #10679: Document the non-DER-conformance of one test in tx_valid.json.
ClosedPublic
Actions

Authored by jasonbcox on Jun 5 2019, 22:11.

Details

Reviewers
deadalnix
Fabien
Group Reviewers
Restricted Project
Commits
rSTAGING4503331d03a7: Merge #10679: Document the non-DER-conformance of one test in tx_valid.json.
rABC4503331d03a7: Merge #10679: Document the non-DER-conformance of one test in tx_valid.json.
Summary

ecb11f5 Document the non-strict-DER-conformance of one test in tx_valid.json. (Andreas Schildbach)

Tree-SHA512: 4d5ba4645fbfe8fe3f1baaa5f1a1152cdd2cbf3d901f38d8e7fbd56b16caa6a8a17f2a48c74fb725ce454dd1c870b81b2238e89d0639fcd4eee858554726e996

Backport of Core PR10679
https://github.com/bitcoin/bitcoin/pull/10679/files

Test Plan

make check

Diff Detail

Repository
rABC Bitcoin ABC
Branch
pr10679
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 6170
Build 10388: Bitcoin ABC Buildbot (legacy)
Build 10387: arc lint + arc unit

Event Timeline

jasonbcox created this revision.Jun 5 2019, 22:11
Herald added a reviewer: deadalnix. · View Herald TranscriptJun 5 2019, 22:11
teamcity added a comment.Jun 5 2019, 22:11

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing started.

teamcity added a comment.Jun 5 2019, 22:21

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing passed.

Harbormaster completed remote builds in B6170: Diff 9175.Jun 5 2019, 22:21
Fabien accepted this revision.Jun 6 2019, 08:12
Fabien added a subscriber: Fabien.

I don't get how this has been merged in core. Merged to a forked project, then merged back into the main tree ?

This revision is now accepted and ready to land.Jun 6 2019, 08:12
jasonbcox added a comment.Jun 6 2019, 21:05

Looks like the commit was modified prior to merging.

Closed by commit rABC4503331d03a7: Merge #10679: Document the non-DER-conformance of one test in tx_valid.json. (authored by Wladimir J. van der Laan <laanwj@gmail.com>, committed by jasonbcox). · Explain WhyJun 6 2019, 21:06
This revision was automatically updated to reflect the committed changes.
jasonbcox added a commit: rABC4503331d03a7: Merge #10679: Document the non-DER-conformance of one test in tx_valid.json..
jasonbcox added a commit: rSTAGING4503331d03a7: Merge #10679: Document the non-DER-conformance of one test in tx_valid.json..Sep 19 2019, 00:06

Revision Contents
Changeset List

PathSize
src/
test/
data/
2 lines

Diff 9175

View Options

src/test/data/tx_valid.json

Loading...