[qa] util: Remove unused sync_chain
ClosedPublic
Actions

Authored by Fabien on Jun 7 2019, 15:26.

Details

Reviewers

deadalnix
jasonbcox

Group Reviewers

Restricted Project

Commits

rSTAGINGd4c2516b74c8: [qa] util: Remove unused sync_chain
rABCd4c2516b74c8: [qa] util: Remove unused sync_chain

Summary

The util function sync_blocks already checks for equal chains, so we can
remove the unused sync_chain.

Backport of core PR12643
https://github.com/bitcoin/bitcoin/pull/12643/files

Test Plan

./test/functional/test_runner.py

Diff Detail

Repository

rABC Bitcoin ABC

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

Fabien created this revision.Jun 7 2019, 15:26

Herald added a reviewer: Restricted Project. · View Herald TranscriptJun 7 2019, 15:26

Herald added a reviewer: deadalnix. · View Herald Transcript

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing started.

Harbormaster completed remote builds in B6214: Diff 9241.Jun 7 2019, 15:37

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing passed.

jasonbcox accepted this revision.Jun 7 2019, 17:47

This revision is now accepted and ready to land.Jun 7 2019, 17:47

Closed by commit rABCd4c2516b74c8: [qa] util: Remove unused sync_chain (authored by MarcoFalke <falke.marco@gmail.com>, committed by Fabien). · Explain WhyJun 8 2019, 13:47

This revision was automatically updated to reflect the committed changes.

Fabien added a commit: rABCd4c2516b74c8: [qa] util: Remove unused sync_chain.

Fabien added a commit: rSTAGINGd4c2516b74c8: [qa] util: Remove unused sync_chain.Sep 19 2019, 00:09

Revision Contents
Changeset List

Path

Size

test/

functional/

rpc_preciousblock.py

3 lines

test_framework/

util.py

47 lines

Diff 9253

View Options

test/functional/rpc_preciousblock.py