Page MenuHomePhabricator
Differential D3284

Merge #10404: doc: Add logging to FinalizeNode()
ClosedPublic
Actions

Authored by jasonbcox on Jun 10 2019, 21:30.

Details

Reviewers
deadalnix
Fabien
Group Reviewers
Restricted Project
Commits
rSTAGING504322bef4ed: Merge #10404: doc: Add logging to FinalizeNode()
rABC504322bef4ed: Merge #10404: doc: Add logging to FinalizeNode()
Summary

1530bfc Add logging to FinalizeNode() (Suhas Daftuar)

Tree-SHA512: 34bd950eb7830f378d069229c24122e97db68435b313f0de2c8772c2feefdc6db5f4d1f43eeade237ffe91cdef0f1cfe3232e1a37c561a65767f4527b2e2e370

Backport of Core PR10404

https://github.com/bitcoin/bitcoin/pull/10404/files

Test Plan

make check

Diff Detail

Repository
rABC Bitcoin ABC
Branch
pr10404
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 6258
Build 10563: Bitcoin ABC Buildbot (legacy)
Build 10562: arc lint + arc unit

Event Timeline

jasonbcox created this revision.Jun 10 2019, 21:30
Herald added a reviewer: deadalnix. · View Herald TranscriptJun 10 2019, 21:30
jasonbcox planned changes to this revision.Jun 10 2019, 21:30
teamcity added a comment.Jun 10 2019, 21:30

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing started.

jasonbcox requested review of this revision.Jun 10 2019, 21:31
jasonbcox edited the test plan for this revision. (Show Details)
teamcity added a comment.Jun 10 2019, 21:36

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing passed.

Harbormaster completed remote builds in B6258: Diff 9305.Jun 10 2019, 21:36
Fabien accepted this revision.Jun 11 2019, 05:52
This revision is now accepted and ready to land.Jun 11 2019, 05:52
Closed by commit rABC504322bef4ed: Merge #10404: doc: Add logging to FinalizeNode() (authored by Wladimir J. van der Laan <laanwj@gmail.com>, committed by jasonbcox). · Explain WhyJun 11 2019, 16:19
This revision was automatically updated to reflect the committed changes.
jasonbcox added a commit: rABC504322bef4ed: Merge #10404: doc: Add logging to FinalizeNode().
jasonbcox added a commit: rSTAGING504322bef4ed: Merge #10404: doc: Add logging to FinalizeNode().Sep 19 2019, 00:12
Fabien mentioned this in D11298: Remove duplicated (and misplaced) node disconnection logging.Apr 3 2022, 08:58
Fabien mentioned this in rABC26e7529b03ec: Remove duplicated (and misplaced) node disconnection logging.Apr 3 2022, 19:06

Revision Contents
Changeset List

PathSize
src/
1 line

Diff 9305

View Options

src/net_processing.cpp

Loading...