create net-specific data directory early in init process
ClosedPublic
Actions

Authored by markblundeberg on Jun 13 2019, 05:44.

Details

Reviewers

Fabien
deadalnix

Group Reviewers

Restricted Project

Commits

rSTAGINGe2c909027fbf: create net-specific data directory early in init process
rABCe2c909027fbf: create net-specific data directory early in init process

Summary

While backporting #14409 (D3076) I noticed a subtle bug: if
GetBlocksDir(true) is called prior to GetDataDir(true), then GetDataDir
will not create the .bitcoin/regtest/wallets directory, since GetDataDir
expects to be the first one to ever create the net-specific data directory.
This is a weird side-effect behaviour introduced in PR11466 (D2315).

This bug does not manifest on Core, by accident- during InitLogging they
indirectly call GetDataDir(true), and InitLogging happens to get called
before AppInitParameterInteraction (which calls GetBlocksDir).

Test Plan

make check
test_runner.py

Diff Detail

Repository

rABC Bitcoin ABC

Branch

patch

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 6301
Build 10649: Bitcoin ABC Buildbot (legacy)
Build 10648: arc lint + arc unit

Event Timeline

markblundeberg created this revision.Jun 13 2019, 05:44

Herald added a reviewer: Restricted Project. · View Herald TranscriptJun 13 2019, 05:44

Herald added a reviewer: deadalnix. · View Herald Transcript

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing started.

markblundeberg added a child revision: D3076: Merge #14409: utils and libraries: Make 'blocksdir' always net specific.Jun 13 2019, 05:45

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing passed.

Harbormaster completed remote builds in B6301: Diff 9375.Jun 13 2019, 05:50

add TODO comments to aid in clean backporting one day (when Core figures out
how they want to fix this)

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing started.

Discussions with @Fabien make it clear that this is pretty ugly behaviour, and I've forwarded this problem to Core to see if they have some solutions in mind. https://github.com/bitcoin/bitcoin/issues/16220

Fabien accepted this revision.Jun 15 2019, 18:21

This revision is now accepted and ready to land.Jun 15 2019, 18:21

Harbormaster completed remote builds in B6366: Diff 9475.Jun 15 2019, 18:21

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing passed.

Closed by commit rABCe2c909027fbf: create net-specific data directory early in init process (authored by Mark Lundeberg <36528214+markblundeberg@users.noreply.github.com>). · Explain WhyJun 15 2019, 19:20

This revision was automatically updated to reflect the committed changes.

Mark Lundeberg <36528214+markblundeberg@users.noreply.github.com> added a commit: rABCe2c909027fbf: create net-specific data directory early in init process.

Mark Lundeberg <36528214+markblundeberg@users.noreply.github.com> added a commit: rSTAGINGe2c909027fbf: create net-specific data directory early in init process.Sep 19 2019, 00:20