Page MenuHomePhabricator
Differential D3328

Take a CTransaction as argument for ValidateCheckInputsForAllFlags
ClosedPublic
Actions

Authored by deadalnix on Jun 13 2019, 22:48.

Details

Reviewers
jasonbcox
Group Reviewers
Restricted Project
Commits
rSTAGINGbd6817fcbf75: Take a CTransaction as argument for ValidateCheckInputsForAllFlags
rABCbd6817fcbf75: Take a CTransaction as argument for ValidateCheckInputsForAllFlags
Summary

As per title. This help to move toward Core PR12949.

Test Plan
make check

Diff Detail

Repository
rABC Bitcoin ABC
Branch
txvalidationtx
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 6325
Build 10697: Bitcoin ABC Buildbot (legacy)
Build 10696: arc lint + arc unit

Event Timeline

deadalnix created this revision.Jun 13 2019, 22:48
Herald added a reviewer: Restricted Project. · View Herald TranscriptJun 13 2019, 22:48
teamcity added a comment.Jun 13 2019, 22:49

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing started.

deadalnix updated this revision to Diff 9416.Jun 13 2019, 22:51

Remove unecessary copy

teamcity added a comment.Jun 13 2019, 22:52

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing started.

teamcity added a comment.Jun 13 2019, 22:55

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing passed.

Harbormaster completed remote builds in B6324: Diff 9415.Jun 13 2019, 22:55
teamcity added a comment.Jun 13 2019, 22:59

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing passed.

Harbormaster completed remote builds in B6325: Diff 9416.Jun 13 2019, 22:59
jasonbcox accepted this revision.Jun 14 2019, 00:50
jasonbcox retitled this revision from Take a CTransactiona s argument for ValidateCheckInputsForAllFlags to Take a CTransaction as argument for ValidateCheckInputsForAllFlags.
This revision is now accepted and ready to land.Jun 14 2019, 00:51
Closed by commit rABCbd6817fcbf75: Take a CTransaction as argument for ValidateCheckInputsForAllFlags (authored by deadalnix). · Explain WhyJun 14 2019, 13:25
This revision was automatically updated to reflect the committed changes.
deadalnix added a commit: rABCbd6817fcbf75: Take a CTransaction as argument for ValidateCheckInputsForAllFlags.
deadalnix added a commit: rSTAGINGbd6817fcbf75: Take a CTransaction as argument for ValidateCheckInputsForAllFlags.Sep 19 2019, 00:19

Revision Contents
Changeset List

PathSize
src/
test/
14 lines

Diff 9416

View Options

src/test/txvalidationcache_tests.cpp

Loading...