Page MenuHomePhabricator
Differential D3330

Directly use CMutableTransaction more often in txvaidationcache_tests.cpp
ClosedPublic
Actions

Authored by deadalnix on Jun 13 2019, 23:35.

Details

Reviewers
jasonbcox
Group Reviewers
Restricted Project
Commits
rSTAGINGdf7e2bdc4ea5: Directly use CMutableTransaction more often in txvaidationcache_tests.cpp
rABCdf7e2bdc4ea5: Directly use CMutableTransaction more often in txvaidationcache_tests.cpp
Summary

As per title. This help getting Core PR12949 merged.

Test Plan
make check

Diff Detail

Repository
rABC Bitcoin ABC
Branch
txvalidtestmutable
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 6341
Build 10729: Bitcoin ABC Buildbot (legacy)
Build 10728: arc lint + arc unit

Event Timeline

deadalnix created this revision.Jun 13 2019, 23:35
Herald added a reviewer: Restricted Project. · View Herald TranscriptJun 13 2019, 23:35
teamcity added a comment.Jun 13 2019, 23:35

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing started.

teamcity added a comment.Jun 13 2019, 23:41

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing passed.

Harbormaster completed remote builds in B6327: Diff 9418.Jun 13 2019, 23:41
jasonbcox accepted this revision.Jun 14 2019, 00:31
jasonbcox added a subscriber: jasonbcox.
jasonbcox added inline comments.
src/test/txvalidationcache_tests.cpp
179 ↗(On Diff #9418)

rebase this patch on D3314

This revision is now accepted and ready to land.Jun 14 2019, 00:31
deadalnix updated this revision to Diff 9441.Jun 14 2019, 13:39

Rebase

teamcity added a comment.Jun 14 2019, 13:40

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing started.

teamcity added a comment.Jun 14 2019, 13:49

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing passed.

Harbormaster completed remote builds in B6341: Diff 9441.Jun 14 2019, 13:49
Closed by commit rABCdf7e2bdc4ea5: Directly use CMutableTransaction more often in txvaidationcache_tests.cpp (authored by deadalnix). · Explain WhyJun 14 2019, 15:53
This revision was automatically updated to reflect the committed changes.
deadalnix added a commit: rABCdf7e2bdc4ea5: Directly use CMutableTransaction more often in txvaidationcache_tests.cpp.
deadalnix added a commit: rSTAGINGdf7e2bdc4ea5: Directly use CMutableTransaction more often in txvaidationcache_tests.cpp.Sep 19 2019, 00:19

Revision Contents
Changeset List

PathSize
src/
test/
62 lines

Diff 9441

View Options

src/test/txvalidationcache_tests.cpp

Loading...