Page MenuHomePhabricator
Differential D3360

Improve comment in top-level CMakeLists
ClosedPublic
Actions

Authored by jasonbcox on Jun 18 2019, 00:57.

Details

Reviewers
deadalnix
Fabien
Group Reviewers
Restricted Project
Commits
rSTAGING0d920cfa7d79: Improve comment in top-level CMakeLists
rABC0d920cfa7d79: Improve comment in top-level CMakeLists
Summary

See title.

Test Plan

Read it.

Diff Detail

Repository
rABC Bitcoin ABC
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

jasonbcox created this revision.Jun 18 2019, 00:57
Herald added a reviewer: deadalnix. · View Herald TranscriptJun 18 2019, 00:57
teamcity added a comment.Jun 18 2019, 00:57

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing started.

teamcity added a comment.Jun 18 2019, 01:08

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing passed.

Harbormaster completed remote builds in B6388: Diff 9510.Jun 18 2019, 01:08
Fabien accepted this revision.Jun 18 2019, 06:14
Fabien added a subscriber: Fabien.

Mind adding a couple entries to the lint/dictionary/english.json ? Under the exact rules:

"taret": "target",
"tagets": "targets",
This revision is now accepted and ready to land.Jun 18 2019, 06:14
jasonbcox updated this revision to Diff 9518.Jun 18 2019, 18:11

Added new entries to spellcheck

teamcity added a comment.Jun 18 2019, 18:11

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing started.

teamcity added a comment.Jun 18 2019, 18:17

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing passed.

Harbormaster completed remote builds in B6391: Diff 9518.Jun 18 2019, 18:17
Closed by commit rABC0d920cfa7d79: Improve comment in top-level CMakeLists (authored by jasonbcox). · Explain WhyJun 18 2019, 18:23
This revision was automatically updated to reflect the committed changes.
jasonbcox added a commit: rABC0d920cfa7d79: Improve comment in top-level CMakeLists.
jasonbcox added a commit: rSTAGING0d920cfa7d79: Improve comment in top-level CMakeLists.Sep 19 2019, 00:23

Revision Contents
Changeset List

PathSize
2 lines
test/
lint/
dictionary/
4 lines

Diff 9519

View Options

CMakeLists.txt

Loading...
View Options

test/lint/dictionary/english.json

Loading...