Page MenuHomePhabricator
Differential D3404

Fix inconsistencies and grammar in various files
ClosedPublic
Actions

Authored by Fabien on Jun 24 2019, 19:35.

Details

Reviewers
deadalnix
nakihito
Group Reviewers
Restricted Project
Commits
rSTAGINGdda80a8f977a: Fix inconsistencies and grammar in various files
rABCdda80a8f977a: Fix inconsistencies and grammar in various files
Summary

Backport of core PR10680
https://github.com/bitcoin/bitcoin/pull/10680/files

Test Plan

Read the docs.

arc lint --everything

Diff Detail

Repository
rABC Bitcoin ABC
Branch
PR10680
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 6464
Build 10975: Bitcoin ABC Buildbot (legacy)
Build 10974: arc lint + arc unit

Event Timeline

Fabien created this revision.Jun 24 2019, 19:35
Herald added a reviewer: Restricted Project. · View Herald TranscriptJun 24 2019, 19:35
Herald added a reviewer: deadalnix. · View Herald Transcript
teamcity added a comment.Jun 24 2019, 19:35

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing started.

Fabien added inline comments.Jun 24 2019, 19:37
contrib/bitcoin-cli.bash-completion
126

Note to reviewers: I didn't had senseful => sensible to the dictionary as senseful is a valid word according to various online dictionaries.

teamcity added a comment.Jun 24 2019, 19:44

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing passed.

Harbormaster completed remote builds in B6464: Diff 9629.Jun 24 2019, 19:44
nakihito accepted this revision.Jun 24 2019, 20:59
nakihito added a subscriber: nakihito.
nakihito added inline comments.
contrib/bitcoin-cli.bash-completion
126

In this case, sensible is correct.

This revision is now accepted and ready to land.Jun 24 2019, 20:59
Closed by commit rABCdda80a8f977a: Fix inconsistencies and grammar in various files (authored by MeshCollider <dobsonsa68@gmail.com>, committed by Fabien). · Explain WhyJun 25 2019, 05:59
This revision was automatically updated to reflect the committed changes.
Fabien added a commit: rABCdda80a8f977a: Fix inconsistencies and grammar in various files.
Fabien added a commit: rSTAGINGdda80a8f977a: Fix inconsistencies and grammar in various files.Sep 19 2019, 00:31

Revision Contents
Changeset List

PathSize
contrib/
2 lines
4 lines
2 lines
gitian/
6 lines
init/
4 lines
4 lines
rpm/
14 lines
doc/
12 lines
12 lines

Diff 9629

View Options

contrib/README.md

Loading...
View Options

contrib/bitcoin-cli.bash-completion

Loading...
View Options

contrib/bitcoind.bash-completion

Loading...
View Options

contrib/gitian/gitian-build.sh

Loading...
View Options

contrib/init/bitcoind.conf

Loading...
View Options

contrib/init/bitcoind.openrc

Loading...
View Options

contrib/rpm/README.md

Loading...
View Options

doc/REST-interface.md

Loading...
View Options

doc/gitian-signing.md

Loading...