Page MenuHomePhabricator
Differential D3410

Improve signmessages functional test
ClosedPublic
Actions

Authored by Fabien on Jun 25 2019, 10:25.

Details

Reviewers
deadalnix
Group Reviewers
Restricted Project
Commits
rSTAGING80a1fa6be168: Improve signmessages functional test
rABC80a1fa6be168: Improve signmessages functional test
Summary
This patch improves branch coverage of the test, making sure a
message can not be verified with the wrong address or signature.

Backport of core PR11241
https://github.com/bitcoin/bitcoin/pull/11241/files

Test Plan
./test/functional/test_runner.py rpc_signmessage

Diff Detail

Repository
rABC Bitcoin ABC
Branch
PR11241
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 6472
Build 10991: Bitcoin ABC Buildbot (legacy)
Build 10990: arc lint + arc unit

Event Timeline

Fabien created this revision.Jun 25 2019, 10:25
Herald added a reviewer: Restricted Project. · View Herald TranscriptJun 25 2019, 10:25
Herald added a reviewer: deadalnix. · View Herald Transcript
teamcity added a comment.Jun 25 2019, 10:25

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing started.

Fabien added inline comments.Jun 25 2019, 10:29
test/functional/rpc_signmessage.py
21

Note to reviewers: the signature differs due to the algorithm specific nonce data (algo16 parameter).

teamcity added a comment.Jun 25 2019, 10:31

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing passed.

Harbormaster completed remote builds in B6472: Diff 9643.Jun 25 2019, 10:31
deadalnix accepted this revision.Jun 25 2019, 15:43
This revision is now accepted and ready to land.Jun 25 2019, 15:43
Closed by commit rABC80a1fa6be168: Improve signmessages functional test (authored by Cristian Mircea Messel <mess110@gmail.com>, committed by Fabien). · Explain WhyJun 25 2019, 19:30
This revision was automatically updated to reflect the committed changes.
Fabien added a commit: rABC80a1fa6be168: Improve signmessages functional test.
Fabien added a commit: rSTAGING80a1fa6be168: Improve signmessages functional test.Sep 19 2019, 00:33

Revision Contents
Changeset List

PathSize
test/
functional/
23 lines

Diff 9643

View Options

test/functional/rpc_signmessage.py

Loading...