Page MenuHomePhabricator
Differential D3436

Fix concurrency-related bugs in ActivateBestChain
ClosedPublic
Actions

Authored by deadalnix on Jun 27 2019, 16:42.

Details

Reviewers
jasonbcox
Group Reviewers
Restricted Project
Commits
rSTAGING188c6ab4b8e5: Fix concurrency-related bugs in ActivateBestChain
rABC188c6ab4b8e5: Fix concurrency-related bugs in ActivateBestChain
Summary

If multiple threads are invoking ActivateBestChain, it was possible to have
them working towards different tips, and we could arrive at a less work tip
than we should. Fix this by introducing a ChainState lock which must
be held for the entire duration of ActivateBestChain to enforce
exclusion in ABC.

This is a partial backport of Core PR13023 : https://github.com/bitcoin/bitcoin/pull/13023/commits/a3ae8e68739023e5dba9e5cb190e707ed4603316

Depends on D3435

Test Plan
make check

Diff Detail

Repository
rABC Bitcoin ABC
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

deadalnix created this revision.Jun 27 2019, 16:42
Herald added a reviewer: Restricted Project. · View Herald TranscriptJun 27 2019, 16:42
teamcity added a comment.Jun 27 2019, 16:43

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing started.

deadalnix added a child revision: D3437: Add unit tests for signals generated by ProcessNewBlock().Jun 27 2019, 16:48
teamcity added a comment.Jun 27 2019, 16:53

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing passed.

Harbormaster completed remote builds in B6508: Diff 9718.Jun 27 2019, 16:53
deadalnix updated this revision to Diff 9763.Jun 28 2019, 14:09

Rebase

teamcity added a comment.Jun 28 2019, 14:09

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing started.

teamcity added a comment.Jun 28 2019, 14:20

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing passed.

Harbormaster completed remote builds in B6534: Diff 9763.Jun 28 2019, 14:20
jasonbcox accepted this revision.Jun 28 2019, 16:39
This revision is now accepted and ready to land.Jun 28 2019, 16:39
Closed by commit rABC188c6ab4b8e5: Fix concurrency-related bugs in ActivateBestChain (authored by Jesse Cohen <jc@jc.lol>, committed by deadalnix). · Explain WhyJun 29 2019, 21:16
This revision was automatically updated to reflect the committed changes.
deadalnix added a commit: rABC188c6ab4b8e5: Fix concurrency-related bugs in ActivateBestChain.
deadalnix added a commit: rSTAGING188c6ab4b8e5: Fix concurrency-related bugs in ActivateBestChain.Sep 19 2019, 00:44
jasonbcox mentioned this in T623: Backport Core PR 13023.Oct 3 2019, 21:59

Revision Contents
Changeset List

PathSize
src/
16 lines

Diff 9800

View Options

src/validation.cpp

Loading...