Differential D3486

refactor: Drop CWalletRef typedef
ClosedPublic
Actions

Authored by deadalnix on Jun 30 2019, 23:09.

Details

Reviewers

Fabien

Group Reviewers

Restricted Project

Commits

rSTAGING26936e274ee2: refactor: Drop CWalletRef typedef
rABC26936e274ee2: refactor: Drop CWalletRef typedef

Summary

This is extracted from Core PR13017 : https://github.com/bitcoin/bitcoin/pull/13017/commits/6efd9644cfe31168db1841010cffa64dfe604e67

Test Plan

make check

Diff Detail

Repository

rABC Bitcoin ABC

Branch

walletutil

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 6570
Build 11187: Bitcoin ABC Buildbot (legacy)
Build 11186: arc lint + arc unit

Event Timeline

deadalnix created this revision.Jun 30 2019, 23:09

Herald added a reviewer: Restricted Project. · View Herald TranscriptJun 30 2019, 23:09

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing started.

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing passed.

Harbormaster completed remote builds in B6570: Diff 9817.Jun 30 2019, 23:18

deadalnix added a child revision: D3488: wallet: Add AddWallet, RemoveWallet, GetWallet and GetWallets.Jun 30 2019, 23:43

Fabien accepted this revision.Jul 1 2019, 08:39

This revision is now accepted and ready to land.Jul 1 2019, 08:39

Closed by commit rABC26936e274ee2: refactor: Drop CWalletRef typedef (authored by João Barbosa <joao.paulo.barbosa@gmail.com>, committed by deadalnix). · Explain WhyJul 1 2019, 12:21

This revision was automatically updated to reflect the committed changes.

deadalnix added a commit: rABC26936e274ee2: refactor: Drop CWalletRef typedef.

deadalnix added a commit: rSTAGING26936e274ee2: refactor: Drop CWalletRef typedef.Sep 19 2019, 00:47

Revision Contents
Changeset List

Path

Size

src/

interfaces/

node.cpp

2 lines

wallet/

8 lines

4 lines

7 lines

2 lines

2 lines

Diff 9817

View Options

src/interfaces/node.cpp

View Options

src/wallet/init.cpp

View Options

src/wallet/rpcwallet.cpp

View Options

src/wallet/wallet.h

View Options

src/wallet/wallet.cpp

View Options

refactor: Drop CWalletRef typedefClosedPublicActions

Details

Diff Detail

Event Timeline

Revision ContentsChangeset List

Diff 9817

src/interfaces/node.cpp

src/wallet/init.cpp

src/wallet/rpcwallet.cpp

src/wallet/wallet.h

src/wallet/wallet.cpp

src/wallet/walletdb.cpp

refactor: Drop CWalletRef typedef
ClosedPublic
Actions

Revision Contents
Changeset List