Page MenuHomePhabricator

wallet: Add AddWallet, RemoveWallet, GetWallet and GetWallets
ClosedPublic

Authored by deadalnix on Jun 30 2019, 23:43.

Details

Summary

With these new functions all vpwallets usage are removed
and vpwallets is now a static variable (no external linkage).

This is a partial backport of Core PR13017 : https://github.com/bitcoin/bitcoin/pull/13017/commits/373aee26c3df233f4e0a7e806f45ac7cb5aab1e6

Depends on D3486 and D3487

Test Plan
make check

Diff Detail

Repository
rABC Bitcoin ABC
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

deadalnix created this revision.Jun 30 2019, 23:43
Herald added a reviewer: Restricted Project. · View Herald TranscriptJun 30 2019, 23:43
Fabien requested changes to this revision.Jul 1 2019, 08:47
Fabien added a subscriber: Fabien.
Fabien added inline comments.
src/wallet/wallet.cpp
51 ↗(On Diff #9826)

Braces

60 ↗(On Diff #9826)

Dito

71 ↗(On Diff #9826)

Dito

This revision now requires changes to proceed.Jul 1 2019, 08:47
deadalnix updated this revision to Diff 9843.Jul 1 2019, 12:30

rebase and add braces

Fabien accepted this revision.Jul 1 2019, 13:01
This revision is now accepted and ready to land.Jul 1 2019, 13:01