Page MenuHomePhabricator
Differential D3488

wallet: Add AddWallet, RemoveWallet, GetWallet and GetWallets
ClosedPublic
Actions

Authored by deadalnix on Jun 30 2019, 23:43.

Details

Reviewers
Fabien
Group Reviewers
Restricted Project
Commits
rSTAGING8c14a287a324: wallet: Add AddWallet, RemoveWallet, GetWallet and GetWallets
rABC8c14a287a324: wallet: Add AddWallet, RemoveWallet, GetWallet and GetWallets
Summary

With these new functions all vpwallets usage are removed
and vpwallets is now a static variable (no external linkage).

This is a partial backport of Core PR13017 : https://github.com/bitcoin/bitcoin/pull/13017/commits/373aee26c3df233f4e0a7e806f45ac7cb5aab1e6

Depends on D3486 and D3487

Test Plan
make check

Diff Detail

Repository
rABC Bitcoin ABC
Branch
walletutil
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 6573
Build 11193: Bitcoin ABC Buildbot (legacy)
Build 11192: arc lint + arc unit

Event Timeline

deadalnix created this revision.Jun 30 2019, 23:43
Herald added a reviewer: Restricted Project. · View Herald TranscriptJun 30 2019, 23:43
teamcity added a comment.Jun 30 2019, 23:43

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing started.

teamcity added a comment.Jun 30 2019, 23:50

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing passed.

Harbormaster completed remote builds in B6573: Diff 9826.Jun 30 2019, 23:50
deadalnix added a child revision: D3490: wallet: Add HasWallets.Jun 30 2019, 23:50
Fabien requested changes to this revision.Jul 1 2019, 08:47
Fabien added a subscriber: Fabien.
Fabien added inline comments.
src/wallet/wallet.cpp
51

Braces

60

Dito

71

Dito

This revision now requires changes to proceed.Jul 1 2019, 08:47
deadalnix updated this revision to Diff 9843.Jul 1 2019, 12:30

rebase and add braces

teamcity added a comment.Jul 1 2019, 12:30

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing started.

Harbormaster completed remote builds in B6584: Diff 9843.Jul 1 2019, 12:40
teamcity added a comment.Jul 1 2019, 12:40

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing passed.

Fabien accepted this revision.Jul 1 2019, 13:01
This revision is now accepted and ready to land.Jul 1 2019, 13:01
Closed by commit rABC8c14a287a324: wallet: Add AddWallet, RemoveWallet, GetWallet and GetWallets (authored by João Barbosa <joao.paulo.barbosa@gmail.com>, committed by deadalnix). · Explain WhyJul 1 2019, 13:54
This revision was automatically updated to reflect the committed changes.
deadalnix added a commit: rABC8c14a287a324: wallet: Add AddWallet, RemoveWallet, GetWallet and GetWallets.
deadalnix added a commit: rSTAGING8c14a287a324: wallet: Add AddWallet, RemoveWallet, GetWallet and GetWallets.Sep 19 2019, 00:47

Revision Contents
Changeset List

PathSize
src/
interfaces/
2 lines
qt/
test/
6 lines
rpc/
2 lines
wallet/
12 lines
24 lines
test/
12 lines
5 lines
33 lines
2 lines

Diff 9826

View Options

src/interfaces/node.cpp

Loading...
View Options

src/qt/test/wallettests.cpp

Loading...
View Options

src/rpc/misc.cpp

Loading...
View Options

src/wallet/init.cpp

Loading...
View Options

src/wallet/rpcwallet.cpp

Loading...
View Options

src/wallet/test/wallet_tests.cpp

Loading...
View Options

src/wallet/wallet.h

Loading...
View Options

src/wallet/wallet.cpp

Loading...
View Options

src/wallet/walletdb.cpp

Loading...